Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp349055rdb; Thu, 15 Feb 2024 01:55:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVg71ShBpZQCVWrdCXJFcSAmK+vsLfaCDC4SDB6nV2VKQtseDBZAM8XznrIhqKiNNdUaY3DpnF3rtlbxWcIxqO3EIhcChIxvuQWhjcL+A== X-Google-Smtp-Source: AGHT+IERLGnT0+70yeCKCi2Pk4vR9yoVhVVfBX5inIvP29gIbJDTciaYMmgDforT6qki5Kb6Odv3 X-Received: by 2002:a05:620a:3915:b0:787:15b9:fa04 with SMTP id qr21-20020a05620a391500b0078715b9fa04mr1128907qkn.78.1707990904825; Thu, 15 Feb 2024 01:55:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707990904; cv=pass; d=google.com; s=arc-20160816; b=FXqgxjBuEPz8wdGWfcbIWNG+Ze7ulJCuJiqtM2Bd67x25EUuX+AMtbqfi/EakExIA5 +qR5Ds0jrwpaGjIpemejGJrBSyUkP9yM55ZvTuwrSqvA6BfKjg67QCxzUQG/kBt/P5H9 9XotJ1E3WOqHzmiSA2cJGLq1b/RmhVBkWDIe9NUmLjpA0gqtEE5Buz77foe5eUUB61PQ ILKEy0qLPz5G75+9N+vySMG2YeTZFEx5EpMqOlSPBMZAlknjR/WJ9dA4izu1ppMcaaV7 3ERNcT7LAmLhOU5HafLdeUN5prVp6RzDI4zziPa4aLZFVLFOb7SmxgYnCEfaCQfDjh4K +axA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=/j3sG8zVzAaJdDW10fbg6ZPrxLU0cyyH/EMcNo4s3n0=; fh=g4ImV1cQwfXYrwRysxGkHlQx+ozNqapl8ezr14TZUVo=; b=bI7FHmKAGRlyAG8rJmWnJeb4SYQk3kqL/cHSQYIuJ1Dt+MBglaBZf0gLNeznYlaQoG +NIvcv+CQaRkjuNE4r1I093U2P3EHeqRL3sMTR6JwVv+0toA/cOz6ulMrYA+0cHDAfXk DwD3xo6p2+EkkUwKldkZGZw72jqGG+kxw6kmu7xkS0poY/E/aBocGBixnG5cM0RLVe8A XUu4JHN3nbL1we0SFB1qAOt11TRqfzlLBCcTsD/wsWfKXkK+0rP8jwXYThhUCYb1Q8z2 f36oVuKSxwHtC/za/rzIO3i6DNR2hmSfXEvMgOSR2d86EAc/Rr4Of1lwN5B+dwnxNMhZ 3u9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-66579-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66579-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id p15-20020a05620a22ef00b007872a3c185dsi1090512qki.14.2024.02.15.01.55.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 01:55:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66579-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-66579-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66579-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 875461C219B0 for ; Thu, 15 Feb 2024 09:55:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2083C63CAE; Thu, 15 Feb 2024 09:54:56 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C934C6350A for ; Thu, 15 Feb 2024 09:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707990895; cv=none; b=oKcKMaiX+UYCgyp7Ii51o3VGYC/SW+I2aJJbwHvu2XMwFAJYdsyERAiJ+JvEG+DjAbUUSLrqsAlD2WA2ZolsIe3TP6GIIOZ+5CQOKQXe4AfuvOtOKHIa8FnxPcpnzR5erQaRzRf3l56rI7crGup/vN4Lxgx2Y1T18FkAi8jfuGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707990895; c=relaxed/simple; bh=RNF989/m20IyPhB5QfOKoOvl9/hYrxwPiHxxPlAAJzk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PjwnmpGZ0wxV6IfCOH6szv2Mll6J+pNP1AxVfb4jQEW/gUg1l4VVw/+Aba2RPQHkwEQY/dF+JVDLD6e3zLe2dyRb2ZOwHLDFgSYC9+ZTtOx4tv8awfrTpthT9JAJKegf1HD1oBj/8e9BjRvUXxjoS2iKPz+BA8pGPV/qELoM9Qg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1raYRr-00047w-9k; Thu, 15 Feb 2024 10:54:31 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1raYRp-000rFT-Ba; Thu, 15 Feb 2024 10:54:29 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1raYRp-005HU7-0o; Thu, 15 Feb 2024 10:54:29 +0100 Date: Thu, 15 Feb 2024 10:54:28 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Dharma Balasubiramani Cc: sam@ravnborg.org, bbrezillon@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lee@kernel.org, thierry.reding@gmail.com, linux-pwm@vger.kernel.org, hari.prasathge@microchip.com, manikandan.m@microchip.com, Conor Dooley Subject: Re: [linux][PATCH v6 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema Message-ID: <4psibzz7xylyp3zbmp3gup2gojh77bsllkyosbfdacyw4gzxuw@djl7eg4oeg2r> References: <20240202001733.91455-1-dharma.b@microchip.com> <20240202001733.91455-3-dharma.b@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bkvbrrniz7f544mh" Content-Disposition: inline In-Reply-To: <20240202001733.91455-3-dharma.b@microchip.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org --bkvbrrniz7f544mh Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Fri, Feb 02, 2024 at 05:47:32AM +0530, Dharma Balasubiramani wrote: > Convert device tree bindings for Atmel's HLCDC PWM controller to YAML > format. >=20 > Signed-off-by: Dharma Balasubiramani > Reviewed-by: Conor Dooley > --- > Changelog > v5 -> v6 > - Drop the example as we have one complete example in mfd binding. > v4 -> v5 > v3 -> v4 > - No changes > Note: The clean up patch will be sent later as Sam suggested. > v2 -> v3 > - Remove '|' in description, as there is no formatting to preserve. > - Delete the description for pwm-cells. > - Drop the label for pwm node as it not used. > v1 -> v2 > - Remove the explicit copyrights. > - Modify title (not include words like binding/driver). > - Modify description actually describing the hardware and not the driver. > - Remove pinctrl properties which aren't required. > - Drop parent node and it's other sub-device node which are not related h= ere. > --- > .../bindings/pwm/atmel,hlcdc-pwm.yaml | 35 +++++++++++++++++++ > .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 --------------- > 2 files changed, 35 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm= =2Eyaml > delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm= =2Etxt >=20 > diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b= /Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > new file mode 100644 > index 000000000000..0e92868a2b68 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/atmel,hlcdc-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel's HLCDC's PWM controller > + > +maintainers: > + - Nicolas Ferre > + - Alexandre Belloni > + - Claudiu Beznea > + > +description: > + The LCDC integrates a Pulse Width Modulation (PWM) Controller. This bl= ock > + generates the LCD contrast control signal (LCD_PWM) that controls the > + display's contrast by software. LCDC_PWM is an 8-bit PWM signal that c= an be > + converted to an analog voltage with a simple passive filter. LCD displ= ay > + panels have different backlight specifications in terms of minimum/max= imum > + values for PWM frequency. If the LCDC PWM frequency range does not mat= ch the > + LCD display panel, it is possible to use the standalone PWM Controller= to > + drive the backlight. > + > +properties: > + compatible: > + const: atmel,hlcdc-pwm > + > + "#pwm-cells": > + const: 3 > + > +required: > + - compatible > + - "#pwm-cells" > + > +additionalProperties: false > diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/= Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > deleted file mode 100644 > index afa501bf7f94..000000000000 > --- a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -Device-Tree bindings for Atmel's HLCDC (High-end LCD Controller) PWM dri= ver > - > -The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. > -See ../mfd/atmel-hlcdc.txt for more details. > - > -Required properties: > - - compatible: value should be one of the following: > - "atmel,hlcdc-pwm" > - - pinctr-names: the pin control state names. Should contain "default". > - - pinctrl-0: should contain the pinctrl states described by pinctrl > - default. > - - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells > - bindings defined in pwm.yaml in this directory. > - > -Example: > - > - hlcdc: hlcdc@f0030000 { > - compatible =3D "atmel,sama5d3-hlcdc"; > - reg =3D <0xf0030000 0x2000>; > - clocks =3D <&lcdc_clk>, <&lcdck>, <&clk32k>; > - clock-names =3D "periph_clk","sys_clk", "slow_clk"; > - > - hlcdc_pwm: hlcdc-pwm { > - compatible =3D "atmel,hlcdc-pwm"; > - pinctrl-names =3D "default"; > - pinctrl-0 =3D <&pinctrl_lcd_pwm>; > - #pwm-cells =3D <3>; > - }; > - }; I guess dropping the example is fine because it's included now in the mfd binding. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for= -next Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --bkvbrrniz7f544mh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXN31QACgkQj4D7WH0S /k6NeAf9EVR8Xz9GuvTvAqU0vc/y1P/c6V7/AtXRwh5HxqS2eziYkB1DZ7gU7MzY pZ5nyNIvTFXxrcGr4jKn8XaFMUVLaduPRRld8o4OpCxgrRcdG6yj+MRox9gQ4eTq H31V7tmZCubtMX1CIrNgFv91u6mj2tnndzxCS2MpVIYCt4SVG0SH9Yah3VTZ2Q4h zHteuvTsi/4n0JIx4qBGjJerCR8+5DrTW4NxbawleSuXpqfbSSPfabVjPHd4sA9g DnREROuPWeL3QV/aQ3F7X9y2FcfjK1B2F7V3MVm6N/S7Y/gT7NjmF1985t9O3hmK hxUuN2McBmMJC3yK4gUBzlAYjOCE3w== =Q1fN -----END PGP SIGNATURE----- --bkvbrrniz7f544mh--