Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp354476rdb; Thu, 15 Feb 2024 02:06:43 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWpkJaNWFHOITAwRvNXX8Qv1eEWKeN8OkbVTQV6FBR1ODFZqovcBqbx/05LhhYwqzgAYSzm/+W8nqQR13JyMER4TRJk7VGlrnY6QgNScA== X-Google-Smtp-Source: AGHT+IHP4Z3e5DJFprFH09JxTh664rKJxTGh6TTrQgxYf9Vp5qpFYS8v428JKJAtqtZAZtHkrzFJ X-Received: by 2002:a17:902:d548:b0:1db:306c:5ab8 with SMTP id z8-20020a170902d54800b001db306c5ab8mr1372909plf.2.1707991603073; Thu, 15 Feb 2024 02:06:43 -0800 (PST) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id me14-20020a170902fc4e00b001db7607a9fasi927217plb.611.2024.02.15.02.06.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 02:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66591-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-66591-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66591-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D8DE92814EE for ; Thu, 15 Feb 2024 10:04:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B945E664D2; Thu, 15 Feb 2024 10:04:24 +0000 (UTC) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B266865BCA; Thu, 15 Feb 2024 10:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707991464; cv=none; b=cVjwCs/KqgtIXPTIuMi9XVF0mR2V3St2RLqYjd0LjM8ANTAnA5jBWxQRzm6y29f66q4/0MfRe7+dq5k7ZH3bF+JFEulJwxC0Byov25LOGZkEcIKDHkOc7vLOl9PZQO5Pgo9nnsWFksIRyJ0lWwxyRF8VXtnOfh4XYW2T3+nLhNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707991464; c=relaxed/simple; bh=qaOdbpvLWIG7x4OZMARezMZygtF5+QCRiMI+aT7zXVQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=sADLKBdQNrkRsuzDNGFVpsadmnZJwiFqHXpQKIAClKJ3t6QIleBV2j+CATYSLvxXBLIbmtI9scFRVwzX0izw+5TNYrV6isF9y5rEMFJBGcgJNJw3Jh850NyA6HcyzWv9ohLIJads5LMwVQ29x3d/UL9xqD93w7hcGCkFFnDtkVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2d0d95e8133so8197651fa.1; Thu, 15 Feb 2024 02:04:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707991458; x=1708596258; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yfkzCOLAUXAKQEpWTCc6rSRUSsh+fGIBUHKjj5JlZFk=; b=KjSbQivN6tsR9TY7JXH8DcrkdKOR4yKwVfpiqkgiqyKbhf+J+wZ+P2vnLobVRCy6hx BvPoez2B1gm42Cn/4yMebvNfwV/GlDHhTDsue+MAHbFbOXvzhVyhbcsUubsIzbjm6Fz5 0Z+Mze5QrpkpHrUbEmRONvlOHY4n+ePeL/Rj6Azi0wiOJmNQ+1J59rV816i8N0CgOKgy o2XpLqn+onr1NU7TOFnKfnf/6ijbz2Op0W2JBRLdK0CAh8m3/xUaw6p+JxOHnKIK/bWi 3qr0OxGHcYm+QHOt8LYiVueLJc2LN7SM2j58hb5rEu1/9Vb8dqSYX+68TPleBwzl5ps4 E7hw== X-Forwarded-Encrypted: i=1; AJvYcCW4PSg6WPc9x+EOirWu1oW8fPZZW1m2FTEdHJ7k7NpOHOdJS891bD3gROBjbSRFIRbQPhsoEh7b3K8HGbDqvPzvv74TA3x0gQLbeAKA X-Gm-Message-State: AOJu0YxCzA+s4XugMulyRhP01mNVIo1qZTIXSyB54/SprNCUHCfbNR0Q WhAGg1FldiedcPOI6ZjUhqljALBYS+8Gtj74OfJLm+vGprCdqrSHHgV8lyXkmr629A== X-Received: by 2002:a2e:7a12:0:b0:2d0:b003:95b7 with SMTP id v18-20020a2e7a12000000b002d0b00395b7mr965778ljc.13.1707991458275; Thu, 15 Feb 2024 02:04:18 -0800 (PST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id a11-20020a2e980b000000b002d11aaa0ce2sm210210ljj.114.2024.02.15.02.04.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 02:04:16 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-51288b2b549so385929e87.2; Thu, 15 Feb 2024 02:04:05 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUvuZExTDVGay3zi34Fpu3V7AZtc9MpoW2dH3GRTCuqb5fRRTDEwSzYd5h9CwLAsI3puFdk0PPRihKA/FJ9h0NDA0hmV9teTO3sjRPw X-Received: by 2002:ac2:4f87:0:b0:511:5352:649f with SMTP id z7-20020ac24f87000000b005115352649fmr846968lfs.19.1707991445402; Thu, 15 Feb 2024 02:04:05 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> <20240212170423.2860895-5-andriy.shevchenko@linux.intel.com> In-Reply-To: <20240212170423.2860895-5-andriy.shevchenko@linux.intel.com> From: Geert Uytterhoeven Date: Thu, 15 Feb 2024 11:03:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 04/15] auxdisplay: linedisp: Unshadow error codes in ->store() To: Andy Shevchenko Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Andy Shevchenko wrote: > kstrtox() may return different error codes. > > Unshadow them in the ->store() callback to give better error report. > > While at it, add missing kstrtox.h inclusion. > > Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds