Received-SPF: pass (google.com: domain of linux-kernel+bounces-66672-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> <20240212170423.2860895-10-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240212170423.2860895-10-andriy.shevchenko@linux.intel.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 15 Feb 2024 11:36:47 +0100
Message-ID: <CAMuHMdV3TOXc-_L5qG7D_XyFUcgNOyCoOwBhFPqNFBfAVyVydA@mail.gmail.com>
Subject: Re: [PATCH v2 09/15] auxdisplay: linedisp: Add support for overriding
 character mapping
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Andy Shevchenko <andy@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Robin van der Gracht <robin@protonic.nl>, Paul Burton <paulburton@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> There is already the driver using character mapping table for
> 7 or 14 segment display. It is possible to override it. Make
> the similar in the line display library to allow other drivers
> to utilise the same functionality.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

One question below.

> --- a/drivers/auxdisplay/line-display.c
> +++ b/drivers/auxdisplay/line-display.c

> +static const struct attribute_group linedisp_group =3D {
> +       .is_visible     =3D linedisp_attr_is_visible,

Shouldn't that be .is_bin_visible?

> +       .attrs          =3D linedisp_attrs,

Likewise, .bin_attrs?
But that is a pre-existing issue in the ht16k33 driver.

> +};
> +__ATTRIBUTE_GROUPS(linedisp);

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds