Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp370935rdb; Thu, 15 Feb 2024 02:49:25 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWeDcjVcX0TzkJ5FyaV8mg0fsPh92gni71bVPErYL4/zyEsEsKGdd7l41LYgPoDY+W9uxXXS+w6Wofyg3O0+/Tl5NAPyU8qRE8rN52cLA== X-Google-Smtp-Source: AGHT+IFYG0B7aOEyoip27Nk+vZ9T5nK72YCp7nxGnSFIG54LKEO1ZCCrWmbl62K2nZjgUqzC83EV X-Received: by 2002:a17:902:a3cf:b0:1d8:e64d:cd5e with SMTP id q15-20020a170902a3cf00b001d8e64dcd5emr1370482plb.39.1707994165101; Thu, 15 Feb 2024 02:49:25 -0800 (PST) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id ma12-20020a170903094c00b001db2ac688dasi973647plb.258.2024.02.15.02.49.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 02:49:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-66588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66588-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6D73CB24DD6 for ; Thu, 15 Feb 2024 10:03:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 73DAB67E97; Thu, 15 Feb 2024 10:03:33 +0000 (UTC) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4339F67A1D; Thu, 15 Feb 2024 10:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707991413; cv=none; b=ttQgAnX4jJjDTeP8CDgvNeMgMR5Bwv5hL/y1aPn2HG1WaKTpczwNHrDRpvTCCLCi+5r5JYRlM2iWr9SAp3GoGmgA2PDhyw96bMnD8ivNUFtk9v/+e1pQccKHWbiY3oYt3dY1dv/PvyQLT3251Q3n6CKeJzKjIr3UwBRy1ED2vhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707991413; c=relaxed/simple; bh=YR8V0MA5kiA/Ck9lEvtlu9Lql6GumNZzdxBHtm5MY+0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=jq+RImFeeZeLnNUnKU7XntPUwCXyjGo+zfFG50/tr+WpRyADjs2/1vPAdF2mWPEze/lUbPFIOthXm/+5JNBh9lRttEn7YobOc8ZKWPmyI11hhXp4h7mJl+Nue8c/dae6EAOAg1Z7YZOeoqYI6TRH6nyvqIzSOJ4birYoBGF+it8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-607dca92fcaso1793387b3.1; Thu, 15 Feb 2024 02:03:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707991409; x=1708596209; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xJUkHPWrDHGs9cgj6Y6TdBYDhS9RdlMKz0F9hIT5hPI=; b=HGh4vxqoVOJkpG4FUJr2NBL4F6reHYvCfIcww7f6v7T/ydOTO2LfsBDzBhnNyh5q7K RTKSUvda+8MRF3AUvAc3+bdyd8KYkkynlATT4tO0rrQoiAKoT7/zmEdDLUCs6QtfahDW 3nZXpBJJizQjHf/bJyK5hH/CjL/TtzxqVTwd0+wfMUXLLDeY9e+keWaYwN5H8JPZooMS rCeje/Y7CCdiM5tBKxrGvfF+SUgQgiDfJl28ze4ee9RMb9hkimVppHpfgAZLmraFxPAz 5UCr4GXkztiafOlZribOw/lN7nJFbew4cBx2u60YFM/gMz7sWnAWa1ObpHPb/wHaQ3d/ GkOw== X-Forwarded-Encrypted: i=1; AJvYcCWzDRW98ybjF6t+oL6etnz3uMwvuuvAiuztJnbnoYtvHQyDyZSd8SgsBqlxBPPXN14dWonsGJ9Xg7rsbdtCcHTcb1Hp/oKRqc82diG3 X-Gm-Message-State: AOJu0YyEdcFbG9nXc9LHvAMp57GwCCbHvL1TdetT4tMb80u8610TxIMG M0C00HumRjmcyNoBd5Gy8odKi20mzgzfPGJfVOL7NOPKA1gMNX8C4d2n6iVoXLA= X-Received: by 2002:a0d:d709:0:b0:5ff:b0ac:ffb1 with SMTP id z9-20020a0dd709000000b005ffb0acffb1mr1343729ywd.19.1707991409594; Thu, 15 Feb 2024 02:03:29 -0800 (PST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com. [209.85.128.171]) by smtp.gmail.com with ESMTPSA id t22-20020a0dea16000000b0060778320f39sm183881ywe.1.2024.02.15.02.03.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 02:03:29 -0800 (PST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-607bfa4c913so6508027b3.3; Thu, 15 Feb 2024 02:03:29 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUXCEbs4JZG9ZXkvco0+UikiQGYxQd/ZH596Fl0sHiwwNa70noKEpDXJ4DTFsEM8J3jh/DTmTZsGHpGs+NE4mWN69YcZvX4NXI5eYIV X-Received: by 2002:a81:9f0d:0:b0:607:8edd:b5f7 with SMTP id s13-20020a819f0d000000b006078eddb5f7mr895866ywn.49.1707991409152; Thu, 15 Feb 2024 02:03:29 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> <20240212170423.2860895-3-andriy.shevchenko@linux.intel.com> In-Reply-To: <20240212170423.2860895-3-andriy.shevchenko@linux.intel.com> From: Geert Uytterhoeven Date: Thu, 15 Feb 2024 11:03:17 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 02/15] auxdisplay: linedisp: Free allocated resources in ->release() To: Andy Shevchenko Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Andy Shevchenko wrote: > While there is no issue currently with the resources allocation, > the code may still be made more robust by deallocating message > in the ->release() callback. > > Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds