Received-SPF: pass (google.com: domain of linux-kernel+bounces-66704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> <20240212170423.2860895-13-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240212170423.2860895-13-andriy.shevchenko@linux.intel.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 15 Feb 2024 11:44:34 +0100
Message-ID: <CAMuHMdUqvotuuj6p7SNVo3X+BRvc0MAeQ9krLnJVQywr6rzOKg@mail.gmail.com>
Subject: Re: [PATCH v2 12/15] auxdisplay: ht16k33: Switch to use line display
 character mapping
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Andy Shevchenko <andy@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Robin van der Gracht <robin@protonic.nl>, Paul Burton <paulburton@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Since line display library supports necessary bits to map the characters
> (if required), switch this driver to use that.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Minor nits below.

> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -445,18 +413,20 @@ static void ht16k33_seg7_update(struct work_struct =
*work)
>         struct ht16k33_priv *priv =3D container_of(work, struct ht16k33_p=
riv,
>                                                  work.work);
>         struct ht16k33_seg *seg =3D &priv->seg;
> +       struct linedisp *linedisp =3D &seg->linedisp;
> +       struct linedisp_map *map =3D linedisp->map;

struct linedisp_map *map =3D seg.linedisp->map;

as linedisp is not used below.

>         char *s =3D seg->curr;
>         uint8_t buf[9];
>
> -       buf[0] =3D map_to_seg7(&seg->map.seg7, *s++);
> +       buf[0] =3D map_to_seg7(&map->map.seg7, *s++);
>         buf[1] =3D 0;
> -       buf[2] =3D map_to_seg7(&seg->map.seg7, *s++);
> +       buf[2] =3D map_to_seg7(&map->map.seg7, *s++);
>         buf[3] =3D 0;
>         buf[4] =3D 0;
>         buf[5] =3D 0;
> -       buf[6] =3D map_to_seg7(&seg->map.seg7, *s++);
> +       buf[6] =3D map_to_seg7(&map->map.seg7, *s++);
>         buf[7] =3D 0;
> -       buf[8] =3D map_to_seg7(&seg->map.seg7, *s++);
> +       buf[8] =3D map_to_seg7(&map->map.seg7, *s++);
>
>         i2c_smbus_write_i2c_block_data(priv->client, 0, ARRAY_SIZE(buf), =
buf);
>  }
> @@ -466,17 +436,39 @@ static void ht16k33_seg14_update(struct work_struct=
 *work)
>         struct ht16k33_priv *priv =3D container_of(work, struct ht16k33_p=
riv,
>                                                  work.work);
>         struct ht16k33_seg *seg =3D &priv->seg;
> +       struct linedisp *linedisp =3D &seg->linedisp;
> +       struct linedisp_map *map =3D linedisp->map;

Likewise.

>         char *s =3D seg->curr;
>         uint8_t buf[8];
>
> -       put_unaligned_le16(map_to_seg14(&seg->map.seg14, *s++), buf);
> -       put_unaligned_le16(map_to_seg14(&seg->map.seg14, *s++), buf + 2);
> -       put_unaligned_le16(map_to_seg14(&seg->map.seg14, *s++), buf + 4);
> -       put_unaligned_le16(map_to_seg14(&seg->map.seg14, *s++), buf + 6);
> +       put_unaligned_le16(map_to_seg14(&map->map.seg14, *s++), buf + 0);
> +       put_unaligned_le16(map_to_seg14(&map->map.seg14, *s++), buf + 2);
> +       put_unaligned_le16(map_to_seg14(&map->map.seg14, *s++), buf + 4);
> +       put_unaligned_le16(map_to_seg14(&map->map.seg14, *s++), buf + 6);
>
>         i2c_smbus_write_i2c_block_data(priv->client, 0, ARRAY_SIZE(buf), =
buf);
>  }

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds