Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp378016rdb; Thu, 15 Feb 2024 03:04:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXsgd7CyCqAj3dFXiikZxJiwnYii7FM77Zpedsu5c4o5vLHQS7Ri0cm3ppGxU103Gcgmu1c42e2Jb7xVKIEj0cv/Vm64eD37EnmHx35QQ== X-Google-Smtp-Source: AGHT+IG+eLK9QllHJDxmQDXo4TxNDVSUVQy7Y8ED/5Vc5lZEXFyxYpxNn5WsJR0xfldtPB2wwllR X-Received: by 2002:a17:90b:23cc:b0:297:1927:71ed with SMTP id md12-20020a17090b23cc00b00297192771edmr1291209pjb.6.1707995084516; Thu, 15 Feb 2024 03:04:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707995084; cv=pass; d=google.com; s=arc-20160816; b=XYwJBdElqvbYw8QQsaFyy5rukplvCphVeXH7/JRTJtoxnksMCQrmcxHckikNH8gStP /AwPqnaD9aXNx7FUh6VTf71PvQJnZecwWFCQIMnJYyFiCD0UDsyEUohtnHxhjynsFx7I 907oPNwEZAIeVJDv3UAJLMmNeRjDLGOlV6qHDoDfmXt9ydftJiUbX2IHqRIbntLpqF5N hnK0nh3sB4EQBnmF8ldoZ791+z6iaSbCdhoBoV8XkHEuxJw30KMoRps/Le+t/iNl67T5 9MWmaK68Aa5UWFGzxzUHRTIo5x7xtwoVnOCfpjX1hTryD/DbXyRnQZNYXG79sAR+WYWL zfxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; fh=Y4dxnW1/QzdWwCLFSwRGbbxHIEpEwGYbtdT1xeEyRq4=; b=fYMEzHAHG2GRd3Ykcv8IrznK6R2VE2NP1NxqNytDu9vLRAXb+L0FJ2jFxWI885vDaV SvswvDnOga9/mCZw2b3fTf5ZUMnmVMVDcSCXYVQ+/nhEhVlxqxFt+LbDPufU6b8Dcy86 HaOw/XkxFzP7g2FyRtmnV/PjsFjU78QT4OOn2pWbx+nXmQGqa1lXH+B8VhExSk75okja ml4ndJofBhxnFFZ5Ll94bT16jLX/Nhyx8Q2e5HW5iWfxMsirxdnqe7PxeFBHaYDLAV4C VJjFAzVcjJmbIPn0EyU3g+1pzl6DtHHkX8HA7ctaNCGGo5JqRSzsQI6M4shC2AvEMEen xLzg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-66719-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66719-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id oh7-20020a17090b3a4700b00296e1c56241si1047793pjb.61.2024.02.15.03.04.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 03:04:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66719-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-66719-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66719-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 22E9A2834E7 for ; Thu, 15 Feb 2024 11:03:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE150130ADA; Thu, 15 Feb 2024 10:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="Med1oLNB"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="1Q6pc7gW"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="Med1oLNB"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="1Q6pc7gW" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D67F1EF1D for ; Thu, 15 Feb 2024 10:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707994524; cv=none; b=Ww9oq2caOQIoHCfkk70C1Tjg8iArMFRKRWp2BNUIZCffZmbTFWA7CLxog6OXY9DSXTS0qYiPxArVqu+HmDIdoFY+vC02xZoHpoCcuRaDjNrsxXtufY38IiHwkXacicNkDDbrPP+wKH6NcVSa6bN0ZG5gib0B+tBfMtylRyzgi/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707994524; c=relaxed/simple; bh=yXKEXe+jJogGmhKlWXxl4a3x7CycnAlkIpxDarAvsrI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EK2HqhJiX6VC8/v+98Q5xeSubF3TzQBbtnHc4ZSK4aW+Ie8bHcsadzIP5XDojfULNttMU7HgtGJQgjb292fEPYMbDWrnSyGDhBtyyXcOUWWyBR6wf/MqbWiCTpOys1I011zUb7U6ns9DJBXiKzrau7812mqlbpG0O0Pbv5qia1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=Med1oLNB; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=1Q6pc7gW; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=Med1oLNB; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=1Q6pc7gW; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7620121EAD; Thu, 15 Feb 2024 10:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=Med1oLNBn8ZxJaQi8g8abR9bH07zjIDiqfHz5vVXZO+L7FZdhzXlUP8oSLf9mf9Nyq23gY KEZEEzbm66IGnQ5dlpl3PAo+dqQauhiczaI8OckRQZdXBTf4nMuaPnxlOfBMs5Sfs8zclj tiwZc2dN5rtc0Smzl9i9Mht9OS7ODGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=1Q6pc7gWYUiEcvWs+VGr5UkOJAPDG3idD38iOFbVW6Tx09REjnsWsYt6zh/xmFY49gJlsb EuzM+ZdnXD1mAVCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=Med1oLNBn8ZxJaQi8g8abR9bH07zjIDiqfHz5vVXZO+L7FZdhzXlUP8oSLf9mf9Nyq23gY KEZEEzbm66IGnQ5dlpl3PAo+dqQauhiczaI8OckRQZdXBTf4nMuaPnxlOfBMs5Sfs8zclj tiwZc2dN5rtc0Smzl9i9Mht9OS7ODGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=1Q6pc7gWYUiEcvWs+VGr5UkOJAPDG3idD38iOFbVW6Tx09REjnsWsYt6zh/xmFY49gJlsb EuzM+ZdnXD1mAVCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6162813A53; Thu, 15 Feb 2024 10:55:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1/hrF5jtzWXAMAAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 10:55:20 +0000 Message-ID: <08a08ea2-6764-48af-8883-84639c732ce5@suse.cz> Date: Thu, 15 Feb 2024 11:55:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 3/7] mm,page_owner: Maintain own list of stack_records structs Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-4-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: <20240214170157.17530-4-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.46 X-Spamd-Result: default: False [-1.46 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; BAYES_HAM(-0.17)[69.92%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[vger.kernel.org,kvack.org,suse.com,google.com,gmail.com]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Flag: NO On 2/14/24 18:01, Oscar Salvador wrote: > page_owner needs to increment a stack_record refcount when a new allocation > occurs, and decrement it on a free operation. > In order to do that, we need to have a way to get a stack_record from a > handle. > Implement __stack_depot_get_stack_record() which just does that, and make > it public so page_owner can use it. > > Also, traversing all stackdepot buckets comes with its own complexity, > plus we would have to implement a way to mark only those stack_records > that were originated from page_owner, as those are the ones we are > interested in. > For that reason, page_owner maintains its own list of stack_records, > because traversing that list is faster than traversing all buckets > while keeping at the same time a low complexity. > > For now, add to stack_list only the stack_records of dummy_handle and > failure_handle, and set their refcount of 1. > > Further patches will add code to increment or decrement stack_records > count on allocation and free operation. > > Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka