Received-SPF: pass (google.com: domain of linux-kernel+bounces-66612-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> <20240212170423.2860895-9-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240212170423.2860895-9-andriy.shevchenko@linux.intel.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 15 Feb 2024 11:13:31 +0100
Message-ID: <CAMuHMdXWu4JYT5wCX8sbwdM8gt571JakL1UHi2SGd5wKB41pxQ@mail.gmail.com>
Subject: Re: [PATCH v2 08/15] auxdisplay: linedisp: Provide struct
 linedisp_ops for future extension
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Andy Shevchenko <andy@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Robin van der Gracht <robin@protonic.nl>, Paul Burton <paulburton@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Currently the line display library doesn't scale in case we want to
> provide more operations. Prepare the library to take a newly created
> struct linedisp_ops that scales.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

For the code changes:
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -696,8 +700,7 @@ static int ht16k33_seg_probe(struct device *dev, stru=
ct ht16k33_priv *priv,
>         if (err)
>                 return err;
>
> -       err =3D linedisp_register(&seg->linedisp, dev, 4, seg->curr,
> -                               ht16k33_linedisp_update);
> +       err =3D linedisp_register(&seg->linedisp, dev, 4, seg->curr, &ht1=
6k33_linedisp_ops);

Please wrap this long line (everywhere).
All lines in these drivers fit in 80-columns before.

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds