Received-SPF: pass (google.com: domain of linux-kernel+bounces-66710-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> <20240212170423.2860895-14-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240212170423.2860895-14-andriy.shevchenko@linux.intel.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 15 Feb 2024 11:46:32 +0100
Message-ID: <CAMuHMdUMgGsuxo+hB9EDeq+ZU3awUMYok1NWKTaR4Yu61W7kEQ@mail.gmail.com>
Subject: Re: [PATCH v2 13/15] auxdisplay: ht16k33: Use buffer from struct linedisp
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Andy Shevchenko <andy@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Robin van der Gracht <robin@protonic.nl>, Paul Burton <paulburton@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> struct linedips embedds a small buffer for the string that we may reuse.
> Update the driver accordingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Two nits below.

> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -451,8 +444,7 @@ static void ht16k33_seg14_update(struct work_struct *=
work)
>
>  static int ht16k33_linedisp_get_map_type(struct linedisp *linedisp)
>  {
> -       struct ht16k33_priv *priv =3D container_of(linedisp, struct ht16k=
33_priv,
> -                                                seg.linedisp);
> +       struct ht16k33_priv *priv =3D container_of(linedisp, struct ht16k=
33_priv, linedisp);

Please wrap long lines.

>
>         switch (priv->type) {
>         case DISP_MATRIX:
> @@ -471,8 +463,7 @@ static int ht16k33_linedisp_get_map_type(struct lined=
isp *linedisp)
>
>  static void ht16k33_linedisp_update(struct linedisp *linedisp)
>  {
> -       struct ht16k33_priv *priv =3D container_of(linedisp, struct ht16k=
33_priv,
> -                                                seg.linedisp);
> +       struct ht16k33_priv *priv =3D container_of(linedisp, struct ht16k=
33_priv, linedisp);

Likewise.

>
>         schedule_delayed_work(&priv->work, 0);
>  }

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds