Received-SPF: pass (google.com: domain of linux-kernel+bounces-66745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <8f83e1b3-c9d9-4be2-9c95-249e1b1bd898@oracle.com>
Date: Thu, 15 Feb 2024 11:08:40 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/6] fs: iomap: Atomic write support
From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        chandan.babu@oracle.com, martin.petersen@oracle.com,
        linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        ojaswin@linux.ibm.com
References: <20240124142645.9334-1-john.g.garry@oracle.com>
 <20240124142645.9334-2-john.g.garry@oracle.com>
 <20240202172513.GZ6226@frogsfrogsfrogs>
 <2f91a71e-413b-47b6-8bc9-a60c86ed6f6b@oracle.com>
 <20240213065518.GA23539@lst.de>
 <cf2e7d4b-9ad0-4013-8e5a-48047c588411@oracle.com>
Content-Language: en-US
Organization: Oracle Corporation
In-Reply-To: <cf2e7d4b-9ad0-4013-8e5a-48047c588411@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bHNPdUZ3c2NzZmJqdE42THVvMFR0cXM0WkoycnAwTnMwWmVPVkFzVUNrT3hp?=
 =?utf-8?B?eTArM01LcEZmdlNmTGVnMHo5elNlRjA0Y2ZmcUVhK081QnNQbGZQNlZQUitx?=
 =?utf-8?B?TTNtaHJ3b1ZIaExrRUpmbTRQQ00rZDJhQ3JwOFZKdmNDQzQ2Y0NMcnEzUEZ0?=
 =?utf-8?B?M1RvZDNkd1hZVzErSDZMV1loRkEvNFhPNEFIaVJQZFBBcUJPd1NJMDBpb3FU?=
 =?utf-8?B?NEw0RWY0QUNnQzNxMzNvaUFIbmRyWDNjQ3c3U2FhR0xFNFY5amF5d09DV2dB?=
 =?utf-8?B?NC9EV0lpMWpNak9rcGJXR04vK2hSUGVuWjhGU3FqTDk4ZlZZdnZ6dWx6VVRW?=
 =?utf-8?B?R29hUnRFSjE0aGsyR2NZd1Nhb3RZVHFaQU9MSDVGYUsrempSWGQ1M1dFdmYr?=
 =?utf-8?B?dzg4U2tPY3NJY1dvUEMrZkduYzB4UUQ2U2VnKy95VTNNQ3Y3NWlZZU92cFlq?=
 =?utf-8?B?YktIMGRmck1vWUlvNkhUSVlnL21uV0JVMUZ3Z3V5V3RiTDkyYlByTnRlaVRY?=
 =?utf-8?B?ZStpRm9KbklFT3I4eXZKalA2VzFJV2VqN3pseFNyMlZXcVQ4MGFKUCtyZ1NV?=
 =?utf-8?B?Ym1ZcDUzK3kwM09FWUxIT1Q4THBRbmxHQXV2dXd0bmpXc21zMEg1Z3lwMVRZ?=
 =?utf-8?B?K2txUnc5RXBvMDdGdlVwRndLTlJOVDhKN0RjM1FWL3ltUjdXS0tUbFBjUkQ5?=
 =?utf-8?B?QXg1dGVTcXJLTUdYb0ZlSitNR0dNV1JaR3J2cVZkeWRDOTNCcklUUWRaRmV5?=
 =?utf-8?B?aDVYZkc2b1VDVkhYaHBmakY3cDlsZ0VxMGwvVjNuRnMzN2trKzdKaHpmQzlO?=
 =?utf-8?B?QitLMkYvbHBuRW1oSVBlK2lUMi9TeTRoTms2dmhFZ3ZzWlc5T0hKb3B6T1VV?=
 =?utf-8?B?YjVnK2VKRGpsZ1Y4bUR6Q3JCL2lscXY2eVE4U1VDNDBZM2g5Rmt4bSsrcDFk?=
 =?utf-8?B?Sng3c3VOcXVodmx1SHd0VkVUYll6eWxsS2JHdEVsZU1JYzNwZ01ydGZIRlZT?=
 =?utf-8?B?VzRndml1TkRtWFB5UmxjWHVYd0t5MFJtcEVEaWZBWEViLzAxbWtDQjdJV2Vk?=
 =?utf-8?B?U3kvdllGRmdYNyt2MEpPSHN6N3BldWcxb2ZNV3ZDSEZxcG00Q1RuOExRRDVu?=
 =?utf-8?B?anZhdHBLMHI5VDJxZmNPdTBIYTlMcHNQUS95aDBXd092cTlMU0pNTC8wV1RZ?=
 =?utf-8?B?OFhlVU0zR3NNNWYwSVZSSTF3MUhuZVlpaGhld2ZQK0Q2SzhzeDMwcDVtWE5W?=
 =?utf-8?B?YXZCUUszS2t1eTV6ajZLakFnOC9wQXBaMENYcnIvRllNa0RJd045azlyTU02?=
 =?utf-8?B?MUZXNGx1NGhLcGM3cmkyaGZXdjB0VFgzRlZjRGNsSkpzNlU5Y0J2U3FHa2Jm?=
 =?utf-8?B?c01iU0VmcG1MUkhiVFdGNGxrUUkybko1NlFlYWlPNzdmSW81VHlLUEs3djJ6?=
 =?utf-8?B?Z0srbE9Mb25IM2pveHJ0SmhJVjBaelV4SDIxWkRJNXgvSk1pTmYxZHp0bVpv?=
 =?utf-8?B?OGRvZzYyNTJzbm1tK3JWa0tjejd4QnNlZzhyOEZBQjRwWWhDREZxbFVsdUlR?=
 =?utf-8?B?TThLOExGRmFXcWFlUTc4QkJESGdGb25UN0xrTXBFZUhXTERLYVBWQllYTVlp?=
 =?utf-8?B?ME82WVY2QzhJcmVtZktsb2lTWW56R0JvYlo5UnNqMzBJQW5JSDEveWVKdyt3?=
 =?utf-8?B?RWx4UWtvdC84YW0vRm9VMEtEQk8wb3JNQzJYakNkRmwzbjBSakIxc2dua0ZF?=
 =?utf-8?B?R2xSNHgrSjR4cmZNeDA2RFdSaml5ZEUvOXVjL1ZQbFRnait5U1pLaHB0Y1Bj?=
 =?utf-8?B?a3d5K1hOTTA1elArZlBKTXdjQkpqeDV5QTE3VGtBUzFrQldmTlVRY2hyREM2?=
 =?utf-8?B?c2NMVDIxY3pOTWZ2azdNQURNYUNhS2Z3TDFFa3V0NFJJUUYxMGVySVZJM2Nr?=
 =?utf-8?B?U2NLU3EvM1VEckxzT09RbWZiL1l2dkZqMWx1SFl5TnBTZURFN2ZIenhIL2l6?=
 =?utf-8?B?N1ovcnVPazQ0Q0RxdFBkMFg5WDZBVHV0TlpsYmRtb05JT1dpM2VCaUduMHdJ?=
 =?utf-8?B?VUdLaVo4NjkvYzZHQVkzV1dZZnYzWDdLZkpxQUdXSnZOMFlLZG5uYmprSEV2?=
 =?utf-8?B?V2Zia3BoS3JRcmVMYUtHbDRHMXVtK3lCNlRjSUM0MGFSK3dCMHZ4UFhJOUNP?=
 =?utf-8?B?Tmc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Z6t+SgApPipwzZ9EMYU9X/u/PN1ZjP5c+EL02dqEBUwhGoTLolCBAfGCXjBA8Gx5krpl8N6rXAkicaFO90rIfIB54EDdvdV16gE/BYbw5Q6y3zvPx8XK/Y3leDSJmTnfX6Hhl/CY/HW9jrCXdPDyKhDyCrR1Awh1ve0orAV7Zru9PyWpJ099v2PanxosQg0vBfCk8z+UICtM98xJzP7TWLkTaK7R2uRShdmU5p1Cmp0RO09tmkQXaLA0xr3lkejdCvHw+limB8hqxS9tXkxbjpXuw0A4Ltnlxoh20Z65m0KW2RCnPOrqwot4xR2/n6Ov+iRCANEEKnHmhs3n2B2vysBnS4uou904XuZ2gj7itHFL/fXdd5ZGeEUE2viXBgv3XZwTNjxgsGi5sd1jeAAWz3XTEY7/Aaf96RYS4B193QUG/7lNqKe6L/3zaR6HENYWwPbmiblBIkzKWxAUaLQ6dXMQOE2hiyPn5xsrnXWuTfOrh82CidNl3wl26pcl9GPnIa5xRx5Sc5sgNAWVc1si6fD9OTCek6mQ4iwV6o6X+nAD5nUj1WtgHhTt5UO91aOHOZiUfZnpkKa9pUJp+HaWKHLVeeemcaMgG5jzJhABenw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13b6edc7-6611-406f-9742-08dc2e167964
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 11:08:44.2529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m2Aqtf9pREcOQi/Kefk3ss/zyYeJm431mxM5iUqC7005HjMZNkTuMa2FW0zH4qXwDSCvrJE8vlfJtPueYzB03Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6276
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-15_10,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=882 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402150088
X-Proofpoint-ORIG-GUID: T8S3fRmy1C1QVdMNRfCRuHU_b34VWude
X-Proofpoint-GUID: T8S3fRmy1C1QVdMNRfCRuHU_b34VWude

On 13/02/2024 08:20, John Garry wrote:
> On 13/02/2024 06:55, Christoph Hellwig wrote:
>> On Mon, Feb 05, 2024 at 11:29:57AM +0000, John Garry wrote:
>>>> Also, what's the meaning of REQ_OP_READ | REQ_ATOMIC?
>>> REQ_ATOMIC will be ignored for REQ_OP_READ. I'm following the same 
>>> policy
>>> as something like RWF_SYNC for a read.
>> We've been rather sloppy with these flags in the past, which isn't
>> a good thing.  Let's add proper checking for new interfaces.

How about something like this:

----8<----

-static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags)
+static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags, int 
type)
  {
   int kiocb_flags = 0;

..

+ if (flags & RWF_ATOMIC) {
+ 	if (type == READ)
+ 		return -EOPNOTSUPP;
+ 	if (!(ki->ki_filp->f_mode & FMODE_CAN_ATOMIC_WRITE))
+ 		return -EOPNOTSUPP;
+ }
   kiocb_flags |= (__force int) (flags & RWF_SUPPORTED);
   if (flags & RWF_SYNC)
  	 kiocb_flags |= IOCB_DSYNC;

---->8----

I don't see a better place to add this check.

John