Received-SPF: pass (google.com: domain of linux-kernel+bounces-66837-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 15 Feb 2024 11:54:11 +0000
Message-ID: <86o7ci3puk.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Anup Patel <apatel@ventanamicro.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,	Paul Walmsley
 <paul.walmsley@sifive.com>,	Thomas Gleixner <tglx@linutronix.de>,	Rob
 Herring <robh+dt@kernel.org>,	Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>,	Frank Rowand <frowand.list@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,	=?UTF-8?B?QmrDtnJuIFTDtnBlbA==?=
 <bjorn@kernel.org>,	Atish Patra <atishp@atishpatra.org>,	Andrew Jones
 <ajones@ventanamicro.com>,	Sunil V L <sunilvl@ventanamicro.com>,	Saravana
 Kannan <saravanak@google.com>,	Anup Patel <anup@brainfault.org>,
	linux-riscv@lists.infradead.org,	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,	devicetree@vger.kernel.org
Subject: Re: [PATCH v12 04/25] genirq/irqdomain: Add DOMAIN_BUS_DEVICE_IMS
In-Reply-To: <20240127161753.114685-5-apatel@ventanamicro.com>
References: <20240127161753.114685-1-apatel@ventanamicro.com>
	<20240127161753.114685-5-apatel@ventanamicro.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Sat, 27 Jan 2024 16:17:32 +0000,
Anup Patel <apatel@ventanamicro.com> wrote:
>=20
> From: Thomas Gleixner <tglx@linutronix.de>
>=20
> Add a new domain bus token to prepare for device MSI which aims to replace
> the existing platform MSI maze.
>=20
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
>  include/linux/irqdomain_defs.h | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/include/linux/irqdomain_defs.h b/include/linux/irqdomain_def=
s.h
> index c29921fd8cd1..4c69151cb9d2 100644
> --- a/include/linux/irqdomain_defs.h
> +++ b/include/linux/irqdomain_defs.h
> @@ -26,6 +26,7 @@ enum irq_domain_bus_token {
>  	DOMAIN_BUS_DMAR,
>  	DOMAIN_BUS_AMDVI,
>  	DOMAIN_BUS_PCI_DEVICE_IMS,
> +	DOMAIN_BUS_DEVICE_IMS,

Only a personal taste, but since we keep calling it "device MSI",
which it really is, I find it slightly odd to name the token
"DEVICE_IMS".

=46rom what I understand, IMS is PCIe specific. Platform (and by
extension device) MSI extends far beyond PCIe. So here, DEVICE_MSI
would make a lot more sense and avoid confusion.

But hey, I don't have much skin in this game, and I can probably
mentally rotate the acronym...

	M.

--=20
Without deviation from the norm, progress is not possible.