Received-SPF: pass (google.com: domain of linux-kernel+bounces-66769-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 15 Feb 2024 13:17:01 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH v2 14/15] dt-bindings: auxdisplay: Add Maxim MAX6958/6959
Message-ID: <Zc3yrdAdQ7-SRs1C@smile.fi.intel.com>
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com>
 <20240212170423.2860895-15-andriy.shevchenko@linux.intel.com>
 <ZcpSDOk-IQVasHud@smile.fi.intel.com>
 <ZcpSaHW-RQ3dzywP@smile.fi.intel.com>
 <CAMuHMdV8mTa-qutFgqRKJyES7evEqEYhs=_eHtrKTTs5NkNa9A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMuHMdV8mTa-qutFgqRKJyES7evEqEYhs=_eHtrKTTs5NkNa9A@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Feb 15, 2024 at 11:57:53AM +0100, Geert Uytterhoeven wrote:
> On Mon, Feb 12, 2024 at 6:16 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Feb 12, 2024 at 07:14:53PM +0200, Andy Shevchenko wrote:

..

> > +description:
> > +  The Maxim MAX6958/6959 7-segment LED display controller provides
> > +  an I2C interface to up to four 7-segment LED digits. The MAX6959
> > +  in comparison to MAX6958 has the debounce and interrupt support.
> 
> IUIC, the primary differentiating factor is that the MAX6959 adds input
> and GPIO support?  Debounce and interrupt support are merely features
> of input support.

What should I do here? Rephrase?

> > +  Type of the chip can be autodetected via specific register read,
> > +  and hence the features may be enabled in the driver at run-time.
> 
> I don't think you need to read that register, as the users of the
> features (keypad mapping, interrupts property, ...) also need to be
> described in DTS (once supported).

So, the idea that if DT describes those we will check the chip ID and
instantiate what is asked?

> > +  Given hardware is simple and does not provide any additional pins,
> > +  such as reset or enable.
> 
> Does this matter? I.e. is it important to say this in the bindings?

From Krzysztof's review of v1 I understood that it is important to say so
people wouldn't wonder if HW has support of that which is not implemented
(yet) or simply has no such pins.

Personally I would lean towards leaving this in the description.

..

Can you propose the full description text how you see it?

-- 
With Best Regards,
Andy Shevchenko