Received-SPF: pass (google.com: domain of linux-kernel+bounces-66789-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 15 Feb 2024 13:28:01 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH v2 03/15] auxdisplay: linedisp: Use unique number for id
Message-ID: <Zc31QVEEzM5jQ0jy@smile.fi.intel.com>
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com>
 <20240212170423.2860895-4-andriy.shevchenko@linux.intel.com>
 <CAMuHMdUWw-_dECEXrTt--AX400YZOhP7b+tBOD0bHYQmS0z=1g@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMuHMdUWw-_dECEXrTt--AX400YZOhP7b+tBOD0bHYQmS0z=1g@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Feb 15, 2024 at 11:03:27AM +0100, Geert Uytterhoeven wrote:
> On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

..

> >  struct linedisp {
> >         struct device dev;
> > +       unsigned int id;
> 
> Note that there is a hole on 64-bit platforms.
> Hence I'd move id below, so the hole is at the end of the
> structure, and might be filled by future changes.

I had checked timer_list, but while it has holes, without debug it ends on
4-bytes boundary (without debug enabled), otherwise on 8-bytes.
Nevertheless, relying on the above seems fragile, so I follow your suggestion.
Thank you!

> >         struct timer_list timer;
> >         void (*update)(struct linedisp *linedisp);
> >         char *buf;

-- 
With Best Regards,
Andy Shevchenko