Received-SPF: pass (google.com: domain of linux-kernel+bounces-66899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com>
 <20240212170423.2860895-8-andriy.shevchenko@linux.intel.com>
 <CAMuHMdW=gTH12vLALAU_ioCKX9E2mJ3uR+8Q6GT0brc4yg83_A@mail.gmail.com> <Zc3147U697zQ6OwY@smile.fi.intel.com>
In-Reply-To: <Zc3147U697zQ6OwY@smile.fi.intel.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 15 Feb 2024 13:35:32 +0100
Message-ID: <CAMuHMdWqfUHGP4t17=4UVE0uOFqwpc7dF8D9MCU4EmdYSnfjDQ@mail.gmail.com>
Subject: Re: [PATCH v2 07/15] auxdisplay: linedisp: Group line display drivers together
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Robin van der Gracht <robin@protonic.nl>, Paul Burton <paulburton@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Thu, Feb 15, 2024 at 12:30=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Feb 15, 2024 at 11:05:00AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Feb 12, 2024 at 6:04=E2=80=AFPM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >  obj-$(CONFIG_CHARLCD)          +=3D charlcd.o
> > >  obj-$(CONFIG_HD44780_COMMON)   +=3D hd44780_common.o
> > > -obj-$(CONFIG_ARM_CHARLCD)      +=3D arm-charlcd.o
> > > +obj-$(CONFIG_HD44780)          +=3D hd44780.o
> > > +obj-$(CONFIG_LCD2S)            +=3D lcd2s.o
> > >  obj-$(CONFIG_KS0108)           +=3D ks0108.o
> > >  obj-$(CONFIG_CFAG12864B)       +=3D cfag12864b.o cfag12864bfb.o
> > > -obj-$(CONFIG_IMG_ASCII_LCD)    +=3D img-ascii-lcd.o
> > > -obj-$(CONFIG_HD44780)          +=3D hd44780.o
> > > -obj-$(CONFIG_HT16K33)          +=3D ht16k33.o
> > > -obj-$(CONFIG_PARPORT_PANEL)    +=3D panel.o
> > > -obj-$(CONFIG_LCD2S)            +=3D lcd2s.o
> > >  obj-$(CONFIG_LINEDISP)         +=3D line-display.o
> > > +obj-$(CONFIG_IMG_ASCII_LCD)    +=3D img-ascii-lcd.o
> > > +obj-$(CONFIG_HT16K33)          +=3D ht16k33.o
> > > +obj-$(CONFIG_ARM_CHARLCD)      +=3D arm-charlcd.o
> > > +obj-$(CONFIG_PARPORT_PANEL)    +=3D panel.o
> >
> > IMHO it hurts to not sort Makefile entries alphabetically.
>
> I can add blank lines to follow the same grouping as in Kconfig. Would it=
 work
> for you?

Unlike Kconfig, this is not user-visible.
Most Makefiles use sorted entries.  If they look unsorted, people will
just add new entries at the end.

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds