Received-SPF: pass (google.com: domain of linux-kernel+bounces-66856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 15 Feb 2024 13:03:03 +0100
From: "Christian A. Ehrhardt" <lk@c--e.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	Sing-Han Chen <singhanc@nvidia.com>,
	Haotien Hsu <haotienh@nvidia.com>,
	Utkarsh Patel <utkarsh.h.patel@intel.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Wayne Chang <waynec@nvidia.com>, WK Tsai <wtsai@nvidia.com>
Subject: Re: [PATCH CFT] usb: ucsi_ccg: Fix command completion handling
Message-ID: <Zc39d88ikvCO+XVK@cae.in-ulm.de>
References: <20240215101024.764444-1-lk@c--e.de>
 <2024021504-oven-worst-5c15@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2024021504-oven-worst-5c15@gregkh>


Hi Greg,

On Thu, Feb 15, 2024 at 12:07:20PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 15, 2024 at 11:10:24AM +0100, Christian A. Ehrhardt wrote:
> > In case of a spurious or otherwise delayed interrupt
> > it is possible that CCI still reports the previous completion.
> > For this reason the UCSI spec provides different completion
> > bits for normal commands and for UCSI_ACK_CC_CI.
> > 
> > Only complete a sync command if the correct completion bit
> > is set.
> > 
> > This should avoid the need to clear out CCI before starting
> > a command. Thus remove this code.
> > 
> > Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
> > Fixes: e32fd989ac1c ("usb: typec: ucsi: ccg: Move to the new API")
> 
> What does "CFT" in your subject line mean?

It's supposed to mean "Call For Testers". More info in the
"Additional Information" section of the original mail.

I think the change is necessary and good but I do not have the HW
to test it.

I did test a similar change for ucsi_acpi.c that got merged and this
is the ping for ucsi_ccg.c people that they probably need this, too.

   regards   Christian