Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp427052rdb; Thu, 15 Feb 2024 04:45:51 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXZN+Rgf7UxagYoocpqRQ/a0/i2SZjRLM6vjtwtiMWHEg+Wkf1LzLHhI0xxogBJQE71bu+COEZlogwbAZVCbfF1bu42N+hPtmNp0KrUSw== X-Google-Smtp-Source: AGHT+IH+heR5apaZpo9IqaxY3qFt0K5Ouj84x5gnb/WX0Oqu0Zj8/nVMMaXL9PYxT1kH2Y1I5HBn X-Received: by 2002:a05:6a00:2d05:b0:6e0:9f02:1b50 with SMTP id fa5-20020a056a002d0500b006e09f021b50mr2040695pfb.15.1708001150804; Thu, 15 Feb 2024 04:45:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708001150; cv=pass; d=google.com; s=arc-20160816; b=wpiv54a4XPeet/5GEeikzcgeYS+dp7zhO5OfvCYJJKdfJyHQVKnMnoXUGcjSXIYWTt lisrp9LeeHpTYAez2KoNlYGoKutrpxUNgaXm3aYw0LTB/TNVHeVgbksAfP8dzuLWwam3 gyVtB8lra9ujQLNvVZ0HUgd97t/elkdk1om0Gj+t4QL1YTBEzoJqxwYcKykCUX1nE1Zx PBVja0nZycmJgsEUgDaZmaIUjFkkozjfhWue7HraJ+UHANxgBQk6kEi1dybVBJFjdvTN PunDuqWz75i4NCwVLG+D6FgBmR+UT/K6LKSQ6OIxw0pTnQqKy7DE/hb4LuFkSQD1nt47 i5Zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date; bh=d66nu+jkZjaoPoaCztf+eeGPf4DX7SqXJ7NCvmAqmSo=; fh=TQqrQL2JldYjCoJPoQAdkTE550u1EvfRNYJWnRKCI4w=; b=k2qqNbfqaIdk5vu792POAP4xtO3JiEA5CVSqkgGKONw40WunARz6Nd8JOXIIjLwNIS BxrzvWQaui8tFdlH6gxfqrEXG6X+/6P3NuvEUzuVahSOUukY6HW/oRuPsa0yqATZYH6O 3oF8+X0qfhzmRReMMgMvo7PijwzR5fcv6tIKPTnluH3P8gj3BERxvnFYvFgX9IQiKFAT duCe/SqC2Z7w8NfyrPGADgoUJXN/thlT1dEommPAwgfHIgIKhjP83I0QbN2q99qVzlNh kcAWU30Xm3p9mrLzuZ6nkjrywBGi2yQqa8J/vJypGdJZIT3rq6Cu63IHICQFOSot3uhM fblw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-66881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id g3-20020a056a0023c300b006ddda6fb572si1103634pfc.381.2024.02.15.04.45.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 04:45:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-66881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4CC42B23E66 for ; Thu, 15 Feb 2024 12:22:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1FDE712C52D; Thu, 15 Feb 2024 12:22:36 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1264912BF06; Thu, 15 Feb 2024 12:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707999755; cv=none; b=r8ig2cYGTzHEaVCbUoeUMO8AX4bEBe2FQXD1vNF+huyDEQ4mUQrcAtcOVjV36nTuK6mW+hZrHTNzXZ33So5nD7XQxJfncT091LppnlI6YBlMcMyZB/nGiiPU/pH2nxsf1VtYpipkkLZfgD9tiqXEygyKE287YmItwebJqQszuPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707999755; c=relaxed/simple; bh=iCn0qgq3STK9IqIqXeF3/s1GYp7tkf4kVddq0DXuwjk=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IYj0zAJoTUvSepHsN5Vtu3dhD+DWig7pmPDaGg6Op6jUcAdQTiKdp+1cdUCqU0OE30tg4rF+rb0A0rokCeehGjmJSRA35UcXoDnAa4yemg36vpEqnqW/fMuR+JnJY14jLBepuJ4HJHbv5mnrYBHK9FmN2/szwXSz40ljHNjtDi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TbDcM4bQkz6J9nb; Thu, 15 Feb 2024 20:18:27 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id E940A1400D4; Thu, 15 Feb 2024 20:22:29 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 15 Feb 2024 12:22:29 +0000 Date: Thu, 15 Feb 2024 12:22:28 +0000 From: Jonathan Cameron To: Smita Koralahalli CC: , , , Ard Biesheuvel , "Alison Schofield" , Vishal Verma , Ira Weiny , Dan Williams , Yazen Ghannam Subject: Re: [PATCH v2 4/4] acpi/ghes, cxl/pci: Trace FW-First CXL Protocol Errors Message-ID: <20240215122228.00000405@Huawei.com> In-Reply-To: <20240109034755.100555-5-Smita.KoralahalliChannabasappa@amd.com> References: <20240109034755.100555-1-Smita.KoralahalliChannabasappa@amd.com> <20240109034755.100555-5-Smita.KoralahalliChannabasappa@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) On Tue, 9 Jan 2024 03:47:55 +0000 Smita Koralahalli wrote: > When PCIe AER is in FW-First, OS should process CXL Protocol errors from > CPER records. These CPER records obtained from GHES module, will rely on > a registered callback to be notified to the CXL subsystem in order to be > processed. > > Call the existing cxl_cper_callback to notify the CXL subsystem on a > Protocol error. > > The defined trace events cxl_aer_uncorrectable_error and > cxl_aer_correctable_error currently trace native CXL AER errors. Reuse > them to trace FW-First Protocol Errors. > > Signed-off-by: Smita Koralahalli Other than the bits of this that will change due to Ira's look good to me. Jonathan