Received-SPF: pass (google.com: domain of linux-kernel+bounces-66920-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240215112729.1778958-1-leitao@debian.org>
In-Reply-To: <20240215112729.1778958-1-leitao@debian.org>
From: Eric Dumazet <edumazet@google.com>
Date: Thu, 15 Feb 2024 13:47:47 +0100
Message-ID: <CANn89iJsdvjsbcYv_Re5HHvmY=P7Sq6ewV_sdQuWTAFtOPoKbw@mail.gmail.com>
Subject: Re: [PATCH net-next] net: sysfs: Do not create sysfs for non BQL device
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, 
	Johannes Berg <johannes.berg@intel.com>, Amritha Nambiar <amritha.nambiar@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 15, 2024 at 12:28=E2=80=AFPM Breno Leitao <leitao@debian.org> w=
rote:
>
> Creation of sysfs entries is expensive, mainly for workloads that
> constantly creates netdev and netns often.
>
> Do not create BQL sysfs entries for devices that don't need,
> basically those that do not have a real queue, i.e, devices that has
> NETIF_F_LLTX and IFF_NO_QUEUE, such as `lo` interface.
>
> This will remove the /sys/class/net/eth0/queues/tx-X/byte_queue_limits/
> directory for these devices.
>
> In the example below, eth0 has the `byte_queue_limits` directory but not
> `lo`.
>
>         # ls /sys/class/net/lo/queues/tx-0/
>         traffic_class  tx_maxrate  tx_timeout  xps_cpus  xps_rxqs
>
>         # ls /sys/class/net/eth0/queues/tx-0/byte_queue_limits/
>         hold_time  inflight  limit  limit_max  limit_min
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  net/core/net-sysfs.c | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index a09d507c5b03..c79bc11a0347 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -1417,6 +1417,15 @@ static ssize_t bql_show_inflight(struct netdev_que=
ue *queue,
>         return sysfs_emit(buf, "%u\n", dql->num_queued - dql->num_complet=
ed);
>  }
>
> +static bool netdev_uses_bql(struct net_device *dev)

  const struct net_device *dev

> +{
> +       if (dev->features & NETIF_F_LLTX ||
> +           dev->priv_flags & IFF_NO_QUEUE)
> +               return false;
> +
> +       return true;
> +}
> +
>

Thanks.