Received-SPF: pass (google.com: domain of linux-kernel+bounces-66929-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 15 Feb 2024 12:52:43 +0000
From: Conor Dooley <conor@kernel.org>
To: Alisa-Dariana Roman <alisadariana@gmail.com>
Cc: alexandru.tachici@analog.com, alisa.roman@analog.com,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	dlechner@baylibre.com, jic23@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
	lars@metafoo.de, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, michael.hennerich@analog.com,
	robh+dt@kernel.org
Subject: Re: [PATCH v3 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support
Message-ID: <20240215-demystify-abacus-c8fbfe1e9f2b@spud>
References: <20240208172459.280189-1-alisa.roman@analog.com>
 <20240208172459.280189-5-alisa.roman@analog.com>
 <20240208-occupancy-shudder-514d8569e261@spud>
 <73d01418-65e2-4327-b6b3-c4de501c2920@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="eVxVWuwy3y01LPUE"
Content-Disposition: inline
In-Reply-To: <73d01418-65e2-4327-b6b3-c4de501c2920@gmail.com>


--eVxVWuwy3y01LPUE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 15, 2024 at 02:13:38PM +0200, Alisa-Dariana Roman wrote:
> On 08.02.2024 20:03, Conor Dooley wrote:
> > Hey,
> >=20
> > On Thu, Feb 08, 2024 at 07:24:58PM +0200, Alisa-Dariana Roman wrote:
> >=20
> > > +patternProperties:
> > > +  "^channel@([0-7a-f])$":
> > > +    type: object
> > > +    $ref: adc.yaml
> > > +    unevaluatedProperties: false
> > > +
> > > +    properties:
> > > +      reg:
> > > +        description: The channel index.
> > > +        minimum: 0
> > > +        maximum: 7
> >=20
> > There are only 8 possible channels, at indices 0 to 7, so why is the
> > pattern property more permissive than that? Shouldn't "^channel@[0-7]$"
> > suffice?
> >=20
> > > +
> > > +       diff-channels:
> >=20
> > > +        description: |
> > > +          The differential channel pair for Ad7194 configurable chan=
nels. The
> > > +          first channel is the positive input, the second channel is=
 the
> > > +          negative input.
> >=20
> > This duplicates the description in adc.yaml
> >=20
> > > +        items:
> > > +          minimum: 1
> > > +          maximum: 16
> >=20
> > Hmm, this makes me wonder: why doesn't this match the number of channels
> > available and why is 0 not a valid channel for differential measurement=
s?
> >=20
> > Thanks,
> > Conor.
>=20
> Hello and thank you for the feedback!
>=20
> I will change the pattern property and the description.
>=20
> Regarding the channels, I followed the existing style of the driver for t=
he
> AD7194 channels: one iio channel for each pseudo-differential input
> channel(AINx - AINCOM), summing up to 16 channels; and one iio channel for
> each differential channel (AINx - AINy), summing up to 8 channels.

I don't know what question this is answering. Everything here is about
channels so it is hard for me to relate it back.
Please reply inline & not at the end of the message to everything :)
Was it meant to answer the following?

> > > +    properties:
> > > +      reg:
> > > +        description: The channel index.
> > > +        minimum: 0
> > > +        maximum: 7
> >=20
> > There are only 8 possible channels, at indices 0 to 7, so why is the
> > pattern property more permissive than that? Shouldn't "^channel@[0-7]$"
> > suffice?

If it was a response to this, the reg property only allows 8 channels so
the regex should only allow 8 too. The number after @ must match the number
in reg. If using each of the 16 "pseudo-differential" inputs in
isolation is thing you want to be able to do, your reg property does not
allow it.

> For the
> diff-channels, I thought the possible values should be 1->16 corresponding
> to AIN1->AIN16 (I will add this to the description as suggested by David).

With a description, this should be fine.

--eVxVWuwy3y01LPUE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc4JGwAKCRB4tDGHoIJi
0uGpAQDJPZr9YPefeO7EEWAtw6D6/mFbOUDNFDHU5QLxuDJz2QD+KySncCvuevdB
iY+/Lv/jb2kLjyD5AhdAh3y9bA/icQ0=
=MYMP
-----END PGP SIGNATURE-----

--eVxVWuwy3y01LPUE--