Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp430897rdb; Thu, 15 Feb 2024 04:54:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCURfRo2iY6jYTTQKtEeTRTheb7yX/p4OBQuTMkpQlI7mNbTFxnD0928qRu8a8TYn9K0DeQCUe8yhOtfV8RxvGyL4XLiFNCM6PzUxxrztQ== X-Google-Smtp-Source: AGHT+IGJ1zEVoWM7qFQEV0Wkc63V46y1lSVx00o+ILnG9SW6+o1cQunNS54FC/g3XkYdju0T5FyC X-Received: by 2002:a05:6358:470d:b0:178:75cb:18dc with SMTP id j13-20020a056358470d00b0017875cb18dcmr1939451rwn.10.1708001652166; Thu, 15 Feb 2024 04:54:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708001652; cv=pass; d=google.com; s=arc-20160816; b=F9tKs0WYREc0PCQtmoSKU3ooda7hhekKLPTQzFqONWDox18ZkrRIt63Y0tiP7CZGQH Wk1N/zLgfvM8zDTxJH2zarAcO+9ByRNTeUUmebBM3BAs6HnpD+4NziDPrMBpeSJlIpng hubDQFPlAOSO7rJHFIsE9l8TZFz/W7JJm9LD0triAmQ1N71IhFjeJj7pKOyjhDZVYBFn U9fG15unxUbNESXO6A2mdqHF4u8NcfURNfLb8PGgdlQlCOudZMH3PDH6Ay10gD+1Du+k 7uBduOCkvu1UC6ka78gtAWKs9nAamd4gvZdRzq1icl6waJ1QF4f6/2JtBrLwFuRYNE23 NeuA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=86HtOqiJIU3jHcxxPoCnzf11e81veBIESxbbXAw66bo=; fh=PEF1BrnwfrnRvvEaMlC9GPRGeo6yjCJ4vCuOQANcS98=; b=CzkhK2oz88IZXUMrswDEFQtpUs79VRBkmAg1dZW7Sks1sooBnwVfkHDLd/XFBk+5rS Av7/EJvrdyJ/n2uCFd/bqIbHEzSRpjiTl9MRVwR0ywJq7ensZEatJ2VjwWYlKsjp5qWW t0Fkb+74uZpT5wPw2CrB8dFTtcao2GSkO9JMjohVtisdHK9UKvKGEsdurgy9Eu9jEYx+ b4X8OZIDdAntGDYyrpEcaibmj/XAdk3FzeXiKIIHeZQunO9IIx288FkDthPvDj+ji1Gj toV76Ni1u53a7xX/+2nwIfR0ZPOqdcDuCBZssBqulRJR7UUB8qBGi6NLMox68/afhW4/ TL/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XvJjiTHY; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-66932-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66932-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id f50-20020a056a000b3200b006e10f315ac6si1073607pfu.226.2024.02.15.04.54.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 04:54:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66932-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XvJjiTHY; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-66932-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66932-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C1E23282EF1 for ; Thu, 15 Feb 2024 12:54:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CE7BE12F388; Thu, 15 Feb 2024 12:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XvJjiTHY" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41DE313FF5; Thu, 15 Feb 2024 12:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708001632; cv=none; b=ThG54LdfTo9TGRJIPQFBTrsoAK2+2xNj+JRG/hoka+92teQctMfxj02IKFa67yfOwEaNyGVXAV9hQ5a2reiMSJM6wT+/LdpBdt4xYXXX1M3dbyrclqCKVXYLeNfLroEBzHdLw/h2BSFauFDMzWuTS4pDeubdUIffR8JDFrtclUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708001632; c=relaxed/simple; bh=o1XNb9vQplsipvw7ar7izvrCSvgKiiHgtlUB4fVOVYM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vFd/ctkqY8NqjJcQh4DOZB6liEQZHL9uyezjTh4juk2j8I7LOVFjt8f5P2N/fPAYexNyhlhOwW3iMkTM+zgZicRUNTHjUqrfm+jwhqo7pj5W9+KxXBH0byBxPKPfR6/igBynHau9DlklQ9YKB7hV74gVTeyGZFRZhImdRtmeqos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XvJjiTHY; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708001630; x=1739537630; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=o1XNb9vQplsipvw7ar7izvrCSvgKiiHgtlUB4fVOVYM=; b=XvJjiTHYHVjIqmzHt4IbHXy3NXAuiF+izIKgzndBW8bu4SuG/Xks7mmE Ws90kTWy1p1YvBQoQd6/tJea9FIMe9Lb0KtiQkaQRYNUihzBAJvhtMY2T +RuN2mlFaNMRGMV4iBs6+QNVONc3YZAFXauB8IaxkvE5qrA8ZNEiIvkFZ UfCWuFJxr0/Lr12FpazaQ8vFebMK4yXzdp7rUAPgSHGS/PXuxC+N4TCha q3lQTBSDr1MExQs4FlGBovcaW7+5Zhjb4YoclN4caGn/mfAyihWuB3GZK Oxjbq7OFsTj8EE//UtgV+MJTInr11fqlJ133VWJbKfiQHn6tXNEJQvnbX A==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="1960980" X-IronPort-AV: E=Sophos;i="6.06,161,1705392000"; d="scan'208";a="1960980" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 04:53:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,161,1705392000"; d="scan'208";a="8226597" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 04:53:48 -0800 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 2416511F8E7; Thu, 15 Feb 2024 14:53:45 +0200 (EET) Date: Thu, 15 Feb 2024 12:53:45 +0000 From: Sakari Ailus To: Umang Jain Cc: linux-media@vger.kernel.org, Kieran Bingham , Mauro Carvalho Chehab , open list Subject: Re: [PATCH v2 2/5] media: imx335: Use v4l2_link_freq_to_bitmap helper Message-ID: References: <20240131055208.170934-1-umang.jain@ideasonboard.com> <20240131055208.170934-3-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 15, 2024 at 12:51:19PM +0000, Sakari Ailus wrote: > > /* CSI2 HW configuration */ > > -#define IMX335_LINK_FREQ 594000000 > > +#define IMX335_LINK_FREQ 594000000LL > > If you change this, please make it ULL---it's unsigned. Ok, the control will be s64 so please ignore this. -- Sakari Ailus