Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp434109rdb; Thu, 15 Feb 2024 05:00:46 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU6gNgUPTAns8jiXtnfa2GH2ZiSJ92CzOuUSKjcI/GJD5cBN6cQr6Pzr8FtJFmnD+ekyePlgoputYElWzg9VsxuqZkv9gdKikKDTUBCXA== X-Google-Smtp-Source: AGHT+IGCVh0BphW3JwF+E/WbFLmoTivbWo0Hum5tqGa9L/6dexGwjundvTG5++bulvMk2BX9EHlC X-Received: by 2002:a17:907:3354:b0:a3d:6715:7e3d with SMTP id yr20-20020a170907335400b00a3d67157e3dmr1252768ejb.27.1708002045971; Thu, 15 Feb 2024 05:00:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708002045; cv=pass; d=google.com; s=arc-20160816; b=nwfF/w9aE1vAnsxGtSlnj9ifeTdR4DauC2OzBvElv71YSJ7iMXfj/YIdsQ35MsT9a8 r19qbmqc7YQGPtMjljL9PuuCPfqMy/6LgBKdq/ymZiSsPATQ68szKHtIc7CWh+oodLwz IoFYiPIhiai92KT0zdYZ4PrxDoqCTHGtLva8DD+qhMAiVVZitVZ+ukSZeUyd/rRtAkq+ jqwBnoA4Rk+HtKLs04BAJccU5CVRPZl3dz0Z1zXzZ05DSMFeZNY1Bjq3AsgDQdRf652n VUAMpdLTmbScSANElg5+5ERwCaC2sTz1mE07psXTY53O7pEJBhA/8rdjDHQmsXlqTram R3KA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:to:from; bh=2BnK+QBe5G/+ZLnGDbmlaXTvn071UUEJ0bxLczr3P90=; fh=vwlqhkhkQbSeMC8WeHH3wdmB1HKEENDBubhxAIRFX3s=; b=O5uruo8Wyasvzqy8XGF57H7p4G9HfP/QzHEPkUNoempXP+9pe7hx22T96ruJhh68I/ CUhoZ37m5pK0CvdH5F/V0OQFrpfgtZeoj4S4QDfI9fp+jqwdf5dGyO/LMBScGEf8FPLB 5uERNU+myhfKZYqbmy8u2zQMUC6CW1pO5fC0XU5Ko+PL4PEbqoKguuPhsiCDALKcUWWQ hqqLmtLzYoTzgrx/RYTB2Jp10/v3AH55wlfdUzjz0i3aXD7lSl/nbyL3kl2nZH6QOt0f g3/YZXQxdFixVC5pi2Hg0PYgrw4cRxIudVzSwR0Lc13zVpWxjZDaMn6lY8L7YUYT2h9v s+0g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-66941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66941-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id c4-20020a170906694400b00a3d084ffe41si609467ejs.154.2024.02.15.05.00.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 05:00:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-66941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66941-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B5DE01F27078 for ; Thu, 15 Feb 2024 13:00:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13DE312FF97; Thu, 15 Feb 2024 12:59:55 +0000 (UTC) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E16212FB13; Thu, 15 Feb 2024 12:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708001994; cv=none; b=aBKsrgxSUL1usjLqcg2QAw0bp7HvhKkKlTnYvz5qTm6NrJlcT/hEgUi12134+jnaQip6lL5FDVnydUL7LbV1nYGK5qhAX7/GQZxJ0JUicMCtH7mUogp4xmFLsLH5+mbTsiL9dxQvEEPgPOg4g4f7ZNbDXLQel+3N6q17ywxx/Xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708001994; c=relaxed/simple; bh=V7Z1PZjYZh7HQea+HEPXEsxV86UAB10ZcV9jP139qCA=; h=From:To:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=p33fXZP+B+0kRTk0z4r2OiqfKhDGkyQSsro5QWidwCIQ05sh/4+AYHuLcwrtqVXzdYtODF/gG2n1ju2q61NM0IOGphftxZ1AVrEAZrM/YrwG3dO5Oh1895i6wdWrK2g5AK4FdUKPQ/fRlb/VrNms4Q2i5PppHzaXJNJM94M78MY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TbFX64ZqNz4x0m; Thu, 15 Feb 2024 23:59:50 +1100 (AEDT) From: Michael Ellerman To: linux-kselftest@vger.kernel.org, shuah@kernel.org, skhan@linuxfoundation.org, npiggin@gmail.com, christophe.leroy@csgroup.eu, nathanl@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, R Nageswara Sastry In-Reply-To: <20240131130859.14968-1-rnsastry@linux.ibm.com> References: <20240131130859.14968-1-rnsastry@linux.ibm.com> Subject: Re: [PATCH] papr_vpd.c: calling devfd before get_system_loc_code Message-Id: <170800185781.599237.11241417718468325077.b4-ty@ellerman.id.au> Date: Thu, 15 Feb 2024 23:57:37 +1100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Wed, 31 Jan 2024 18:38:59 +0530, R Nageswara Sastry wrote: > Calling get_system_loc_code before checking devfd and errno - fails the test > when the device is not available, expected a SKIP. > Change the order of 'SKIP_IF_MSG' correctly SKIP when the /dev/papr-vpd device > is not available. > > with out patch: Test FAILED on line 271 > with patch: [SKIP] Test skipped on line 266: /dev/papr-vpd not present > > [...] Applied to powerpc/fixes. [1/1] papr_vpd.c: calling devfd before get_system_loc_code https://git.kernel.org/powerpc/c/f09696279b5dd1770a3de2e062f1c5d1449213ff cheers