Received-SPF: pass (google.com: domain of linux-kernel+bounces-66971-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b2b1b20f-31f7-4c15-9d05-4421d890c6fe@gmail.com>
Date: Thu, 15 Feb 2024 13:22:32 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH][next] spi: dw: remove redundant assignment to variable
 len
From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Serge Semin <fancer.lancer@gmail.com>, Mark Brown <broonie@kernel.org>,
 linux-spi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240215131603.2062332-1-colin.i.king@gmail.com>
Content-Language: en-US
In-Reply-To: <20240215131603.2062332-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/02/2024 13:16, Colin Ian King wrote:
> The variable id len being initialized with a value that is never read,

should be "len is being.."

> it is being re-assigned later on in a for-loop. The initialization is
> redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/spi/spi-dw-dma.c:580:17: warning: Although the value stored
> to 'len' is used in the enclosing expression, the value is never
> actually read from 'len' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   drivers/spi/spi-dw-dma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-dw-dma.c b/drivers/spi/spi-dw-dma.c
> index 0ecbb6c36e23..f4c209e5f52b 100644
> --- a/drivers/spi/spi-dw-dma.c
> +++ b/drivers/spi/spi-dw-dma.c
> @@ -577,7 +577,7 @@ static int dw_spi_dma_transfer_one(struct dw_spi *dws,
>   	sg_init_table(&tx_tmp, 1);
>   	sg_init_table(&rx_tmp, 1);
>   
> -	for (base = 0, len = 0; base < xfer->len; base += len) {
> +	for (base = 0; base < xfer->len; base += len) {
>   		/* Fetch next Tx DMA data chunk */
>   		if (!tx_len) {
>   			tx_sg = !tx_sg ? &xfer->tx_sg.sgl[0] : sg_next(tx_sg);