Received-SPF: pass (google.com: domain of linux-kernel+bounces-66995-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 15 Feb 2024 14:37:10 +0100
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] page_pool: disable direct recycling based on
 pool->cpuid on destroy
Message-ID: <Zc4Tht2TAkFOhq9Y@lore-desk>
References: <20240215113905.96817-1-aleksander.lobakin@intel.com>
 <87v86qc4qd.fsf@toke.dk>
 <8aa809c0-585f-4750-98d4-e19165c6ff73@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="JwdDwmzJQxeHUrty"
Content-Disposition: inline
In-Reply-To: <8aa809c0-585f-4750-98d4-e19165c6ff73@intel.com>


--JwdDwmzJQxeHUrty
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> From: Toke H=F8iland-J=F8rgensen <toke@redhat.com>
> Date: Thu, 15 Feb 2024 13:05:30 +0100
>=20
> > Alexander Lobakin <aleksander.lobakin@intel.com> writes:
> >=20
> >> Now that direct recycling is performed basing on pool->cpuid when set,
> >> memory leaks are possible:
> >>
> >> 1. A pool is destroyed.
> >> 2. Alloc cache is emptied (it's done only once).
> >> 3. pool->cpuid is still set.
> >> 4. napi_pp_put_page() does direct recycling basing on pool->cpuid.
> >> 5. Now alloc cache is not empty, but it won't ever be freed.
> >=20
> > Did you actually manage to trigger this? pool->cpuid is only set for the
> > system page pool instance which is never destroyed; so this seems a very
> > theoretical concern?
>=20
> To both Lorenzo and Toke:
>=20
> Yes, system page pools are never destroyed, but we might latter use
> cpuid in non-persistent PPs. Then there will be memory leaks.
> I was able to trigger this by creating bpf/test_run page_pools with the
> cpuid set to test direct recycling of live frames.

what about avoiding the page to be destroyed int this case? I do not like t=
he
idea of overwriting the cpuid field for it.

Regards,
Lorenzo

>=20
> >=20
> > I guess we could still do this in case we find other uses for setting
> > the cpuid; I don't think the addition of the READ_ONCE() will have any
> > measurable overhead on the common arches?
>=20
> READ_ONCE() is cheap, but I thought it's worth mentioning in the
> commitmsg anyway :)
>=20
> >=20
> > -Toke
> >=20
>=20
> Thanks,
> Olek

--JwdDwmzJQxeHUrty
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZc4ThgAKCRA6cBh0uS2t
rMKzAQCWGs8izokKKobJ1o5bjr0dNcsLSO9pBKgU1pZJzetrwQEA6Vm0zCDsUzog
/Eh2aXqvy9gf0llzRVEpBYYSeLz0zgA=
=r6Tb
-----END PGP SIGNATURE-----

--JwdDwmzJQxeHUrty--