Received-SPF: pass (google.com: domain of linux-kernel+bounces-67005-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 15 Feb 2024 07:44:29 -0600
From: Rob Herring <robh@kernel.org>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	manisha.agrawal@ti.com, hnagalla@ti.com, praneeth@ti.com,
	lgirdwood@gmail.com, linux-sound@vger.kernel.org,
	conor+dt@kernel.org, aviel@ti.com, perex@perex.cz, pdjuandi@ti.com,
	linux-kernel@vger.kernel.org, tiwai@suse.de,
	devicetree@vger.kernel.org, tiwai@suse.com, mohit.chawla@ti.com,
	13916275206@139.com, s-hari@ti.com, soyer@irl.hu,
	broonie@kernel.org, jkhuang3@ti.com
Subject: Re: [RESEND PATCH v4 4/4] ASoc: dt-bindings: PCM6240: Add initial DT
 binding
Message-ID: <170800466884.4134047.16156792945843659627.robh@kernel.org>
References: <20240208114049.1429-1-shenghao-ding@ti.com>
 <20240208114049.1429-4-shenghao-ding@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240208114049.1429-4-shenghao-ding@ti.com>


On Thu, 08 Feb 2024 19:40:48 +0800, Shenghao Ding wrote:
> PCM6240 family chips are popular among audio customers, in spite of only a
> portion of the functionality of codec, such as ADC or DAC, and so on, for
> different Specifications, range from Personal Electric to Automotive
> Electric, even some professional fields.yet their audio performance is far
> superior to the codec's, and cost is lower than codec, and much easier to
> program than codec.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
> 
> ---
> Change in v4:
>  - Rewrite the subject to match something similar to other commits.
>  - And none of them are compatible with something.
>  - minItems, then maxItems.
>  - Drop reset-gpios description
>  - Remove the repeated reg descriptions and reg constraints.
>  - Drop redundant spaces.
>  - Add missing line breaks between blocks and additionalProperties.
>  - Correct compatibility issue on adc6120 and pcm6240.
>  - All these chips have only a portion of the functionality of codec,
>    such as ADC or DAC, and so on, but their audio performance is far
>    superior to the codec's, and cost is lower than codec, and much easier
>    to program than codec. Simply one or two register settings can enable
>    them to work. Init for these chips are hardware reset or software reset.
>    As to some audio filter params for internal filters, it is up to the
>    special user cases, which can be saved into the bin file. The default
>    value also can work well.
>  - Add blank line before reg.
>  - remove unneeded items and if branches.
>  - Add missing compatible devices, such as adc6120, etc.
>  - Add necessary people into the list for DTS review
>  - correct misaligned.
>  - Remove dix4192
>  - simplify the compatibility
> ---
>  .../devicetree/bindings/sound/ti,pcm6240.yaml | 172 ++++++++++++++++++
>  1 file changed, 172 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ti,pcm6240.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>