Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp462102rdb; Thu, 15 Feb 2024 05:46:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU1P1trkjUMzR753DpfQYaxYBssk2GsIh0Ee4DRSsx6OCldDPxpHyGtDVDHacniImbFvjj8kA64V8fen87wRnDJ2+iMwehjzuPIuQcOag== X-Google-Smtp-Source: AGHT+IGpzn/Cri3RdhcnEBc5jhypLymlPEeTA+8dHD5xDByTgOggOonkBYNwqBgIMLpD0O4ct8dT X-Received: by 2002:a17:906:e252:b0:a3d:57f:5b91 with SMTP id gq18-20020a170906e25200b00a3d057f5b91mr1354014ejb.74.1708004794344; Thu, 15 Feb 2024 05:46:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708004794; cv=pass; d=google.com; s=arc-20160816; b=uZHkFrAVzJbMAhFC7sO2z3O8nVDX9pu/unuFGQcD2cudhhK8GDNwRQAy5l4VbJ1SnA b+Ho3F3rVrvXoKknXmtWdR+5loYB1xpbf6hEH9lw0/OI9VfwGWo81tC8fzbPiD1VfkOv NvH+/FNgIEjQpFaS831/omUD0/TRmBNmgH7hi7k4lXSA8f+I4FOovR1zeaLZYPqoJfy8 diM9xPYNB03J0dRttw4OYgLfi6KY3xLnrVnDVG850DBQEhTw9AACakF/1qjr7GwiwQAz WucKPuqfYQsZHMcWcAvyhixFB/JI7ciKx+p3abob0mnnLsilZXPjRTqprJ/kTektoFX0 pSPQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=Ro+h8nL4J7jvDqXh3S3aMqyuM2ofTpxeRRs01DekrbA=; fh=SSdZjAT7s4QrSD7uyBwJfa0cXGAuSA4UgTC7Bg9vYdw=; b=e41c7JC74xb78MSvsRxyZDQi4di3gq5ewchoWnx5YtcBfJj+PoBiC5AOB0bNA3qCKy JzGdt6aXQTmsheY32eAzgh8hFNJF6i6nnk98DWJFLEXVg0KNpCrloWLJMg/iR8CXX3ud 0NSCI6279LDlrKgrUFt9pdGAJ5x8DwOHnhgjiq0yloy2FnXW4h5HNCRthjVeNRL6MQES W+qruIj2+tqxk8Y9xDXYmia6qAqJXidDYxr4ISb12OA4j6RUaJoKYHUUkFL4CcNE+4Qp w75omnOeTkhMjiJcgUPQMbfJEp5NXlLpWianlOAfEOaG92h+P8j6Iuha78IJsG7yDdyO X/NA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mskv9eTc; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-67009-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67009-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id l7-20020a1709065a8700b00a3d5b894df1si661249ejq.513.2024.02.15.05.46.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 05:46:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-67009-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mskv9eTc; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-67009-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67009-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 893741F20CAA for ; Thu, 15 Feb 2024 13:46:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29EAE13173A; Thu, 15 Feb 2024 13:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mskv9eTc" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486A912FF7C; Thu, 15 Feb 2024 13:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708004769; cv=none; b=sT7RY7+6UaFkpPBkJ4SZE3glnuIZck2/zqIheWWvM3e2rIdFXBS2/nijgqNiwRaX6yQ+wZpTCy/FQ+h2wrSX59g5/upasNwZg+J8rKnsYENtDolyQJeiuCqLHPTxms/xeUuhoq/wf9uG/6b7L2JZOJVA0UhaHXqnaxmu/py3/QI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708004769; c=relaxed/simple; bh=tc6ZrK/KriUkgV0fybz4vanC+BFX+YBBDvRESkhsuEE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=tuFu05c7C1JNg1iz3gPTmIYoiLE/cxfm3m3Dod1BtQ9ksWMlkwqml0qUjT69nPrDUU6NdL9zKY5RxnTMY0xQiRdwytu/lbt4vhQdkgnjPp2D3ksJGwhhABrsdtWgd/joxoDsPz4C/9HxlO8VZDdigGwCKvimvlBdqZ6eJa9Tiuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mskv9eTc; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8C7BC43399; Thu, 15 Feb 2024 13:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708004768; bh=tc6ZrK/KriUkgV0fybz4vanC+BFX+YBBDvRESkhsuEE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Mskv9eTczjjVvBSTcV32dwmQDpz1jSjDKs+RSc2Tepb3xeH9YSYxjgB7wlbjuXFb2 PX+5USWY2GK977aktlf1LIbfaT0rl7XJSrqB1JNeL2VgHBUwoeY/BL8Pp5auecZ/iC cHoKpWKTAIxFSm+9fvmdv2KiihTkjdjE1Kw2ZU0UQtu2JHE556EN9WeaPz/mcuNWwK P341aCtLytsNTVoNGJVEfQR3KA79j9WZ4xSZTx7fYiEHjMBeb8bB1mzyUjnHBjouzr /xFzvhghcypoKp9ZrYsUXLVBaCOvBGgn+3DF2lYdo4xdgaRxGE0pmPtn7jOdViOuOM k59t69Dd7I+Kw== Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2d0fd07ba8bso10001871fa.1; Thu, 15 Feb 2024 05:46:08 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV9BDzdJ7n5Zc7jEGTVWXQfsxIPOPyNBl8TiumsiHoAJcfcFmEnV9yld3xV8+JmiLkuUEZAsuXPWL/fIrbLzKssW2vBlSJgLV0kVIEGJ13F0D3/6habD6wGD8h4DzDtlYRpgXdQ0VaKEgzQ X-Gm-Message-State: AOJu0YxGV99tLGgk5JCU5fmg3Qn5BHgzQd/yPAj2S3GMc4lgCaKOaqOP o7T1oPIpkT9ViNohoBDPcJwRwk5Etr9mTcb9pDkZkCdrbheo4xuCMjOU036bxWVUUTMDoFKI0J9 QKGFrcXXh7jsRjDCEwm4m3JaZVO4= X-Received: by 2002:a2e:9793:0:b0:2d0:ce22:516d with SMTP id y19-20020a2e9793000000b002d0ce22516dmr1499072lji.3.1708004767409; Thu, 15 Feb 2024 05:46:07 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240215083225.3976252-1-arnd@kernel.org> In-Reply-To: <20240215083225.3976252-1-arnd@kernel.org> From: Masahiro Yamada Date: Thu, 15 Feb 2024 22:45:31 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [v2] kallsyms: ignore ARMv4 thunks along with others To: Arnd Bergmann Cc: Arnd Bergmann , Nathan Chancellor , Nicolas Schier , =?UTF-8?Q?Pierre=2DCl=C3=A9ment_Tosi?= , Nick Desaulniers , Ard Biesheuvel , "Russell King (Oracle)" , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 5:32=E2=80=AFPM Arnd Bergmann wro= te: > > From: Arnd Bergmann > > lld is now able to build ARMv4 and ARMv4T kernels, which means it can > generate thunks for those (__ARMv4PILongThunk_*, __ARMv4PILongBXThunk_*) > that can interfere with kallsyms table generation since they do not get > ignore like the corresponding ARMv5+ ones are: > > Inconsistent kallsyms data > Try "make KALLSYMS_EXTRA_PASS=3D1" as a workaround > > Replace the hardcoded list of thunk symbols with a more general regex tha= t > covers this one along with future symbols that follow the same pattern. > > Fixes: 5eb6e280432d ("ARM: 9289/1: Allow pre-ARMv5 builds with ld.lld 16.= 0.0 and newer") > Fixes: efe6e3068067 ("kallsyms: fix nonconverging kallsyms table with lld= ") > Suggested-by: Masahiro Yamada > Signed-off-by: Arnd Bergmann > --- > v2: use a regular expression instead of listing each one. Applied to linux-kbuild/fixes. Thanks. > --- > scripts/mksysmap | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/scripts/mksysmap b/scripts/mksysmap > index 9ba1c9da0a40..57ff5656d566 100755 > --- a/scripts/mksysmap > +++ b/scripts/mksysmap > @@ -48,17 +48,8 @@ ${NM} -n ${1} | sed >${2} -e " > / __kvm_nvhe_\\$/d > / __kvm_nvhe_\.L/d > > -# arm64 lld > -/ __AArch64ADRPThunk_/d > - > -# arm lld > -/ __ARMV5PILongThunk_/d > -/ __ARMV7PILongThunk_/d > -/ __ThumbV7PILongThunk_/d > - > -# mips lld > -/ __LA25Thunk_/d > -/ __microLA25Thunk_/d > +# lld arm/aarch64/mips thunks > +/ __[[:alnum:]]*Thunk_/d > > # CFI type identifiers > / __kcfi_typeid_/d > -- > 2.39.2 > > --=20 Best Regards Masahiro Yamada