Date: Wed, 26 Dec 2007 13:02:58 +0000
From: Andy Whitcroft <apw@shadowen.org>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: checkpatch false ERROR: trailing statements should be on next line
Message-ID: <20071226130258.GC8346@shadowen.org>
References: <200712252150.lBPLo4wG031988@agora.fsl.cs.sunysb.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200712252150.lBPLo4wG031988@agora.fsl.cs.sunysb.edu>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 857
Lines: 24

On Tue, Dec 25, 2007 at 04:50:04PM -0500, Erez Zadok wrote:
> Using v2.6.24-rc6-125-g5356f66, code such as this:
> 
> 	if (is_file)	/* dirs can be unlinked but chdir'ed to */
> 		err = -ESTALE;
> 
> produces this false checkpatch error:
> 
> 	foo.c:947: ERROR: trailing statements should be on next line
> 
> I think comments such as the above should be allowed (plus a comment isn't a
> statement).  It's often very useful to put them right on the affected line.

Agreed.  checkpatch 0.13 already ignores these as statements.  A
positive side effect of other changes in this area.

Thanks for the report.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/