Received-SPF: pass (google.com: domain of linux-kernel+bounces-67043-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 15 Feb 2024 15:01:55 +0100
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] page_pool: disable direct recycling based on
 pool->cpuid on destroy
Message-ID: <Zc4ZU0BsXkVgFZ3p@lore-desk>
References: <20240215113905.96817-1-aleksander.lobakin@intel.com>
 <87v86qc4qd.fsf@toke.dk>
 <8aa809c0-585f-4750-98d4-e19165c6ff73@intel.com>
 <Zc4Tht2TAkFOhq9Y@lore-desk>
 <15766d46-162c-4c99-84a0-7a4bc60c3289@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MN2cs1CvNJYC3dkc"
Content-Disposition: inline
In-Reply-To: <15766d46-162c-4c99-84a0-7a4bc60c3289@intel.com>


--MN2cs1CvNJYC3dkc
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> From: Lorenzo Bianconi <lorenzo@kernel.org>
> Date: Thu, 15 Feb 2024 14:37:10 +0100
>=20
> >> From: Toke H=F8iland-J=F8rgensen <toke@redhat.com>
> >> Date: Thu, 15 Feb 2024 13:05:30 +0100
> >>
> >>> Alexander Lobakin <aleksander.lobakin@intel.com> writes:
> >>>
> >>>> Now that direct recycling is performed basing on pool->cpuid when se=
t,
> >>>> memory leaks are possible:
> >>>>
> >>>> 1. A pool is destroyed.
> >>>> 2. Alloc cache is emptied (it's done only once).
> >>>> 3. pool->cpuid is still set.
> >>>> 4. napi_pp_put_page() does direct recycling basing on pool->cpuid.
> >>>> 5. Now alloc cache is not empty, but it won't ever be freed.
> >>>
> >>> Did you actually manage to trigger this? pool->cpuid is only set for =
the
> >>> system page pool instance which is never destroyed; so this seems a v=
ery
> >>> theoretical concern?
> >>
> >> To both Lorenzo and Toke:
> >>
> >> Yes, system page pools are never destroyed, but we might latter use
> >> cpuid in non-persistent PPs. Then there will be memory leaks.
> >> I was able to trigger this by creating bpf/test_run page_pools with the
> >> cpuid set to test direct recycling of live frames.
> >=20
> > what about avoiding the page to be destroyed int this case? I do not li=
ke the
>=20
> I think I didn't get what you wanted to say here :s

My assumption here was cpuid will be set just system page_pool so it is jus=
t a
matter of not running page_pool_destroy for them. Anyway in the future we c=
ould
allow to set cpuid even for non-system page_pool if the pool is linked to a
given rx-queue and the queue is pinned to a given cpu.

Regards,
Lorenzo

>=20
> Rewriting cpuid doesn't introduce any new checks on hotpath. Destroying
> the pool is slowpath and we shouldn't hurt hotpath to handle it.
>=20
> > idea of overwriting the cpuid field for it.
>=20
> We also overwrite pp->p.napi field a couple lines below. It happens only
> when destroying the pool, we don't care about the fields at this point.
>=20
> >=20
> > Regards,
> > Lorenzo
> >=20
> >>
> >>>
> >>> I guess we could still do this in case we find other uses for setting
> >>> the cpuid; I don't think the addition of the READ_ONCE() will have any
> >>> measurable overhead on the common arches?
> >>
> >> READ_ONCE() is cheap, but I thought it's worth mentioning in the
> >> commitmsg anyway :)
> >>
> >>>
> >>> -Toke
>=20
> Thanks,
> Olek

--MN2cs1CvNJYC3dkc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZc4ZUwAKCRA6cBh0uS2t
rIttAP9o5h37WPKS26lffxdmH29qGnoV/x0d8qqUkHSo3YRIyAD+MTT6z4V3J8bb
fhu+Znf8NbyvyQVE13nMFnBjRxKKBw8=
=bjmB
-----END PGP SIGNATURE-----

--MN2cs1CvNJYC3dkc--