Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp485783rdb; Thu, 15 Feb 2024 06:22:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVmggs3yYp4bGu5zL0UR9IiFAqnsqfw0z3zRQw270QQP9eBdYPosw49NxrhVoLKXa8F4lhmrQzzIljIlMYziDpBZk9p6vxNvoT6WTgynw== X-Google-Smtp-Source: AGHT+IGbH/6UDxyXMv/twHWYMfhfMTcdevyRiRubi503bRe3w4MJ2i6WlRf5AOZRweDcup+9MS6j X-Received: by 2002:a17:906:680d:b0:a3d:2392:b025 with SMTP id k13-20020a170906680d00b00a3d2392b025mr1456349ejr.50.1708006940867; Thu, 15 Feb 2024 06:22:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708006940; cv=pass; d=google.com; s=arc-20160816; b=NP1ilcF3js6vHHxXl6z9oQsQUHnEnxNhKNrau2eBS78MptDE7yjOExme1pmpQ0URSR AWHOqTy5sX6M7cggeMaBzyzfgjn5FMxF6La0H2EhKa2zWVQf9IywJUg9mh9Itlxm9qy5 IVmFmnSYfI2bEpY3sWyHMQWLXvdS36CTbldYKoKbDI/I6iYQ5BVeLhOXpMsDxoKKGA1N 9CBmueVTeeXB+vZ/UeS/KdvZ/Sywjff560u9g20q7tTsr+z1hsJSg8UnJKlIX/9WSP+/ C6Re1rqEnsV/IHzjrR7qcY7wXNtMxrlykCilLedr12fr3YBl5cN/tqsqU9VcSxZ3Ufys Hz/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:autocrypt:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=cPb/g7Nwwp5hrWLId1X6UgtlqlhxYjdseVQKBKXNOZ0=; fh=WYf6n3Bye2BbvvgtvLWIhV8gvPAMs5dKRAfCfcdkFiY=; b=aLCBuARMJ2yMzj9h78wep5b3/Flg+6azJiqjzGRhHHsC/alu34QodYYWOly90tbczn yGC+iry8MWAqHr5GEmCyzs/D+3KVaD0DAz3hBwn5+GaCF/57LItJUkVAPVo6WztaNSGq +COhBsWHIq57YJSgA9v04QyeaSkmhPzHOONjGVg8EtcJ7n2k3kioQGi6j3c0SDyBzt1p hexufdVZxSx3mBjFYlUPgk0x8pJj5runEkYz8g3F8eE0IP/ovzrGgzoKgxXx9UhG+5zH yCVgAsyTgZO+aRf/4I9dH9cvuGum+0T9m9weMuHsx6//lNyKvgcRA8zaDScQslwiHPlN 9haA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=skole.hr); spf=pass (google.com: domain of linux-kernel+bounces-67074-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67074-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qk28-20020a170906d9dc00b00a3d5815ca8asi678366ejb.258.2024.02.15.06.22.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 06:22:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-67074-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=skole.hr); spf=pass (google.com: domain of linux-kernel+bounces-67074-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67074-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 95A4E1F26F46 for ; Thu, 15 Feb 2024 14:22:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2AD6B131E49; Thu, 15 Feb 2024 14:21:54 +0000 (UTC) Received: from mx.skole.hr (mx1.hosting.skole.hr [161.53.165.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD547130ADA; Thu, 15 Feb 2024 14:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=161.53.165.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708006913; cv=none; b=lX3c8X1g8u+0d3Ear8EqSRsfJt1lSronWzUIWQQeux1JCBcerdSvR5laLxVVDbzA9aPUL+OPTHhQ85w7stqorEID1JC+oxT5ALS56xb2zqnsF9/dRDWH2b50lTF4Vwsk0cqOENT6Qc7zTfKDLLYGUdNMiLXn3n5+ue+Dlv9IUgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708006913; c=relaxed/simple; bh=ZdAF2Hedn11YRPJ8FW4xDYC4UE4K3UNWPgPTBjO3qUw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MooCcGv6s5J0ZJLTYZ7PMrrUlwtkhIW7uL+9AjQDG/RD37jGYM5ljv54H5eR39FW8LWJn519zpzq91ImVpJdTZUZ+yvNEH3T8MvqtJSo3tpxBF7K1Pe9uoXYRTL6TUkmUteaZMkJ6g50g7LoSitvAb3OC81u6VZhsqVzlPPq4gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr; spf=pass smtp.mailfrom=skole.hr; arc=none smtp.client-ip=161.53.165.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=skole.hr Received: from mx1.hosting.skole.hr (localhost.localdomain [127.0.0.1]) by mx.skole.hr (mx.skole.hr) with ESMTP id 2C97E92570; Thu, 15 Feb 2024 15:21:45 +0100 (CET) From: Duje =?utf-8?B?TWloYW5vdmnEhw==?= To: Linus Walleij Cc: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Arnd Bergmann , Karel Balej , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: ktd2801: depend on GPIOLIB Date: Thu, 15 Feb 2024 15:20:50 +0100 Message-ID: <5772702.DvuYhMxLoT@radijator> In-Reply-To: References: <20240213-ktd2801-deps-v1-1-7feb5385eb9a@skole.hr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Autocrypt: addr=duje.mihanovic@skole.hr; keydata= mQINBGBhuA8BEACtpIbYNfUtQkpVqgHMPlcQR/vZhB7VUh5S32uSyerG28gUxFs2be//GOhSHv+ DilYp3N3pnTdu1NPGD/D1bzxpSuCz6lylansMzpP21Idn3ydqFydDTduQlvY6nqR2p5hndQg6II pmVvNZXLyP2B3EE1ypdLIm6dJJIZzLm6uJywAePCyncRDJY0J7mn7q8Nwzd6LG74D8+6+fKptFS QYI8Ira7rLtGZHsbfO9MLQI/dSL6xe8ZTnEMjQMAmFvsd2M2rAm8YIV57h/B8oP5V0U4/CkHVho m+a2p0nGRmyDeluQ3rQmX1/m6M5W0yBnEcz5yWgVV63zoZp9EJu3NcZWs22LD6SQjTV1X8Eo999 LtviIj2rIeCliozdsHwv3lN0BzTg9ST9klnDgY0eYeSY1lstwCXrApZCSBKnz98nX9CuuZeGx0b PHelxzHW/+VtWu1IH5679wcZ7J/kQYUxhhk+cIpadRiRaXgZffxd3Fkv4sJ8gP0mTU8g6UEresg lm9kZKYIeKpaKreM7f/WadUbtpkxby8Tl1qp24jS1XcFTdnjTo3YB2i2Rm9mAL2Bun9rNSwvDjE fjMt5D5I+CIpIshaQwAXwRTBJHHAfeEt62C1FQRQEMAksp4Kk1s2UpZkekZzNn48BnwWq75+kEj tuOtJIQGWTEHBgMG9dBO6OwARAQABtClEdWplIE1paGFub3ZpxIcgPGR1amUubWloYW5vdmljQH Nrb2xlLmhyPokCTgQTAQgAOAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFPfnU2cP+EQ+ zYteJoRnrBCLZbhBQJg01LLAAoJEJoRnrBCLZbhMwoQAJBNKdxLxUBUYjLR3dEePkIXmY27++cI DHGmoSSTu5BWqlw9rKyDK8dGxTOdc9Pd4968hskWhLSwmb8vTgNPRf1qOg2PROdeXG34pYc2DEC 0qfzs19jGE+fGE4QnvPCHBe5fkT2FPCBmNShxZc1YSkhHjpTIKHPAtX1/eIYveNK2AS/jpl23Uh hG9wsR2+tlySPNjAtYOnXxWDIUex8Vsj2a2PBXNVS3bRDeKmtSHuYo7JrQZdDc0IJiRm0BiLEOI ehTtcYqYr1Ztw7VNN2Mop/JG2nlxXNaQmyaV6kF/tuaqn1DJQcb0OxjAXEUMaICYJOwS9HSt26n uwo8dUiUPLQTih/wm6tyu2xrgMwqVT5jiKIssSS+7QNTsmldubRSYjFT49vwkVoUQ6Z3UO6BVdd f3OG4meE0S5uQc7Moebq67ILxfQ8XsDvdvEliVuHh89GAlQOttTpc6lNk8gCWQ+LFLvS66/6LFz mK1X4zC7K/V6B2xlP4ZIa3IC9QIGuQaRsVBbbiGB3CNgh0Sabsfs4cDJ7zzG1jE7Y4R9uYvdSFj Liq5SFlaswQ+LRl9sgzukEBTmNjdDVhufMY2jxtcMtck978E1W1zrg94iVl5E0HQZcpFHCZjRZX Fa42yPsvVkFwy4IEht9UJacMW9Hkq5BFHsdToWmg7RY8Mh04rszTiQJUBBMBCAA+AhsDBQsJCAc CBhUKCQgLAgQWAgMBAh4BAheAFiEEU9+dTZw/4RD7Ni14mhGesEItluEFAmCVBxAFCQXW6YEACg kQmhGesEItluFXIg//QnqY5RrQ1pLw2J51UwFec4hFMFJ6MixI9/YgizsRd2QLM7Cyi+ljkaHFQ mO4O5p0RsbF/2cc4u1D+MhQJGl6Ch6bdHoiWFrNUexgBUmflr4ekpI+GIFzikl6JTYHcRfkjobj 0Tmr8zWoxzcdFhrzGn5/6AH3GxudpUr6WQD5iDSe43T7ZcY8zHfD+9zcsZ2LHhRhpHU0q+ERQw+ Rnh7C3urXlrAlFzuKuPh2tHT76glRaledJ8cK34vHNi73TYpsFy4tfhAPhHwBogtjBf63jBOd/E S6wuYpKwcfNXo9EuEpJzJOitFwOvAra5AbCE+N/C/IOu2aFeOyu2SbHro06+Eyf/jy1A2t+LgLb E5cZu5ETyicfpN8L7m7wTTXTSx0NhETNWfgV95RUI6WIW5N4OCOVo8d/GOMVEYqMoDZndQin9B3 lDgojyagdzhXljP2BqavKdnPWbcKQ+JViR+e7EjLWVifgZkAvEhyirbTKYsgKkaRxoQP68U0bEy ukygDZRdzBmWaZPqBOzA5AH+OYiYVzzFqdBAHr2+z4mTN6W0td7CFDRAS2RzQApO3B1QH408Ke9 Oy69HwG+gdlfwloN6JTvgr5vQc8T6e3iC3Be/guLyW5UbLPxyFHimznVOizDYbZO1QSZMqk4G9I gA8e05P8dxEQJUsdZFtDdNPOYm5Ag0EYGG4DwEQAMD0bO0u9apmI1WOk41IdU1Hc76HLUA9jsiB ffA9yZ1OpnFEIAwSeUO8PFK7W5YPdRreNsUvMmBiLJid9y0tW5sACjSrH+amCQl0hJ3KlEkr+Vu Wga1a+Ye0qzg87bQae769RhwzEPvQvvNoTxTtvT5Alg2p3JSv5d/wC2Tu9IoFKkDAIoCFsvytuZ r2LuH3oK57oThhbEogYXR7YJ0JIwVg7nOQXnqpUTzxkh/73FKN6Bx01m37pB3wTe8w3w8r8WOip oRU+aPWhafDNFrdyBfSVOAw3fmX9yAfFfZo4w9OTdkrLLdK6SmX7mqiMstoZnvZIpLRk/L0ZNrJ 8fAVD+fEcpUiCoKwiiY0QFCWumMXITeD4zlo/Y6lQKhUp6EY0kcjG1D7n5sBR5oQcsC9PlH9a12 L+tNIfljayiEVobmkPwGf5p3sxOqeks6WWoB9+ZIk888kQdI/b7VA/86QvsTqubpJtr5uVNtyyj ZYTBHFnEGcA5+Rs2K/8TWFYDEBZiybfpCxrYT2RdTF7ef2wQZAiNZhzaEwxr7S4YTFuCwwqaKLt vckGv2fsFUy3qe28tw93oCNQxSqgOq6RD0HfblViXeioyP1nWVLAx6paS7d38TT6cz0HJCtOMFn S+UpJDv2x3gReCPBoqRx7LV4aYMyGy4pzwes+yO87hxULtw/ABEBAAGJAjYEGAEIACAWIQRT351 NnD/hEPs2LXiaEZ6wQi2W4QUCYGG4DwIbDAAKCRCaEZ6wQi2W4de4D/0aCxE4dTmO1xQ6BDXlKp DCegk8dIqrxK8Edbdq9/WGSO6Js0QfIL50IHAR739FbScT4+oSObeg0ap9kCGfW0AXGZaU82Ed1 5u+MzgksHE+t8cgULTKjqqt+PXq0yxZfLwI9itTa3zE2d6Uxd4Vzq77jjQuDL6o3zM6BQTJGYxx S6mELElcnMlo9lIZKzCAHaIkkMlMNBfvm8Q92aCuQ75xjWhis9K9lyV9cQZfu8AyP4zMGFk50Z5 tEF2UFylqKu+v8FZiezviwu9NsZegIY4DRaPWF5GWmFhYU4e9gBFG5xhEoIlO+etu1nSE1UJk+r mvJL20uKNUPnhXTJaQTzACpA1/2FqDnOUUx8qOYqmHMlFuy2qUh/QHShjc2AtngTFZrzAnGz6ni lRl32b7p8N+KaO4u2UGmGOwd/CuCzr2DxGomUSyCwOta7vOxator+NPK48roa417gBZ6ZFRplma ExicLFSnwBdGC3NnDa+yoRHKXHVSDfkb/FEhWuN/1tTZ96uxVYtHcln+snB2N6/hwmrOon2cHNu UeTLcrVyqI0Qz8JT4ksGxkxziO2L/e0O/xUp9mLAswixWt8+BMz/3sIJbdAPBVyt5QbHzWR6aID B5cQ1aQwZB8n7yt8B0sd/uIQItYu2urJ9gVAJkaEDms8+vbtOM4totXk5swwGxRg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" On Thursday, February 15, 2024 2:31:37 PM CET Linus Walleij wrote: > On Tue, Feb 13, 2024 at 7:13=E2=80=AFPM Duje Mihanovi=C4=87 =20 wrote: > > LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it: > >=20 > > WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE > >=20 > > Depends on [n]: NEW_LEDS [=3Dy] && GPIOLIB [=3Dn] > > Selected by [m]: > > - BACKLIGHT_KTD2801 [=3Dm] && HAS_IOMEM [=3Dy] && BACKLIGHT_CLASS_DEV= ICE=20 [=3Dm] > >=20 > > Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support") > > Signed-off-by: Duje Mihanovi=C4=87 >=20 > Acked-by: Linus Walleij >=20 > Technically you can also select GPIOLIB, because it is available on > all platforms, so it may be easier for users, but then you never know > which GPIOs you get in practice. Now that I think of it, wouldn't that be the better solution? I opted for=20 "depends on" only because Arnd did the same in his KTD2692 patch, but if=20 select is better (and it seems to be for users) then I'd go for that in bot= h=20 patches. Regards, =2D-=20 Duje