Received-SPF: pass (google.com: domain of linux-kernel+bounces-67076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 15 Feb 2024 14:22:28 +0000
From: Mark Brown <broonie@kernel.org>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH 1/5] spi: dt-bindings: add binding doc for spi-qpic-snand
Message-ID: <ab55fcde-f3ee-426c-ae24-2e76ffb20a2b@sirena.org.uk>
References: <20240215134856.1313239-1-quic_mdalam@quicinc.com>
 <20240215134856.1313239-2-quic_mdalam@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2csQjU5l3LaA5RPk"
Content-Disposition: inline
In-Reply-To: <20240215134856.1313239-2-quic_mdalam@quicinc.com>


--2csQjU5l3LaA5RPk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 15, 2024 at 07:18:52PM +0530, Md Sadre Alam wrote:

> +  clocks:
> +    minItems: 2
> +    maxItems: 3
> +
> +  clock-names:
> +    minItems: 2
> +    maxItems: 3

The driver requests the clocks by name but this does not document the
expected set of names.  The driver also unconditionally requests all
three clocks so won't work with only two clocks.

--2csQjU5l3LaA5RPk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXOHiMACgkQJNaLcl1U
h9Bs8gf5AeVDl5A5NLKeeCU9eg710unicAjbLogdVKMnVejjdUC0v4uk4sfxSLer
X8VBBJAl9HfbmBfbXLHsRmyM6keu3hPFl4GJyAWo0yK4sMmPeGRl138cdPZLYW5k
cWaWnByMVUmJhRS+vzx/+NvZsr28LnnvhNhTwK7VEgd7/vDj6j8Iz/6bzMBaA3Mq
whPUldObYURrMzojCoUYM/hdnos2MXRqauACX6GRivbRYP15eowVxAiGcQpBbuRP
IhUiku9ujdwyU39SeSFrrpghK7UiFft1/rSqyXmZUOyUS8xOZGXUDACUJztKfQ6G
20MK0dUD0t2Z8IFIJ7wQLl7qn/dk8w==
=pWun
-----END PGP SIGNATURE-----

--2csQjU5l3LaA5RPk--