Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp539021rdb; Thu, 15 Feb 2024 07:44:29 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUboLqcNtSpIHAQzHMokTnSDBJQBIRPt5Sr7eBNg8D5p7Nqb7wiPMv8I28U8B+jnADiFtChuigaybPK01nWsUEIlOZPondbBv0+mNAjsA== X-Google-Smtp-Source: AGHT+IEEXy8Z/vBcjSYZb0H7RHratykKLQeApynvwGrK84usT8YA9HqfBePY1mDZHTFwIPxv/6Ef X-Received: by 2002:a17:90a:fb8f:b0:299:1489:ad46 with SMTP id cp15-20020a17090afb8f00b002991489ad46mr1355446pjb.20.1708011869061; Thu, 15 Feb 2024 07:44:29 -0800 (PST) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id oa13-20020a17090b1bcd00b00298ecfec4a8si1404403pjb.13.2024.02.15.07.44.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 07:44:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-67221-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-67221-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67221-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 07714282836 for ; Thu, 15 Feb 2024 15:43:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F2DA8133993; Thu, 15 Feb 2024 15:43:46 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0985131E32; Thu, 15 Feb 2024 15:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708011826; cv=none; b=VKLAHvz/0ZccEVT410ofMcF5XfHKBJHk/9vlGa3R7FUzhwgjZ2Kmt2IZUMKwsaakTSDnSNACbXTeH2miU+HFyWBKTHKVqqLjLMXTRdAOtTD0IQFl7caHdGrkME8Zn1DCMEOyNebXUPammEPg/WQtIXjb2L37j4UgqLuBEfcd+5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708011826; c=relaxed/simple; bh=TJsPB+8Ri3mag0/4Xa7Y/8yh0dXjxsPbuApK0HpLjlU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ix1XKwGztr8Nj2a/6vdjT/sv/ISIRrOKVJYVklAZY6IJoCP42HIjZ+WIi3SpeQXxYlMZNgWjLvJDzcs3gahvYgG9dAb2PcX7Aw9g6cgUiqK+VZ6hc2r6pq2A6Eg/gWlHhveu62oseeDXyT0Z2bMwisdaMWx+waCpBDJDgq4HPNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="2231416" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="2231416" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:43:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="912182357" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="912182357" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:43:38 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1radte-00000004pbX-2JH2; Thu, 15 Feb 2024 17:43:34 +0200 Date: Thu, 15 Feb 2024 17:43:34 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 08/18] phy: ti: phy-j721e-wiz: split wiz_clock_init() function Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-8-5c2e4a3fac1f@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v3-8-5c2e4a3fac1f@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Feb 15, 2024 at 04:17:53PM +0100, Thomas Richard wrote: > The wiz_clock_init() function mixes probe and hardware configuration. > Rename the wiz_clock_init() to wiz_clock_probe() and move the hardware > configuration part in a new function named wiz_clock_init(). > > This hardware configuration sequence must be called during the resume > stage of the driver. .. (Side note, as this can be done later) > if (rate >= 100000000) > + if (rate >= 100000000) > + if (rate >= 100000000) I would make local definition and use it, we may get the global one as there are users. #define HZ_PER_GHZ 1000000000UL -- With Best Regards, Andy Shevchenko