Received-SPF: pass (google.com: domain of linux-kernel+bounces-67178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240213172340.228314-1-robdclark@gmail.com> <Zc2-qVd0gtErdbKe@hovoldconsulting.com>
In-Reply-To: <Zc2-qVd0gtErdbKe@hovoldconsulting.com>
From: Rob Clark <robdclark@gmail.com>
Date: Thu, 15 Feb 2024 07:28:53 -0800
Message-ID: <CAF6AEGsPojmqDgMZWrEAm_CoWGZ05euc0jzD5+9aX0cXQha_ew@mail.gmail.com>
Subject: Re: [PATCH] drm/msm: Wire up tlb ops
To: Johan Hovold <johan@kernel.org>
Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, 
	linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@chromium.org>, 
	Robin Murphy <robin.murphy@arm.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, 
	Marijn Suijten <marijn.suijten@somainline.org>, David Airlie <airlied@gmail.com>, 
	Daniel Vetter <daniel@ffwll.ch>, Bjorn Andersson <andersson@kernel.org>, 
	Jordan Crouse <jordan@cosmicpenguin.net>, open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 14, 2024 at 11:34=E2=80=AFPM Johan Hovold <johan@kernel.org> wr=
ote:
>
> On Tue, Feb 13, 2024 at 09:23:40AM -0800, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > The brute force iommu_flush_iotlb_all() was good enough for unmap, but
> > in some cases a map operation could require removing a table pte entry
> > to replace with a block entry.  This also requires tlb invalidation.
> > Missing this was resulting an obscure iova fault on what should be a
> > valid buffer address.
> >
> > Thanks to Robin Murphy for helping me understand the cause of the fault=
.
> >
> > Cc: Robin Murphy <robin.murphy@arm.com>
> > Fixes: b145c6e65eb0 ("drm/msm: Add support to create a local pagetable"=
)
>
> Sounds like you're missing a
>
> Cc: stable@vger.kernel.org
>
> here? Or is there some reason not to backport this fix (to 5.9 and later
> kernels)?

No reason, I just expected the Fixes tag was sufficient

BR,
-R

> > Signed-off-by: Rob Clark <robdclark@chromium.org>
>
> Johan