Received-SPF: pass (google.com: domain of linux-kernel+bounces-67259-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 15 Feb 2024 08:03:07 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Paul Barker <paul.barker.ct@bp.renesas.com>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>, "David S . Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
 Wolfram Sang <wsa+renesas@sang-engineering.com>, Nikita Yushchenko
 <nikita.yoush@cogentembedded.com>, Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?=
 <u.kleine-koenig@pengutronix.de>, Claudiu Beznea
 <claudiu.beznea.uj@bp.renesas.com>, Lad Prabhakar
 <prabhakar.mahadev-lad.rj@bp.renesas.com>, Biju Das
 <biju.das.jz@bp.renesas.com>, netdev@vger.kernel.org,
 linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: ravb: Count packets instead of descriptors
 in GbEth RX path
Message-ID: <20240215080307.226732cf@kernel.org>
In-Reply-To: <20240214151204.2976-1-paul.barker.ct@bp.renesas.com>
References: <20240214151204.2976-1-paul.barker.ct@bp.renesas.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 14 Feb 2024 15:12:04 +0000 Paul Barker wrote:
> The units of "work done" in the RX path should be packets instead of
> descriptors, as large packets can be spread over multiple descriptors.

FWIW one of y'all may also want to look into processing Tx completions
before Rx. Tx completions can free memory which Rx can then consume.
More efficient. Not to mention netconsole being able to reap Tx with
budget of 0.