Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp561080rdb; Thu, 15 Feb 2024 08:17:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWH0I9mIBv7h5RwEhuq1ORp/mUGgH3V1/WP6pg/4i1MGW0OB1LQYB17BS5Mmp3X+feS8VFCMrVjYHv2gf0M6e2N1JhP/ahgQOOSI8ErWw== X-Google-Smtp-Source: AGHT+IGkpLqNKEp8HJxdhPu3KRtXw0zRWnmkJiV8BnaUGn91/o2ZwVxvZMXXxe53kFyKM9v4VjAh X-Received: by 2002:a17:903:22cf:b0:1d8:ce58:f4ad with SMTP id y15-20020a17090322cf00b001d8ce58f4admr2469724plg.1.1708013830539; Thu, 15 Feb 2024 08:17:10 -0800 (PST) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id m130-20020a633f88000000b005cd88585706si1320461pga.828.2024.02.15.08.17.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 08:17:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-67236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-67236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67236-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1D2EFB286F3 for ; Thu, 15 Feb 2024 15:49:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9010F13474F; Thu, 15 Feb 2024 15:45:41 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DCF113472D; Thu, 15 Feb 2024 15:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708011941; cv=none; b=aHwPcplyiSO3gJSgX+lZpTnM1TFXBksJomB95n1ye2yltl33Mix73KOFffyxexnHgNmBRYAX1MRAXghMxg7Em7RQU0GQ3iZGQpMYaCCM+rb6iR3eaarhT9NLUhS2bI5WzMlyXTZAa2Y3x2+JD002Ap1gpyU0ohmcr4uxFVSKqbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708011941; c=relaxed/simple; bh=vN6J3AW5mtof2ECx6LjKZ0g0AWl2ltYlQ1vrf5U8b24=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bcLYpHTBBW5FrSQQuSYxhKPAIPMfiG6afF7muAuy5NfcjbxNM3FupImKYzNaa61P+NHjko2491dFv/xoCln2T0e2qI1XNsZCejTG2LmMs0VL9FynTPSLIdxLOAOjlGKlu7Bg0j0fO5C4cibzFuaNGePq8BJ5Is1DW7CMitfeQCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="2231622" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="2231622" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:45:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="912182511" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="912182511" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:45:32 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1radvU-00000004pco-36lU; Thu, 15 Feb 2024 17:45:28 +0200 Date: Thu, 15 Feb 2024 17:45:28 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 13/18] phy: cadence-torrent: remove noop_ops phy operations Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-13-5c2e4a3fac1f@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v3-13-5c2e4a3fac1f@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Feb 15, 2024 at 04:17:58PM +0100, Thomas Richard wrote: > Even if a PHY is already configured, the PHY operations are needed during > resume stage, as the PHY is in reset state. > The noop_ops PHY operations is removed to always have PHY operations. > The already_configured flag is checked at the begening of init, configure > and poweron operations to keep the already_configured behaviour. .. > + if (cdns_phy->already_configured) { > + /* Give 5ms to 10ms delay for the PIPE clock to be stable */ > + usleep_range(5000, 10000); fsleep() ? (Yes, I see this is the original code, perhaps later in a separate change) > + return 0; > + } -- With Best Regards, Andy Shevchenko