Received-SPF: pass (google.com: domain of linux-kernel+bounces-67302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 15 Feb 2024 17:22:24 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>
CC: "Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@intel.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@intel.com>, "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>, "kuba@kernel.org"
	<kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>,
	"intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Suresh Kumar
	<suresh2514@gmail.com>
Subject: Re: [PATCH iwl v2] i40e: print correct hw max rss count in kernel
 ring buffer
Message-ID: <Zc46QEBEpCOL75qN@boxer>
References: <20240120072806.8554-1-suresh2514@gmail.com>
 <e524c57e-fe43-4582-bb05-c50f3e529848@intel.com>
 <SJ0PR11MB5866EAA3CBAF4E28842305D5E57D2@SJ0PR11MB5866.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <SJ0PR11MB5866EAA3CBAF4E28842305D5E57D2@SJ0PR11MB5866.namprd11.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PzVF3Kqjih6LfI2bhugCvZsQVwyYF2NNFzIvTnVFkWCI70rCcF+7q26WJpbo?=
 =?us-ascii?Q?KoiXc6QiNV+N7ibsoC4yI6GDP3Q74JKc7HezjFs6YfQuOK/6Sb51IS8Ra2Re?=
 =?us-ascii?Q?bBmV0YK2FVVTp6kzLhgKyMvOzWamfudsj4sd+YxuFP9D/5tQ0llouBbYDuVC?=
 =?us-ascii?Q?C5Ct9QoYhwzwr2FOF8cgqrBKQqRygAioL0cE4XxsR01ebJVAJ9UbmrOLsgjl?=
 =?us-ascii?Q?VRgiv1IilfhzIVgmbzZQHcm3kixGgbEohuMDBiBP1vG+8pOhmkRvABdf51I8?=
 =?us-ascii?Q?NmNhFrC6qT8ReWplM5hWJpmYqb0bs3k3H3lW4t5dMHjxRGO9oP6D32F++h0B?=
 =?us-ascii?Q?str/hU3Vvja0kxlwG8bIgQmtz+ES0gQdZXVRLkdnj82c/HnvVZnKsKnHiKG2?=
 =?us-ascii?Q?5IIB2khA54PCVv+/Roxm5IIdUaEd1ISQpnfG3U5h/gHxV5QNvMxxAXOQPQMF?=
 =?us-ascii?Q?YRHyvzTSWzOKagWrLYdOBQA1Ib0apljRVdv0VMq0BYnE2Duaz2IB2hX0ShKt?=
 =?us-ascii?Q?uQTHrL0UChmNcZxL67PNnUuJy4n8gvp+nqbEdd4xyoeWC64auWwtUFqShkWI?=
 =?us-ascii?Q?114r6NNwPJPzwpyuPOKbG5/IYBdUjqYsCU00JgsGxtW5Ah35J/Qug6SRul+o?=
 =?us-ascii?Q?pgXqaJ1inOZm5ojuYr93z6Wyqaq38/tfZY8WOBXP0baZuLtL/qetyPdEhXtO?=
 =?us-ascii?Q?zheJVw2FH7bXAmE46yuqO4WFzCKxt37O+44OdBhp8VuDTrM5zqy0X8rCL7OL?=
 =?us-ascii?Q?p0XPvXzMO9iDoFgiwC96RK6uvKsK+nKN6ll9DHb0nS+5uKcS91bi5tP3yGbW?=
 =?us-ascii?Q?275U0CtQzpCg0kHjXtq2z9RJUx/owhukR6eFNcHx6Z6MPEb/fqsiqZdUfwQ1?=
 =?us-ascii?Q?HFxjC+kzB2kVTx7H+E/iadyY4AoqNL9hGYRPbwhO8V/7rgSXAlJ03iEDa+pY?=
 =?us-ascii?Q?1Z8gpLL6x1P8Nj2qKI6nhcZWEuEBNbGbfOISQr6CIarSI0fhWBOJyfHfFVRN?=
 =?us-ascii?Q?81YX0yleqdiEEdfGuta2D3hqwayPH7iGK2PocquTxy8vjY0V1ta1T0Xi/71n?=
 =?us-ascii?Q?E5kIKYKEIWQeCZZ2DVoPhgDPTZDYqucwy6+TVEJ/a3jBtda05vWk4Qey7sJR?=
 =?us-ascii?Q?ZgpnPdZmd1uFN+UFIeKsRXMQQ9mly9hIWaoF8YatbXBIWMv2w43L2P6Ua7kb?=
 =?us-ascii?Q?dwuQf/V5KuIEhJKyDG0decRR90ETcXpM4ermh3rTfzAwW4iqGaiP7bm294Bj?=
 =?us-ascii?Q?I6xbstEZZWjpLysy72IE5Ivgw0p7lFCJqbQdWMHfsjmJ9xxB+FgyEMl/dzaD?=
 =?us-ascii?Q?vmRSJVqAObs52IpIJf0j2t8P6HTbGJwYbPwJfY/dBI5HUmLaF8U3ZhSCq/Ti?=
 =?us-ascii?Q?sPMR1qc/ZhcDlkRNY+qVBbmQ46ESYlD4UFa4pAXl9OkZiBwWalmh6VgkmueW?=
 =?us-ascii?Q?JJzU+wzHfwNBG+AeiIVsX6GP/acgEhZdxlYFv16zglFmM05jMpBc9NlvRw0m?=
 =?us-ascii?Q?kQqb+y2GVFVu2zG8QQn+LhFZC8yrRf6o1+QBTxKOG0lfKQrQWgOyG4jRfXYh?=
 =?us-ascii?Q?iLy+HfBUgByWuOp+551NwTOXnPzvh3SbGNhUk0WBeNpLN8XDTq25MLWZIeWi?=
 =?us-ascii?Q?lw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b06ceab6-95af-47bb-4267-08dc2e424e39
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 16:22:29.6983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GMSC8aMgoOXjF6wRZyxXuC1xJJmN2Sg4gWDsVOA/i6RQAIWHJ71lQjQSRgZaY+qnpt3BQaZaqH0TKHUgqKCiHtB8E8xQJscY1FZ90mOVv4c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4964
X-OriginatorOrg: intel.com

On Tue, Jan 30, 2024 at 08:33:43AM +0000, Loktionov, Aleksandr wrote:
> > -----Original Message-----
> > From: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>
> > Sent: Tuesday, January 30, 2024 9:26 AM
> > To: Loktionov, Aleksandr <aleksandr.loktionov@intel.com>
> > Subject: Fwd: [PATCH iwl v2] i40e: print correct hw max rss count

Subject should be iwl-net and you should have Fixes: tag.
I also would like you to go through
https://docs.kernel.org/process/submitting-patches.html

or any other document that would prepare you for your first submission.

> > in kernel ring buffer
> > 
> > FWD to Alex
> > 
> > 
> > -------- Forwarded Message --------
> > Subject: [PATCH iwl v2] i40e: print correct hw max rss count in
> > kernel ring buffer
> > Date: Sat, 20 Jan 2024 12:58:06 +0530
> > From: Suresh Kumar <suresh2514@gmail.com>
> > To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
> > davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
> > pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
> > netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> > CC: Suresh Kumar <suresh2514@gmail.com>
> > 
> > pf->rss_size_max is hardcoded and always prints max rss count as
> > 64.
> > 
> > Eg:
> >    kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS
> > count:  104/64
> > 
> > whereas  ethtool reports the correct value from "vsi-
> > >num_queue_pairs"
> > 
> > Channel parameters for eno33:
> > Pre-set maximums:
> > RX:     n/a
> > TX:     n/a
> > Other:      1
> > Combined:   104
> > Current hardware settings:
> > RX:     n/a
> > TX:     n/a
> > Other:      1
> > Combined:   104  <-------
> > 
> > and is misleading.
> > 
> > Change it to vsi->num_queue_pairs
> 
> Please reject this patch, it breaks driver logging.
> The massage clearly states that it dumps max rss queues number that f/w supports.

..which would imply that you would be able to work with anything more
than 64 queues. From a quick glance rss_size_max comes from early i40e
days and if that would be the limit indeed then driver allowing 104 queues
would be a disaster, no?

> 
> Thank you
>  
> > Signed-off-by: Suresh Kumar <suresh2514@gmail.com>
> > ---
> >   drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > index d5519af34657..f5c1ec190f7e 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > @@ -12524,7 +12524,7 @@ int i40e_reconfig_rss_queues(struct i40e_pf
> > *pf, int queue_count)
> >   		i40e_pf_config_rss(pf);
> >   	}
> >   	dev_info(&pf->pdev->dev, "User requested queue count/HW max
> > RSS
> > count:  %d/%d\n",
> > -		 vsi->req_queue_pairs, pf->rss_size_max);
> > +		 vsi->req_queue_pairs, vsi->num_queue_pairs);

IMHO this should be vsi->alloc_queue_pairs instead.

> >   	return pf->alloc_rss_size;
> >   }
> >   -- 2.43.0
> > 
>