Received-SPF: pass (google.com: domain of linux-kernel+bounces-67324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <737d2870-7a01-4f3f-9825-6583804607bb@infradead.org>
Date: Thu, 15 Feb 2024 08:47:54 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] sparc: select FRAME_POINTER instead of redefining it
Content-Language: en-US
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: Andreas Larsson <andreas@gaisler.com>,
 "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org,
 sparclinux@vger.kernel.org
References: <20240215135749.1909812-1-masahiroy@kernel.org>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240215135749.1909812-1-masahiroy@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/15/24 05:57, Masahiro Yamada wrote:
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
> 
> Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must
> also be selected to avoid the unmet dependency warning.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> 
>  arch/sparc/Kconfig.debug | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug
> index 37e003665de6..d475a056a2e0 100644
> --- a/arch/sparc/Kconfig.debug
> +++ b/arch/sparc/Kconfig.debug
> @@ -8,11 +8,8 @@ config MCOUNT
>  	bool
>  	depends on SPARC64
>  	depends on FUNCTION_TRACER
> -	default y
> -
> -config FRAME_POINTER
> -	bool
> -	depends on MCOUNT
> +	select ARCH_WANT_FRAME_POINTERS
> +	select FRAME_POINTER
>  	default y
>  
>  config HAVE_HARDLOCKUP_DETECTOR_SPARC64

-- 
#Randy