Received-SPF: pass (google.com: domain of linux-kernel+bounces-67305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <ff44adad-5be1-bef4-098f-ee363fcfb08e@amd.com>
Date: Thu, 15 Feb 2024 21:54:56 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [patch V6 00/19] x86/cpu: Rework topology evaluation
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Tom Lendacky <thomas.lendacky@amd.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Arjan van de Ven <arjan@linux.intel.com>, Huang Rui <ray.huang@amd.com>,
 Juergen Gross <jgross@suse.com>, Dimitri Sivanich
 <dimitri.sivanich@hpe.com>, Sohil Mehta <sohil.mehta@intel.com>,
 Kan Liang <kan.liang@linux.intel.com>, Zhang Rui <rui.zhang@intel.com>,
 "Paul E. McKenney" <paulmck@kernel.org>, Feng Tang <feng.tang@intel.com>,
 Andy Shevchenko <andy@infradead.org>, Michael Kelley <mhklinux@outlook.com>,
 "Peter Zijlstra (Intel)" <peterz@infradead.org>
References: <20240212153109.330805450@linutronix.de>
From: K Prateek Nayak <kprateek.nayak@amd.com>
In-Reply-To: <20240212153109.330805450@linutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U0ZtSWkyd3NhL2dHYlpDSVlhYTJsR3JxUXp3Y3QwQklIMUNHQVE0R3ZUbmpB?=
 =?utf-8?B?aVF0OGFiQzJhRUdlSHkxcHEweFJQeS9xOW5hOE9KWXk1U1JxeWxMNGt1MkRI?=
 =?utf-8?B?UytOc0NEU052UWovSGdFaDNldXFubGZPc1JuRTVwN2daQTBpdWZuK3hVUW45?=
 =?utf-8?B?ZDJ5MmR0a2lXSkJmV0hFV0s2Wm5ZdGlTbkd1dUk3K2Mzb0pDNzc1bHN3L1p3?=
 =?utf-8?B?YjVvOHlqMWRXOFg5eXRoYVhYaW9hWC9idTVPSmN1S1drSVVpMTNxckc2dm95?=
 =?utf-8?B?L2VDVDU0U3czT0cxb3h6eGMvNE96ODRqb1JHclFtVERuakUzSFNtWjIwMjBv?=
 =?utf-8?B?bi9HaFVpeGp5VFhDbGRQTFRpNDJoTFAwMHV6QXQxekxkZTNnY1VzTFgxN3Fl?=
 =?utf-8?B?bk9sNjVWMCtVVGo1MnVGMU5pZHh4YjlpYzFQalVLVysrWVoyUDNsMmhKMkFV?=
 =?utf-8?B?STQvVlNLbnFKNXZnUzlVUzFkZHdnTHBxOHNwaWdHNmxmeGhaWDFXaEduL1VX?=
 =?utf-8?B?K3kyZ3Zvc2N0b3FNMUZLK0wyUVdBTGlRUHE5MkZPd05LY1U5Z2dGdnIva1M4?=
 =?utf-8?B?WXZIRk9SMDlDVWhObEhQMXN3eGtpc01WQmlKbmhuQW11UUpzdUdiTkd1S3dB?=
 =?utf-8?B?bDdEOXBXekl3aDZWRE5FYTNBYlVYSXJzSEt6c0tWSGVsRWhYeEswZ1B4dk9Z?=
 =?utf-8?B?Q3l1QnhwaXhFSkxaZ3RNekIzRGdRcC9JTlk3emJUZFF0UjJUbm55UmpGVERl?=
 =?utf-8?B?Z1RjTU0xWURnTUI2RzU1R2ZneVZxWUxNeGFyYm5IMEZWdVVXTlpqWEticEZp?=
 =?utf-8?B?aWF5d0Z4bUNLMXk2SEdRQnNVbWozWmNTTEk0a0t6eXFGVHdEZTc1cGVhT3ZN?=
 =?utf-8?B?S3A0ekVGc2xJR3Fld0YxYVZEc0VvZjJ0WWtnQUJ5blJpbW0vc1M1WCtDeDlV?=
 =?utf-8?B?YVg4UVorVTFuTEN5L2VoYnhtSDh3SVJtYThWMU02d3JSTWRDajRHMjdnVGlS?=
 =?utf-8?B?bk9kdlNBYUF5L2JSbm14bmtyeGE5Q2NoZmh3aDd2RmNQQk40cG5zdEZuWTdM?=
 =?utf-8?B?enRyYTJ6NFdhdHdnR0pVZVA0RW1zWnRIeU51aTNMUmZlOW1NQkpubzRMZ0dl?=
 =?utf-8?B?K2JWYVRCTnlCbWs3YTJtcW0wM0VhbDM5SnN0NFFYVkZzQ21TU2xjNnFmYnBl?=
 =?utf-8?B?WFVjT3FIK1RWdFNGd0duVHpTKzBjWGR4a0R5SXo0RWR3dFRXK2tPSFlGTGtL?=
 =?utf-8?B?UU10S0J3Wk1iQWh3U2JCWkJYNmc4aFk3dE5GOWpTUFBoNDcxOFFaYUl3OUhz?=
 =?utf-8?B?OFN6THBtZW9FeHRkMHJtMVdGUDdBZC8xbm1hM3kyMlEzQS81V2lJQnc4Kzhz?=
 =?utf-8?B?cTErQUljQWg0eURPNnhiTFp2eGtQVnBBNEpsOGVDeWk0WTgrWU5la2xpOWpn?=
 =?utf-8?B?MTM4Q0VMNkhmNm8vcGdpN3hMNGFFTXltZWVrNXhzWWdoUWlwdnZyM2RGK0c2?=
 =?utf-8?B?eXRhZHUyWGQ4VjRoYVB4eUR5c2o2bWFQaDZTYnA2blpnNm1BOXY2YWFFK1JZ?=
 =?utf-8?B?KzhrZFV0N0NXU2hyVWRtdCtQNFVPbUY3ODVnMUUwR1JPdWdEZXFFeHdBVXZ5?=
 =?utf-8?B?OFM2c1kvNjlUcnZnL1Irekp1c1VuOUpCV00xUDNNTjRSYkF5aG1wRVhLZmpn?=
 =?utf-8?B?Y0ROZWt0Ym95ZlU5SjFVNzkvSUVka3U5NTBWMHBOdDZWUVNHbER6dThOK3Vr?=
 =?utf-8?B?ak8rbC9LWUJZN2hRTUpwZzJBdGhFV1JvSmtHcnQwR2MvdEN1VitzV1VXblRp?=
 =?utf-8?B?MGxJRndiaWxwRDNRUXFDTGduN2ZWT3hlcEluekhkdTZONzlwd2ZNcmo1OWZ5?=
 =?utf-8?B?c1hXRHNQeHVrTXdqZE5ZNGpVeTVqRE1VNUM4RXZpbkdoODlGNEhZK0tqUll0?=
 =?utf-8?B?WkU3RmZMZ1F1NWEvODU3VEZndW8xL3RuMU5XaEpPMnRWSy8rQzNlYzh5bXQ2?=
 =?utf-8?B?c3VpMytsbDdyaTEzZHpFU2ZXOUROM01ZUG9FZCsyL3B3WnQwc2xydXBqV0JM?=
 =?utf-8?B?U1NsWTZBLzFSeHU1cW9BQldDazBKczc5akR0djRhYkx2bXBRQ1doNEFCRFl0?=
 =?utf-8?Q?KiICy0FZLIuPZD9+VzHLxnESw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f159ab97-e4f8-4634-ada4-08dc2e42abe1
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2379.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 16:25:07.1371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d7Dg0IJBpusL/pmowmL8z+mQdYUet7Cmr+yM3MtQOKOVR1zV33PXTR/PTTSMA2wYInOCX5XFYnm4jKkGpl+fpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5163

Hello Thomas,

On 2/14/2024 2:33 AM, Thomas Gleixner wrote:
> This is a follow up on V5 of this work:
> 
>   https://lore.kernel.org/all/20240117115752.863482697@linutronix.de
> 
> and contains only the not yet applied part which reworks the CPUID
> parsing. This is also preparatory work for the general overhaul of APIC ID
> enumeration and management.
> 
> Changes vs. V5:
> 
>   - Fix the AMD leaf 0x8000008 parsing
>   - Update to generated CPUID leaf structures
>   - Address review comments (coding style, comments, changelogs, boot_cpu_has())
> 
> This applies on Linus tree and is available from git:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git topo-cpuid-v6

Tested the above tree comparing the values reported by
"/sys/kernel/debug/x86/topo/cpus/X" and
"/sys/devices/system/cpu/cpuX/topology/*" with those reported by
v6.8-rc4 on the following systems:

- Dual socket 3rd Generation EPYC System (2 x 64C/128T)
- Single socket 4th Generation EPYC System (1 x 96C/192T)
- Dual socket 4th Generation EPYC System (2 x 128C/256T)

Happy to report the values from the sysfs and debugfs with the series
are consistent with values on v6.8-rc4. "amd_node_id" and
"amd_nodes_per_pkg" introduced with the series are consistent with the
values reported in CPUID leaf 0x8000001E ECX on the respective system.

Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>

> 
> [..snip..]
> 

--
Thanks and Regards,
Prateek