Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbXLZTh5 (ORCPT ); Wed, 26 Dec 2007 14:37:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751597AbXLZTht (ORCPT ); Wed, 26 Dec 2007 14:37:49 -0500 Received: from mgw1.diku.dk ([130.225.96.91]:56179 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbXLZThs (ORCPT ); Wed, 26 Dec 2007 14:37:48 -0500 Date: Wed, 26 Dec 2007 20:19:13 +0100 (CET) From: Julia Lawall To: "H. Peter Anvin" Cc: autofs@linux.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc. In-Reply-To: <477293F3.60304@zytor.com> Message-ID: References: <477293F3.60304@zytor.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 29 On Wed, 26 Dec 2007, H. Peter Anvin wrote: > Julia Lawall wrote: > > From: Julia Lawall > > > > The functions time_before, time_before_eq, time_after, and time_after_eq > > are more robust for comparing jiffies against other values. > > > > More robust, how? You already almost introduced a bug here... I'm just summarizing the comment that goes with the definition of the time_after etc functions: include/linux/jiffies.h:88 /* * These inlines deal with timer wrapping correctly. You are * strongly encouraged to use them * 1. Because people otherwise forget * 2. Because if the timer wrap changes in future you won't have to * alter your driver code. * julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/