Received-SPF: pass (google.com: domain of linux-kernel+bounces-67411-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ff53b219-201d-4544-ab37-014286c299ae@intel.com>
Date: Thu, 15 Feb 2024 09:31:23 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net: stmmac: xgmac: fix initializer element is not
 constant error
Content-Language: en-US
To: Mark O'Donovan <shiftee@posteo.net>, <linux-kernel@vger.kernel.org>
CC: <alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <mcoquelin.stm32@gmail.com>, <netdev@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>
References: <20240212154319.907447-1-shiftee@posteo.net>
 <44c29a45-86fa-4e41-b4b5-e69187f0712e@intel.com>
 <867da21e-7f30-4caf-9f78-260d426e4186@posteo.net>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <867da21e-7f30-4caf-9f78-260d426e4186@posteo.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVNCQjNpMldSVFdwdVAvWG5qUURYYUFuSVZmY0VjUXNLQUUrd2dKN09nZjlK?=
 =?utf-8?B?MkMyTnRPd1VFS2dqaW1MN0FKbmh6QTVSRkxGcmxqQ3o1dlFWMDc0eTRVN05v?=
 =?utf-8?B?bEFLS0xsRlRjblQrMkE5MnFuRk8za0ZvRys2NVlET1BFb3I5K09lOEZPd2lC?=
 =?utf-8?B?Kzc5YnBabzJObncvcU00NVJFanJQQXgyWnNsc3dYek1wbjd0WWJJb0RjZ2E3?=
 =?utf-8?B?ODRJNjFySGlhS3ZOYmNFd1ZMSUZyMnhUeXVaRDNud0puQUhBUDVoVms1QUlz?=
 =?utf-8?B?d3hOM3VXcDNXT0FvblMvVDA5TkFTcDYzK0duVTlKSkhiOCtOR1VVVEVKcTdO?=
 =?utf-8?B?R0pmU1pSU2NXL1VtNE93ZXVSTlRoY2JUd2c2RmVpTzVsQkFkS2dvN1NvTDJ2?=
 =?utf-8?B?bHJhSnZXcWJ5YVlLMktrKy8xM0orZnBsZ1RqZWlwVDdoQnE1M0FsSDZVM3pZ?=
 =?utf-8?B?U1Vhd1BMaGg0OVRRWTdpTVczV1BSUFJQdVcxNXhGdWx2dFN4TE1PUTN2Uy9W?=
 =?utf-8?B?QmozTnRtQllqenZKTkMxTHBWSWtySktKQzkxeWtjSkxYZFZsM0RIRGEvK255?=
 =?utf-8?B?b3ZMMjlpQ1pJUGlrUUhId2MvYnF3RG9hTzNvcW5GVmN0NFpZM1d6OGU5a2gz?=
 =?utf-8?B?YXBhSEx3U01oa0N3UmNsR0ZRQkZiUmY0TkZINERGZnZiVGZ5RGxUNTA5eHZE?=
 =?utf-8?B?dmUwUm54bzA0R09BT09SVHpWalc0WkdPM0s5WVd0b1pvNDgvTHpaejZyRFow?=
 =?utf-8?B?b0pGak9ISVMydTNUbkQxdW5mQ0RHRVdzbVJ6eGNiRjdoZHRvVmtpekZoazVq?=
 =?utf-8?B?UEkwcm4zZUF1WFhDeURaRGs1aExieEpRZ0dIcVBJK1JoMWtsK2FRTHQvMzFa?=
 =?utf-8?B?OWc2dE0waUZYUVFKbmZoZEM5V2lURDYwWXRPSXp3ekVReWlaaDhXdFBsVlMy?=
 =?utf-8?B?ZjR2aGcreDZjUkdjYVVFalFJem52ZE4wWEtRL1hyTTV0VjErMzJVV0IxWW9P?=
 =?utf-8?B?STNLeGNJSnE2MGwyRENoZW5EMStCMFJ4OWprNXJMNVR5Nk9jYlRrZWJ2dCtB?=
 =?utf-8?B?NW05QkZiY2ZyNU14NmdsSXJiUmpyN2RGTjhvTlRlZnR6aU5GaU9pajlUNVNo?=
 =?utf-8?B?MkxqK3BvS2xLY1ZaUFVIZUNqVVBXOTdXOEptd1liUHhFckNxYTVyUENWL0h2?=
 =?utf-8?B?aWtuQ0ZsYlR6bGpsZkhCdzlkTzA0bkhwVytvdk9rNnFrZG1jdlhFSWRmNE9G?=
 =?utf-8?B?YjhpZHhWaUdMcHJScTBISmNramhnQXcrSW1WZFIzNU9pelVGV2NNYUorcWNS?=
 =?utf-8?B?T3N4TlgvNTd1QUtLZEppd01nU3N0SW5TejlwVkpBU2ZLVUI4dE5KM1FnQmQ3?=
 =?utf-8?B?cE4weUVVN3h3QlVMLzNkWnZqWlpLSmJvSnhsN3JXM252YnJ3SE1LaXY1TmlT?=
 =?utf-8?B?SFloV3R4amR3L0x2emgvb05tZzlrVGZBSFpPWWVJVzN4a3hvRG1ZWGpidWVs?=
 =?utf-8?B?MTlZbiswcTFJQmJ2RDdZQXFFNnYrYW9ITzFieHNqVmRzQUYzdVE1ci91TjZZ?=
 =?utf-8?B?aG9obkVRZXErSlJKeTRCL1NmaGhab1did2FWZFgrWlRCOHUydnh4WDNtQzNo?=
 =?utf-8?B?VEUycmE2a2NkQll3TnNCYlhaSUYwRHd0ZHVVVVEzZG9sYTVpRXhBNDZWUjds?=
 =?utf-8?B?b1pEamlGbkNQM0s3dlh1N2lyZ3g2T3pPU0YzcUN3eWtsVkltQVc4czBCU0hu?=
 =?utf-8?B?TVpoOVhrclo2aTZDY01SWFdqV3o2UjVKcXc5eXovWk80aGE5THljZGF4Zm5H?=
 =?utf-8?B?czhNUTFEdDlZOVl4V2ZOVkEvS2hHdnRDZWluL1Z5QVpUOS9jMU9PSFNlT2ZJ?=
 =?utf-8?B?djB1SWl2SExBK2R6bjFzb1dDK3krQS9nOHZWb2ZUNGpHdHY3UkI0YSt1NE9U?=
 =?utf-8?B?RkRYaW5iRHlPMEdzMS9pb0oyOTYzdHR6dUEzMnA3emcyZXovZVZwc0xQWlhO?=
 =?utf-8?B?cHh6dkljVDd5Qjc4SG5QNGVRc1gwMkROYUd3SzI5UU1RVTBTMUl4QysrL05j?=
 =?utf-8?B?ZVdNMlVCZEtSNmhNblJLT1lZcTBZREtpWWJoRG5VbDV1anZGd0VOdVVTeU1E?=
 =?utf-8?B?KzFCSjNVZEN6a0dOV1JFMjZMOG1MaDR6TmdCRi9rVjBtWTVCSmpaYUhlUEZ4?=
 =?utf-8?B?cXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 964a4f6d-07b7-4b5e-1781-08dc2e4bee5e
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 17:31:23.7401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aWLrpM6ZLtnVSb4xAHmGxdMc5OjYOZZECTFM6muerc8N/5N9n70pKtMoTaksOaenyGPB60ksoPz8kj2AR4CDgqTSuJbUAhwhAy9uNp54XYs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5362
X-OriginatorOrg: intel.com


On 2/14/2024 2:07 PM, Mark O'Donovan wrote:
> On 14/02/2024 20:31, Jacob Keller wrote:
>>
>>
>> On 2/12/2024 7:43 AM, Mark O'Donovan wrote:
>>> GCC prior to 8.x gives an "initializer element is not constant"
>>> error for the uses of dpp_tx_err in dwxgmac3_dma_dpp_errors.
>>> Newer compilers accept either version.
>>>
>>> More info here:
>>> https://lore.kernel.org/all/20240103-fix-bq24190_charger-vbus_desc-non-const-v1-1-115ddf798c70@kernel.org
>>>
>>> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
>>> ---
>>
>> I'm not sure whether the Linux kernel project has an explicit cutoff for
>> what versions of GCC (or other compilers) are supported. GCC 8 was first
>> released in 2018.
>>
>> The fix provided here is fairly straight forward, and while I do think
>> the benefit of using builtin types vs using the macros is nice, I don't
>> see that as a strong enough reason to hold up supporting the older compiler.
>>
>> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>>
>>>   drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
>>> index 323c57f03c93..c02c035b81c0 100644
>>> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
>>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
>>> @@ -830,8 +830,8 @@ static const struct dwxgmac3_error_desc dwxgmac3_dma_errors[32]= {
>>>   	{ false, "UNKNOWN", "Unknown Error" }, /* 31 */
>>>   };
>>>   
>>> -static const char * const dpp_rx_err = "Read Rx Descriptor Parity checker Error";
>>> -static const char * const dpp_tx_err = "Read Tx Descriptor Parity checker Error";
>>> +#define dpp_rx_err "Read Rx Descriptor Parity checker Error"
>>> +#define dpp_tx_err "Read Tx Descriptor Parity checker Error"
>>>   static const struct dwxgmac3_error_desc dwxgmac3_dma_dpp_errors[32] = {
>>>   	{ true, "TDPES0", dpp_tx_err },
>>>   	{ true, "TDPES1", dpp_tx_err },
>>>
>>> base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de
> 
> Thanks Jacob.
> 
> The minimum versions for compilers and other tools are documented here:
> https://www.kernel.org/doc/html/latest/process/changes.html
> 
> I am using a SLES 15 server to build, the first version of which came out in 2017.
> 
> Mark

Thanks for pointing this out, I failed to find it with grep. Useful to
have this as a reference.