Received-SPF: pass (google.com: domain of linux-kernel+bounces-67037-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 15 Feb 2024 15:57:58 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH v2 10/15] auxdisplay: linedisp: Provide a small buffer in
 the struct linedisp
Message-ID: <Zc4YZo8Pt5qA9R38@smile.fi.intel.com>
References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com>
 <20240212170423.2860895-11-andriy.shevchenko@linux.intel.com>
 <CAMuHMdVtqWBi4Y1tj74m4V4kp-3cFe_FphKKeY7zOkrbMVkKRg@mail.gmail.com>
 <Zc4Au5Q_rOAx7_4Y@smile.fi.intel.com>
 <Zc4BVIwpAqJYPuTH@smile.fi.intel.com>
 <CAMuHMdUR8i_08bz_B6HTzD4yx4URaC5aGG6byYNbmLmM0Gb4=w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMuHMdUR8i_08bz_B6HTzD4yx4URaC5aGG6byYNbmLmM0Gb4=w@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Feb 15, 2024 at 01:33:29PM +0100, Geert Uytterhoeven wrote:
> On Thu, Feb 15, 2024 at 1:19 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Feb 15, 2024 at 02:17:00PM +0200, Andy Shevchenko wrote:
> > > On Thu, Feb 15, 2024 at 11:40:44AM +0100, Geert Uytterhoeven wrote:
> > > > On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > +       linedisp->buf = buf ? buf : linedisp->curr;
> > > > > +       linedisp->num_chars = buf ? num_chars : min(num_chars, LINEDISP_DEFAULT_BUF_SZ);
> > > >
> > > > I think it would be safer to return an error if buf == NULL and
> > > > num_chars < LINEDISP_DEFAULT_BUF_SZ.
> > >
> > > I think you meant >= ?
> 
> Oops, yes/
> 
> > >
> > > > Else a careless driver that doesn't check linedisp->num_chars might
> > > > overflow the buffer.
> > >
> > > Okay, check has been added.
> >
> > Hold on, but I have min() being called, isn't it enough?
> 
> Yes you have.
> 
> A careless driver might not use linedisp->num_chars later, but instead
> just hardcode e.g. memcpy(linedisp->buf, source, LARGE_BUF_SIZE).

I see the point, yes, we need an additional check.

-- 
With Best Regards,
Andy Shevchenko