Received-SPF: pass (google.com: domain of linux-kernel+bounces-67414-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Zi Yan <ziy@nvidia.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 "\"Huang, Ying\"" <ying.huang@intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>,
 "\"Yin, Fengwei\"" <fengwei.yin@intel.com>, Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Johannes Weiner <hannes@cmpxchg.org>,
 Baolin Wang <baolin.wang@linux.alibaba.com>,
 Kemeng Shi <shikemeng@huaweicloud.com>,
 Mel Gorman <mgorman@techsingularity.net>,
 Rohan Puri <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>,
 Adam Manzanares <a.manzanares@samsung.com>,
 "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v5 2/3] mm/compaction: add support for >0 order folio
 memory compaction.
Date: Thu, 15 Feb 2024 12:32:37 -0500
Message-ID: <CA1FC23E-A652-4DD9-8E79-4956B2E11921@nvidia.com>
In-Reply-To: <6a011e7f-4e21-4e31-a9a2-52cba3181337@suse.cz>
References: <20240214220420.1229173-1-zi.yan@sent.com>
 <20240214220420.1229173-3-zi.yan@sent.com>
 <6a011e7f-4e21-4e31-a9a2-52cba3181337@suse.cz>
Content-Type: multipart/signed;
 boundary="=_MailMate_205074A5-792A-4557-9DAF-47AA18B14C18_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+PoENVJ0SNMNUQyzYMwQWvIah49jbfPieFh/5K9ewFlacjGKqsvv6FALPKa4?=
 =?us-ascii?Q?bUtDuWv51YJjfni/d5DhlTXIhtQys7Rvb1r4EW53kIq88tS6Y+UPQ8Ix7QeQ?=
 =?us-ascii?Q?14ANPl7tCLxgcRzy1NzT1AQHyWRmyl2b4cPUxdU13p5NABsGqAR5Rbw5ckNw?=
 =?us-ascii?Q?5GE0rM7HkDG2244oUFFts4mnvA2dKbEEAxM4409Efh3EoLmiz71mmYNkA04B?=
 =?us-ascii?Q?c8D3TIV6cQPeQQs8pji3IVLppTy43YW0kKXvSfXsb5/wA6KXazCnTvE3Bxnq?=
 =?us-ascii?Q?Xv/NXnrwAD1zbyRPjzTFE0XywwOUzjXFWTTtmz5zRmNnca6MifQ8JjRR6jd8?=
 =?us-ascii?Q?SzW89zw9kZAMbyPsKXbKvnHT0m5AQhP947Z4IoBbUlRcZr9rRd8UsDdStRVM?=
 =?us-ascii?Q?Mv6oDrB23B4CsUS+WnreFoaML7Dnrb5MiEMXJV/R9luNuI3d+vkzGV4RQeBm?=
 =?us-ascii?Q?fpbtDBFBgs4nvKTqel3FOgv4XP70OG6JCE37id3cXF6aA1lJAu/ppaxMQ7FE?=
 =?us-ascii?Q?X/gLZVne9RqAbgXfNlyxMufBJ9FQIdu6AfbpJUiZfiLX0NPfud4txQpBYvn+?=
 =?us-ascii?Q?+fRVPtCgBUWvvjO5AZ0xPdOBwxOCBJ1HHVw3Z39BSpVnxcnGsi2vrtnSbQdC?=
 =?us-ascii?Q?0RkeyafV2RljxRXP+j4pqzkCArewlg0SEbcLFSNF/RLY9OUMoSDQGTU4LWQJ?=
 =?us-ascii?Q?HZx5NsznELGp8cNzl+taREZCIPCwK9cwW60PrBa9qSJ+/3FokVZ9PWAabstK?=
 =?us-ascii?Q?nzM38hXXxOZIYgR6OZQtWLd+ZM/PiMcgWTsRukux5nhnOeE3VGHO2VIUaETn?=
 =?us-ascii?Q?4TSpjStcD8frB53I0siXrMttcJNXom/mSWe7KuVQODOPzxEeumtsPhYF33IV?=
 =?us-ascii?Q?ufSKpWI8qr2P6khOaJQ9ez7FExXk6v9K5G3Yw6nNvCsj5qQz0IqTZ7p6H0rC?=
 =?us-ascii?Q?CbNUqkJOxa74zbtZPL4Mva20TSwvIq6LGeUmdq1566uMa2uVznnZN1twCJSn?=
 =?us-ascii?Q?ttdjH+iGtftXORAiYSUDPjJK47Q9BP4whTtg+WsdLAjTQiy1LPfsvAKDCNyz?=
 =?us-ascii?Q?tovCGR0kMTtMA1M7tEuPfsPOvmsKzWZZX4yaqVTf/NFXzdcFZ/d2Nb+y438V?=
 =?us-ascii?Q?RimViVKp3j2HGRhHlMr9vEtPu0xWU8yx4kXkKEXlUfW4Tsa9pBxeSQnYoTO2?=
 =?us-ascii?Q?/SWqilfqwXuZ4wWSZN7fxFQTZhTiJmW2piLY/HUl4Znd06UlBEFdysieKdwf?=
 =?us-ascii?Q?awpr2cH9+TEqG4JyLz6pZXLvWH+MRlFBwnW7YBkUGb1KzQMTmHSHanoS0rbu?=
 =?us-ascii?Q?4AeQSTx4fbRmWvzGyi/X5w91Uz5zPgPwF3/MYsKl3Smtd4uQX/Uo4ia913/q?=
 =?us-ascii?Q?whuKIcVu3LYFlFCtLulaVCvk3UeHEIoLMuJ/OYHvYjMIkRKw/qT8LtEAmh9R?=
 =?us-ascii?Q?AG7ikD7F+dtDNQGhtcphQqu6emHrzTYC8S7ZLzJK0fEhJSXrec3YRTfeuyO2?=
 =?us-ascii?Q?ZGUFN7J5ptanP1nrLcJ4sTs5W3Co3e87eGBO4A4QHDomFfypHTWkjxiHZMkZ?=
 =?us-ascii?Q?4uEMIq+G64UEA9MtuegAQEcKiHql3+nehWJyXzDK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3112a652-00f5-45ac-1dbf-08dc2e4c1c0d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 17:32:40.5472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1D2iLpT0HoLCQ73bmfaY8eORxcDLCo75JOkOsrRAS8xhLWJRcifrMSH6gSTZ4a5y
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4221

--=_MailMate_205074A5-792A-4557-9DAF-47AA18B14C18_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 15 Feb 2024, at 11:57, Vlastimil Babka wrote:

> On 2/14/24 23:04, Zi Yan wrote:
>> @@ -1849,10 +1857,22 @@ static struct folio *compaction_alloc(struct f=
olio *src, unsigned long data)
>>  static void compaction_free(struct folio *dst, unsigned long data)
>>  {
>>  	struct compact_control *cc =3D (struct compact_control *)data;
>> +	int order =3D folio_order(dst);
>> +	struct page *page =3D &dst->page;
>> +
>> +	if (folio_put_testzero(dst)) {
>> +		free_pages_prepare_fpi_none(page, order);
>> +
>> +		INIT_LIST_HEAD(&dst->lru);
>
> (is this even needed? I think the state of first parameter of list_add(=
) is
> never expected to be in particular state?)

There is a __list_add_valid() performing list corruption checks.
>
>>
>> -	list_add(&dst->lru, &cc->freepages);
>> -	cc->nr_freepages++;
>> -	cc->nr_migratepages +=3D 1 << folio_order(dst);
>> +		list_add(&dst->lru, &cc->freepages[order]);
>> +		cc->nr_freepages +=3D 1 << order;
>> +		cc->nr_migratepages +=3D 1 << order;
>
> Hm actually this increment of nr_migratepages should happen even if we =
lost
> the free page.

Because compaction_free() indicates the page is not migrated and nr_migra=
tepages
should be increased regardless.

Will fix it. Thanks.

>> +	}
>> +	/*
>> +	 * someone else has referenced the page, we cannot take it back to o=
ur
>> +	 * free list.
>> +	 */
>>  }


--
Best Regards,
Yan, Zi

--=_MailMate_205074A5-792A-4557-9DAF-47AA18B14C18_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXOSrUPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUSIAQAJEvcVHhEFlZmeB/Y6ktqtrrE610TjJAWxSX
xdSZg+jo32D1FtrbcdaofYxbUvmqHHCFDR+KIZTLXni4iT/49L/PgYSgOTs6Pktc
dEPBnGjuM3E2tQds0FeD+iCxyIliDAdw8o2RlTvdhtU/8XBvTWSJGPB6qFtajGGs
xHSD+MsPNKd0Ju8eLRFbJxjE5/kbczVYEb33oL5NSZC2/JkCiqnf7JD+FBWXHqT6
AH+uuECA3LLHeYdh/Q+S3wsZiXeFsfPXzhSIWU6DWRj3Re/URCytHHYFFn3QcEXK
cwH9SjYJdLrL6/AElVJuiEtAElEMKJga296H1IMmVL0SfEx6X/D98Gjm+U3nrZ+b
Q/fDLcXQHvJr+V+zourb4qQucmtkB3IP7NUPt73Axd086xQKUgS9wJhk9eOlc4fE
nUQUsiwyO0+Mx1WrHQFMHcFs4ZGSRhZ0SbLXcfbHE4/JrgL2NhWWFruBME09z4G+
nlRrlq9Yl0V1A/RkxqVWOu5Z+XjVGU3RAE9zRHEvnz9b0RRCt8OtCRYs4ZENNMYK
rDfQd4Kqkh7vnQ2/LeST93OE8xyOHxqilaXefm9C+6Pnx3GTt15Ycy9UCbqV9mQP
dgBa/vl1zxRkoYXLH9ZeNCG5H/2GeN7BwNrkui+/EbiRTPEhmUuU5R3QX81SB8Lu
pwip5S20
=7clm
-----END PGP SIGNATURE-----

--=_MailMate_205074A5-792A-4557-9DAF-47AA18B14C18_=--