Received-SPF: pass (google.com: domain of linux-kernel+bounces-67473-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240210175530.137361-1-clamor95@gmail.com> <20240210175530.137361-2-clamor95@gmail.com>
 <Zc5QANGhS8EPvgEy@google.com>
In-Reply-To: <Zc5QANGhS8EPvgEy@google.com>
From: Svyatoslav Ryhel <clamor95@gmail.com>
Date: Thu, 15 Feb 2024 20:09:35 +0200
Message-ID: <CAPVz0n3DA6PiJOhkX-0Lk1QXjaKa9NkLkDRkV85Z3S2S5S8Ogg@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] input: touchcreen: tsc2007: make interrupt optional
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	Benjamin Bara <benjamin.bara@skidata.com>, Richard Leitner <richard.leitner@linux.dev>, 
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=D1=87=D1=82, 15 =D0=BB=D1=8E=D1=82. 2024=E2=80=AF=D1=80. =D0=BE 19:55 Dmit=
ry Torokhov <dmitry.torokhov@gmail.com> =D0=BF=D0=B8=D1=88=D0=B5:
>
> Hi Svyatoslav,
>
> On Sat, Feb 10, 2024 at 07:55:30PM +0200, Svyatoslav Ryhel wrote:
> > In case tsc2007 is used as an ADC sensor there will be no interrupt
> > provided at all, so set up an interrupt only if one is present and
> > remove associated warning.
>
> If we want to do this, we should better handle the input device portion
> of the driver. We have 2 options:
>
> - switch the input device into polling mode when interrupt is absent
> - do not create input device
>
> Those do not need to be mutually exclusive (i.e. we could use absence of
> both device tree interrupt property as well as lack of poll-interval
> property to suppress creation of the input device and only leave iio.
>
> Thanks.
>

I do not care about input part and suppressing it is perfectly fine for me.
Which implementation would be accepted?
I suppose I may isolate input device creation into separate function and
add check for interrupt or poll-interval. If both are not present then inpu=
t
device creation will be skipped. Will this be sufficient?

> --
> Dmitry