Received-SPF: pass (google.com: domain of linux-kernel+bounces-67465-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Praveen Kannoju <praveen.kannoju@oracle.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
CC: "andy@greyhouse.net" <andy@greyhouse.net>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rajesh
 Sivaramasubramaniom <rajesh.sivaramasubramaniom@oracle.com>,
        Rama
 Nichanamatlu <rama.nichanamatlu@oracle.com>,
        Manjunath Patil
	<manjunath.b.patil@oracle.com>
Subject: RE: [PATCH RFC] bonding: rate-limit bonding driver inspect messages
Thread-Topic: [PATCH RFC] bonding: rate-limit bonding driver inspect messages
Thread-Index: AQHaXwBJpRniMP9JNU66kt9+kpIT0bEKKuqAgAGI0CA=
Date: Thu, 15 Feb 2024 18:03:04 +0000
Message-ID: 
 <SA1PR10MB64450CA1D56F8873331615BC8C4D2@SA1PR10MB6445.namprd10.prod.outlook.com>
References: <20240214044245.33170-1-praveen.kannoju@oracle.com>
 <7713.1707935675@famine>
In-Reply-To: <7713.1707935675@famine>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?eNB2lj3eJPoGmLbSn6+HtQVT0caEGVD0ZD+4Cu25PF6RcjqBRgtWYlusbEi2?=
 =?us-ascii?Q?cKSlNBGYltG5JJJMNSBSQ60fIDB66gLhIgwS6D6Qv0g0MmtJANXFot+se00+?=
 =?us-ascii?Q?n3VQJShTUilP/myA0hwUG4eSRnOHC2nL65kUmL0WOs6pP+yzHORgJDF1WKVH?=
 =?us-ascii?Q?QMHCyUsztKk2QeMzgEVtrJk9L9WX3AdhRs6EYQ86fJmbCIaL2X03sDarwDtx?=
 =?us-ascii?Q?4k3t8608SKPzcjO2m3XAlsHc4pODxfxVQSkLS7V9cnmcuDN2DqaC+2GE9c+h?=
 =?us-ascii?Q?izISV/F7M+ZqcljRG7QZ2zueZTUtWRwgRKMzxv1L0P+4S64SK8viKQykME8b?=
 =?us-ascii?Q?vJv9GZDCWAAvioJ2HIkpa8SAOwCv+xbWe71dEOG3TxCOmmoUCRF7ZEAk/ZGa?=
 =?us-ascii?Q?AglcDIudQ3bsc+su0uRrdlsKS5hr+yVA1gSfUfhWkMbBv2qMR3/AZ7nyKP/+?=
 =?us-ascii?Q?+jFhjgmwpH8gPfHT2kfS4y+GGAXFKkgY8UzZ3258785tTdmySEdnmXpxZxJb?=
 =?us-ascii?Q?F3VTeZJhe3jNOijYV32k3Qeo72zwLH3Fp2KK+Dzz70aIC2M+LhZ7kGD+iyjs?=
 =?us-ascii?Q?s76K6Dd8/BlPf1BgNJQyab76FLfQ+cThOb0OULYjiWCabqzVLDcQ42lpsxfH?=
 =?us-ascii?Q?BGuuvkU4PYJjhjw4jYas33vzy7ZkdVQlPw9UOE/O3+Q8F2I5mWj8Qs6Fcc4g?=
 =?us-ascii?Q?4t3QzhmTNhsP7hwDDbSrbyS9FK/8Zvf1SgVvJ4MNThE94J2X8nDqbfiCxzCD?=
 =?us-ascii?Q?en1CB5qBNDg5Xlwu2E9I0ymC/5lmHKCc3oTT/wNUQe/LLHhwGrBkisrHOyzA?=
 =?us-ascii?Q?l9gil27ncG1RkuweivInfqBYLG7XOOMCSe7ZSGvzMnOY/5Fj8/c5l88w+fsm?=
 =?us-ascii?Q?0LI0FVSqTnKssoo7QreEaq3UgUqRsJ9SFQyteKnhqFTjOuojJ20ENRPou1l1?=
 =?us-ascii?Q?W8O0vDQ59bmElnFhMklhYoFLuRsLre8h0Nw+CedJI2hTw/r7T4GZycL3t6Ae?=
 =?us-ascii?Q?3Ia8uhrKq/JFhMfpW6y30+4qg8vR4q9ap6dOzV2uc5VIMMCw+34PoqOUstM3?=
 =?us-ascii?Q?k3UmDi7kVxbhDnCenX7rOcRrok21ZSyzl+zIOmyPoheGH4kEKL9attb+R+Xy?=
 =?us-ascii?Q?oGgFaowP2E9LGVQNK5UmkPMToUbBQJdVcw1+oQ6c+H6OZd3Rj8J8vqNoBtwh?=
 =?us-ascii?Q?g6dMmsPPRuTDFxvQ6ZmJYKPKNHGvRX7eF+gHFl3UpAQPEbRKSgv+pOIoiTQW?=
 =?us-ascii?Q?CpT/ws/I/Upa+oExH1us6iQHhn1F3c+WyeBg5+p8MJIP6iH+XEKAoUlL0iEJ?=
 =?us-ascii?Q?eh1fOUn8GBqGhp2z6vtq4zAafRRhiZzFP0DTz4dKv1V3H1l/RhPwYnNvfwsO?=
 =?us-ascii?Q?dTPlLiOJfPNJlSshOBR0yOmnNlxxbEvwViVjnRdBbT8otAWnVdRFRwSV9Ubm?=
 =?us-ascii?Q?oBkKrnBRtAnLttRr2OR43CQJyQTJBtgS+g0s4qMWl2OSRs03PkjE5lPUQrOE?=
 =?us-ascii?Q?MR4kDs7Ix0YcLQoTyrf2D9688zGzcyiYB0ZNvFW6memcpgS4KOYJJH3IKk7X?=
 =?us-ascii?Q?+92sYAwEhlGTsnKseIiDW234dKIBFKUhLyqhIyPx?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	GigghutEUAAfUhEOCE98jK0HzLlPLDCdMkj3sTtruXplcbNjelrAnvz1pWnuHmfJux6XWlanVIiDgXrrci/LxhWqtYnOKogHvrYGpxSuuEyYtBn8NR/Xb+V2XiQ3vIi8OrnbIOkBN9cAATiXkovOnITtNdlWDCaeeT3j11AYloAaQr5mKhhwHMryd6+HjwxGekodWzVUoSONBSZqXZshNFW3CpP5JoMqz9xWbYqSAiNo77yzGvdieHN61DUxuEie4JGESGYy8Z0axLDxzLdRj3O1poH9j5o+Ovz1PXmstYJ3q+izMHSbtz4pP6h80t/NiOMnDGB5DxLnMvrSETThRIiE8IG7XcbR8G8SYEGwhM+P4FsnHk6xXFMnfl3VhV4lMJc27VbrXGYGtdBjhxe0fErI6xvtSqlrGSdkFl4bsTQ8lj5UsFDTA/kuOwiQ6nXIxwQi5dntDZgDbYW9lTGdJwlRq6oBQSvKGwdUs+x5P6L9r2jmrDiIQlJe3RZ3sHb1nwYFpSTaKL4m7e+1Du9gsTTOEIZj5gitg14qBhDwh2rQEs9buwja7VSiscpcNrn3XJHF1b0xWqFBQ7tnvUvUQhK7g9w+5k3/iwTgI8uz2u4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB6445.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1db4926-c8d8-4871-de35-08dc2e505bac
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2024 18:03:04.6689
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZWy4tGJzVk/xf9T9KS2FouvGk4iViPTtUd29SVCuuy8bFLRvJ0nV/6nG15TLfABmC4hqAigFHPIbfLaFCpFiZaDaANLDTjYi0QSf+2Cz6A0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6500
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-15_16,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 suspectscore=0 mlxscore=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402150145
X-Proofpoint-ORIG-GUID: MxZrfzNWF3_4eveI0a2jmUvYIhyb1Ahx
X-Proofpoint-GUID: MxZrfzNWF3_4eveI0a2jmUvYIhyb1Ahx


> -----Original Message-----
> From: Jay Vosburgh <jay.vosburgh@canonical.com>
> Sent: 15 February 2024 12:05 AM
> To: Praveen Kannoju <praveen.kannoju@oracle.com>
> Cc: andy@greyhouse.net; davem@davemloft.net; edumazet@google.com; kuba@ke=
rnel.org; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Rajesh Sivaramasubr=
amaniom <rajesh.sivaramasubramaniom@oracle.com>;
> Rama Nichanamatlu <rama.nichanamatlu@oracle.com>; Manjunath Patil <manjun=
ath.b.patil@oracle.com>
> Subject: Re: [PATCH RFC] bonding: rate-limit bonding driver inspect messa=
ges
>=20
> Praveen Kumar Kannoju <praveen.kannoju@oracle.com> wrote:
>=20
> >Rate limit bond driver log messages, to prevent a log flood in a
> >run-away situation, e.g couldn't get rtnl lock. Message flood leads to
> >instability of system and loss of other crucial messages.
> >
> >Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
> >---
> > drivers/net/bonding/bond_main.c | 34 +++++++++++++++++++---------------
> > include/net/bonding.h           | 11 +++++++++++
> > 2 files changed, 30 insertions(+), 15 deletions(-)
> >
> >diff --git a/drivers/net/bonding/bond_main.c
> >b/drivers/net/bonding/bond_main.c index 4e0600c..32098dd 100644
> >--- a/drivers/net/bonding/bond_main.c
> >+++ b/drivers/net/bonding/bond_main.c
> >@@ -2610,12 +2610,13 @@ static int bond_miimon_inspect(struct bonding *b=
ond)
> > 			commit++;
> > 			slave->delay =3D bond->params.downdelay;
> > 			if (slave->delay) {
> >-				slave_info(bond->dev, slave->dev, "link status down for %sinterface=
, disabling it in %d ms\n",
> >-					   (BOND_MODE(bond) =3D=3D
> >-					    BOND_MODE_ACTIVEBACKUP) ?
> >-					    (bond_is_active_slave(slave) ?
> >+				bond_info_rl(bond->dev, slave->dev,
> >+					     "link status down for %sinterface, disabling it in %d ms\n",
> >+					     (BOND_MODE(bond) =3D=3D
> >+					     BOND_MODE_ACTIVEBACKUP) ?
> >+					     (bond_is_active_slave(slave) ?
> > 					     "active " : "backup ") : "",
> >-					   bond->params.downdelay * bond->params.miimon);
> >+					     bond->params.downdelay * bond->params.miimon);
>=20
> 	Why not use net_info_ratelimited() or net_ratelimit()?  The rest of the =
bonding messages that are rate limited are almost all
> gated by the net rate limiter.
>=20
> 	-J

Thank you for the reply, Jay. Yes, I agree. Used net_ratelimit() and resent=
 the v2 patch. Please review and provide your comments.

>=20
> > 			}
> > 			fallthrough;
> > 		case BOND_LINK_FAIL:
> >@@ -2623,9 +2624,10 @@ static int bond_miimon_inspect(struct bonding *bo=
nd)
> > 				/* recovered before downdelay expired */
> > 				bond_propose_link_state(slave, BOND_LINK_UP);
> > 				slave->last_link_up =3D jiffies;
> >-				slave_info(bond->dev, slave->dev, "link status up again after %d ms=
\n",
> >-					   (bond->params.downdelay - slave->delay) *
> >-					   bond->params.miimon);
> >+				bond_info_rl(bond->dev, slave->dev,
> >+					     "link status up again after %d ms\n",
> >+					     (bond->params.downdelay - slave->delay) *
> >+					     bond->params.miimon);
> > 				commit++;
> > 				continue;
> > 			}
> >@@ -2648,18 +2650,20 @@ static int bond_miimon_inspect(struct bonding *b=
ond)
> > 			slave->delay =3D bond->params.updelay;
> >
> > 			if (slave->delay) {
> >-				slave_info(bond->dev, slave->dev, "link status up, enabling it in %=
d ms\n",
> >-					   ignore_updelay ? 0 :
> >-					   bond->params.updelay *
> >-					   bond->params.miimon);
> >+				bond_info_rl(bond->dev, slave->dev,
> >+					     "link status up, enabling it in %d ms\n",
> >+					     ignore_updelay ? 0 :
> >+					     bond->params.updelay *
> >+					     bond->params.miimon);
> > 			}
> > 			fallthrough;
> > 		case BOND_LINK_BACK:
> > 			if (!link_state) {
> > 				bond_propose_link_state(slave, BOND_LINK_DOWN);
> >-				slave_info(bond->dev, slave->dev, "link status down again after %d =
ms\n",
> >-					   (bond->params.updelay - slave->delay) *
> >-					   bond->params.miimon);
> >+				bond_info_rl(bond->dev, slave->dev,
> >+					     "link status down again after %d ms\n",
> >+					     (bond->params.updelay - slave->delay) *
> >+					     bond->params.miimon);
> > 				commit++;
> > 				continue;
> > 			}
> >diff --git a/include/net/bonding.h b/include/net/bonding.h index
> >5b8b1b6..ebdfaf0 100644
> >--- a/include/net/bonding.h
> >+++ b/include/net/bonding.h
> >@@ -39,8 +39,19 @@
> > #define __long_aligned __attribute__((aligned((sizeof(long)))))
> > #endif
> >
> >+DEFINE_RATELIMIT_STATE(bond_rs, DEFAULT_RATELIMIT_INTERVAL,
> >+		       DEFAULT_RATELIMIT_BURST);
> >+
> >+#define bond_ratelimited_function(function, ...)	\
> >+do {							\
> >+	if (__ratelimit(&bond_rs))		\
> >+		function(__VA_ARGS__);			\
> >+} while (0)
> >+
> > #define slave_info(bond_dev, slave_dev, fmt, ...) \
> > 	netdev_info(bond_dev, "(slave %s): " fmt, (slave_dev)->name,
> > ##__VA_ARGS__)
> >+#define bond_info_rl(bond_dev, slave_dev, fmt, ...) \
> >+	bond_ratelimited_function(slave_info, fmt, ##__VA_ARGS__)
> > #define slave_warn(bond_dev, slave_dev, fmt, ...) \
> > 	netdev_warn(bond_dev, "(slave %s): " fmt, (slave_dev)->name,
> >##__VA_ARGS__)  #define slave_dbg(bond_dev, slave_dev, fmt, ...) \
> >--
> >1.8.3.1
> >
> >
>=20
> ---
> 	-Jay Vosburgh, jay.vosburgh@canonical.com