Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037AbXLZUnR (ORCPT ); Wed, 26 Dec 2007 15:43:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751716AbXLZUnF (ORCPT ); Wed, 26 Dec 2007 15:43:05 -0500 Received: from relay1.sgi.com ([192.48.171.29]:41978 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751401AbXLZUnE (ORCPT ); Wed, 26 Dec 2007 15:43:04 -0500 Date: Wed, 26 Dec 2007 12:43:01 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Linus Torvalds cc: Al Viro , linux-kernel@vger.kernel.org Subject: Re: tlb_finish_mmu() bogisity In-Reply-To: Message-ID: References: <20071223093241.GR8181@ftp.linux.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1440 Lines: 32 Argh. This is indeed bogus. The one reporting the problem states that the patch did not address the issue. The report was regarding pgd freeing which is handled slightly differently from pte frees. [PATCH] Revert quicklist need->flush fix Did not fix the reported issue. Apart from other weirdness this causes a bad link between the TLB flushing logic and the quicklists. If there is indeed an issue that an arch needs a tlb flush before free then the arch code needs to set tlb->need_flush before calling quicklist_free. Signed-off-by: Christoph Lameter Index: linux-2.6/include/asm-generic/tlb.h =================================================================== --- linux-2.6.orig/include/asm-generic/tlb.h 2007-12-26 12:26:32.000000000 -0800 +++ linux-2.6/include/asm-generic/tlb.h 2007-12-26 12:26:39.000000000 -0800 @@ -86,9 +86,6 @@ tlb_flush_mmu(struct mmu_gather *tlb, un static inline void tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end) { -#ifdef CONFIG_QUICKLIST - tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0; -#endif tlb_flush_mmu(tlb, start, end); /* keep the page table cache within bounds */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/