Received-SPF: pass (google.com: domain of linux-kernel+bounces-67549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Michael Kelley <mhklinux@outlook.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>, "haiyangz@microsoft.com"
	<haiyangz@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>,
	"decui@microsoft.com" <decui@microsoft.com>, "corbet@lwn.net"
	<corbet@lwn.net>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-doc@vger.kernel.org"
	<linux-doc@vger.kernel.org>
Subject: RE: [PATCH 1/1] Documentation: hyperv: Add overview of PCI pass-thru
 device support
Thread-Topic: [PATCH 1/1] Documentation: hyperv: Add overview of PCI pass-thru
 device support
Thread-Index: AQHaX5zLjfItck7t3UmPns+zVTEYbrELvbYAgAAFLlA=
Date: Thu, 15 Feb 2024 19:04:17 +0000
Message-ID:
 <SN6PR02MB4157798C452BD3D01E784CADD44D2@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <20240214232253.4558-1-mhklinux@outlook.com>
 <d75a2788-b8dc-46cc-b8ca-a740a1fb74f5@linux.microsoft.com>
In-Reply-To: <d75a2788-b8dc-46cc-b8ca-a740a1fb74f5@linux.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?jMJ+R00CZ2c1nl34CSoJXwgLvnQCyQKMZUnYALqAxr00hiAhlOUHtAadelOj?=
 =?us-ascii?Q?TIF6dhfgZ34kiB+qfrUs3SH35pJVB9krLLCAa0N3YPAhPv4XsB6VDYMZ1wx0?=
 =?us-ascii?Q?KDuP8WAAmeyblnVhZU7k+R//+x/FM+BN6rD4w6WVosNSVhOSP5tyFJZsEPAE?=
 =?us-ascii?Q?gbgcfDRv31HFvLhibSLlTjx7PIlfKkSMags11tmpZtoTxPrc3sfDAGdxwzOK?=
 =?us-ascii?Q?XanBZZLQroxDQ4a8FS1NuoPVwKzRKFBRZB/UBvJuA2pnb97Bhyh10OUPPhOz?=
 =?us-ascii?Q?qB5X8I1l6Pp9K6svBhF726/eMGVmQmVGiQVQeustxQ8sHgOADGR9abKMjtnN?=
 =?us-ascii?Q?Vhw4htTHRgp15RQi49rlKqn2LhX8LpYPYCirKNNg4soMlbCB8mklkxfceMvO?=
 =?us-ascii?Q?kXVIos5BpqJxe3k7ddhPnnem7yl6KI2WwYZ/yHlTr4XroJ3SJQoo5OiwyFKR?=
 =?us-ascii?Q?lRIG0umBWXcQ4qv6BQf7HNElXSVEgn9Y8vnmdvXu7RB8XC+lpLH2R61eSO9q?=
 =?us-ascii?Q?/dz2L4K9DxMQ9V6Z0IdFpvCKi2YxIfN3Ry3chieatFwD57c31nbnBrzMrC8a?=
 =?us-ascii?Q?y0JcEPgVEzgWFtVAI8fCj/MGxa8eZV04vVNbVRua23885fD3qdeMdns+wf7R?=
 =?us-ascii?Q?WXfQ4TpAZrtCmT/U45/z8R30DL1ZGajcwgAvPwZcIClfj2ZZPiM0ILu6UCMP?=
 =?us-ascii?Q?zQQJo1KLzSJ5e1mmG3eA3UMvxLokDoins+XKIwewHS3wMk5ySLob5hsiHtnJ?=
 =?us-ascii?Q?oqwHgJr51/Rjl+K1KZJALdN2LaDD6FSYe6ohS7TPi7rr3KFX716YSLulUt+0?=
 =?us-ascii?Q?4pH3/PdBMIctqa3Oy5JjMf3HszbW00onIwbbY9WvCwR28M97njRupI1KTYeX?=
 =?us-ascii?Q?D5XFI5+vEjQZYJggU+I98SP5/zB9QFooDOhhLXUuc6Fkryoz0MpRQZV9UKmq?=
 =?us-ascii?Q?le7ZBIbUnmXyHDBRgI9bhwyrOGcmEOQ7hOaJ49hJMnV1PVujVji9l6xZdPdx?=
 =?us-ascii?Q?mFFPGIo2VNvdfsRdhXc23o1K/9jxmBxw2OvpkbN8DPyUqOyucWuTHMOofHeV?=
 =?us-ascii?Q?KGIQW4jSp3zI1YAe87pV7+M2qSXdByTnLPwCmQIQwnKkFrU8qTMvqvxfjgyh?=
 =?us-ascii?Q?+PHxE640uTFYrsFwbtSitR/azYzrl+fqiNrBTOyXLPIJNu7pQWHcJRf5o17g?=
 =?us-ascii?Q?obhJdD49Dkyav1VJ4uv8IsK3IfdK6F/xtc2wc+7qFfUVzm0dac1SPNvN3ZI?=
 =?us-ascii?Q?=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 23e1f20c-3691-4843-19f7-08dc2e58e8c4
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2024 19:04:17.6818
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR02MB10135

From: Easwar Hariharan <eahariha@linux.microsoft.com> Sent: Thursday, Febru=
ary 15, 2024 10:41 AM
>=20
> On 2/14/2024 3:22 PM, mhkelley58@gmail.com wrote:
> >
> > Add documentation topic for PCI pass-thru devices in Linux guests
> > on Hyper-V and for the associated PCI controller driver (pci-hyperv.c).
> >
> > Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> > ---

[snip]

> > +
> > +With this approach, the vPCI device is a VMBus device and a
> > +PCI device at the same time.  In response to the VMBus offer
> > +message, the hv_pci_probe() function runs and establishes a
> > +VMBus connection to the vPCI VSP on the Hyper-V host.  That
> > +connection has a single VMBus channel.  The channel is used to
> > +exchange messages with the vPCI VSP for the purpose of setting
> > +up and configuring the vPCI device in Linux.  Once the device
> > +is fully configured in Linux as a PCI device, the VMBus
> > +channel is used only if Linux changes the vCPU to be
> > +interrupted in the guest, or
>=20
>=20
> > ..............................if the vPCI device is removed by
> > +the VM while the VM is running.
>=20
> This seems to conflict with the statement called out below. Did you
> mean to say "if the vPCI device is removed *from* the VM..."?
>=20

Oops!  Yes, that should be "from the VM".

[snip]

>=20
> Otherwise, FWIW
>=20
> Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>=20

Thanks for reviewing and spotting that error.  I'll see what
other comments accumulate and then send out a v2 with
updates.

Michael