Received-SPF: pass (google.com: domain of linux-kernel+bounces-67556-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Brian Cain <bcain@quicinc.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
        "linux-kbuild@vger.kernel.org"
	<linux-kbuild@vger.kernel.org>
CC: "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
Thread-Topic: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
Thread-Index: AQHaYBhjk5QXHtSJRECy3JJhSYFt/rELxaaQ
Date: Thu, 15 Feb 2024 19:12:38 +0000
Message-ID: 
 <CH3PR02MB102474087819FEC83FA6C08AEB84D2@CH3PR02MB10247.namprd02.prod.outlook.com>
References: <20240215140702.1910276-1-masahiroy@kernel.org>
In-Reply-To: <20240215140702.1910276-1-masahiroy@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Z6TTiQxZT93Mdw2JBAa7Q+r8DSvtV43DCb36RanlRdXmhqI8QQW9AyPPAtfR?=
 =?us-ascii?Q?KILP8y5vQrsXTYQA+5k2IjrHE6AIYbOu5YWY0MR8dKzOu7n9FRbAM00wff2Z?=
 =?us-ascii?Q?9p6hRm8ytwmU7J2m2fm2H5tCG5RxNuIo12HYk38V5De0XYdEtXj+eBb8uNxE?=
 =?us-ascii?Q?xGLjjurLpEkNORAtAMUmJXKygp7UlZDwNF223BI50X2ihKWoV5b8gu399B3X?=
 =?us-ascii?Q?C5YZMB1TMF/wk9NaqcMIEg0gqfpZnJLi58rsHq1Ap2oh0vs+nSkN/gADX+kP?=
 =?us-ascii?Q?3gOPZ5JKjg2KqBwbNjLQVnMTu4+73owFr5FMxsRQoTdZLlXHruBOn+sO/srl?=
 =?us-ascii?Q?5olSJiUCBJ57oRy+L4QUNEg5oT6jTti5Fz9uT4J7rJwCIZel3nARo3FBPMrw?=
 =?us-ascii?Q?i5mzDgYue8BwFknQqbwG26Wl0YzKpciEmiz6CaXd9xLhQpuHLnmJtBkUD0rM?=
 =?us-ascii?Q?SIseCSLsm+9Yl40ZcPRGjr0ThZ1QRC31Wooqa6pD8qSIhutSRFXVp7cntG0p?=
 =?us-ascii?Q?KuPv7NuQKkk/yJB634kWJ8faqcn+K6kPHatBw6sC3Fx3bjL8Wt6QROjDQiMv?=
 =?us-ascii?Q?fDC13rOwst0Hw/2nFLa3aHni+4+uvuMmLOrbFU1nuETDwnQXrDCXxSh8YnEA?=
 =?us-ascii?Q?jSDkLc1eL1r/pD99kVIX1Sh/d7kejbHIlfwHVG+HFsVgOfgIrynHdUzrDWz0?=
 =?us-ascii?Q?RrzXoK7cEYiwkZRwVfcIGwSfc3ZvIVP1W1G25JziEuY/NAYVsRDTVEmwYkeD?=
 =?us-ascii?Q?Jc748O2G3tPSIE7SRC0tf8/VHXgh4G4xARDRp6L1yOF5AEUdAd1+VbGCcg3R?=
 =?us-ascii?Q?OzksnV2RhzltaVFM4qyJBYE0rxfk1FyTJku7nUw1MCi2FhngG+fYSEagXqzQ?=
 =?us-ascii?Q?Q8DXa4RXKw0iJMTJ6ikQtZqOrv5TfO7VZuIgAPfGjHV4jJigy4bKuYuIHLJz?=
 =?us-ascii?Q?UdpUPmztoZ3pWF5gZJY15gaypW/2YZVLzo3p7LDQJgIk6ZmX7olNPfmKUI8b?=
 =?us-ascii?Q?hJIU2AiceLdCt7n4tQenIp/wZ3mDBWvUyFuxXoomekc9rGCY873+FcIdDplX?=
 =?us-ascii?Q?uQ3KG8ILBVIMpg8POcaUJuYUnRxeLTZhLborjU/Q9LRZoMvToO2hcSgdJYzH?=
 =?us-ascii?Q?ZMu6Y37DV5xMdbpouaEDHl9FuNGdJUcfOJ3kOD+Oc6uHpjaR69fVT9V4wh3G?=
 =?us-ascii?Q?wH2tsgCVzEE6ubXIrgWr+eZB/iwj8ashWZa7GNHbwxfqfbxeTrYtCSzBvPlV?=
 =?us-ascii?Q?f3msihEz4ktmxPZoiE26QmUrnpaqkaTpjoDZ7EtgPCaDLuw6X3Swp/IPNWKg?=
 =?us-ascii?Q?Xa+ULZUgxMrJ3t/CfUAI8bcX7w4ZcFIX4Fwy6kYe7ZmnekRmwBmrkGlqFXZk?=
 =?us-ascii?Q?rSb6WeIw9ZU4R2wXg6hIyLm+tzNTC/pwTi4PVyCyySUpcUHXkHuwUhBBI/An?=
 =?us-ascii?Q?9y+sHZ8raAhWz8rREdvnB4X8jWwWRYAc0OXgKMePD79vWLy6pFblXOpzMrg5?=
 =?us-ascii?Q?d+BDhJ58PqMI9BiuGDxxfAxv2p5LknIXXfrdAeBEWwdZ0v/v+pEu+MdkO8rJ?=
 =?us-ascii?Q?z6bOX9Tw0Qt20U827y5Kc3riRh1UOGip6HtGa5ZrEf6li/DdhovGTXb3ywgF?=
 =?us-ascii?Q?wxtXqpLlgRDnSMqPpMotHT0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	tMnFUgltFDZXYrar6GTtsTTD3pO94uK1xyS8+12Y2XJa+4595lDxntBUgsTVq7ApczyX3o7P9zYTdULbsdiiiHIwlpR/CNvQ2LJZ1FDG2Uj2yACjMds+GyRnJYAOw24SsKAUo7DkwvZ+Ovk8oKsGvuXhVakUHl9OQKnEnMSUez3O3SpmBcQ4vDFaNhW2gT6KQ126VXI5UX3uFp2yCVMCt+B16e4aZmPBpn6XGCsiv4iklg2zlsCAu27nb8xvBrD5t67B6jJ3aS6Z8THJwwN9dDLGXKWnIaf+t1EfotIiftzjSMKfi0llHdAPxnOLeWFIpj8ZqxBpzhoDq8pMaD9WTEj/hGwHY7xKlpSkNEKIuQzA/26A2l8lQnNreXbhWDyhM5qrVYv91k2K5Rdc1Y55pGxYzrmGI1QPExQGH4aPzrv/7m5irBg7i1CMZ9H+xInZSL8bLliIUXkNdC6o3II9k/guPpBWfPxN536A+X/DuD2a5QAUUX8K5MSTKePJCJtSFIksfmszHhAuo4Hf6KKMD8q8/R34aQQfoQi8Zp73VU1XRnNPJjsYHV5jY7MindQH6xZ87My3e/AsxB0zjDqLdcoaRddChw/rFEqib4/mc0pefFIFRVatXE/hC/X2Zppa
X-OriginatorOrg: quicinc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH3PR02MB10247.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 812d765b-8f1e-41a6-5062-08dc2e5a1314
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2024 19:12:38.1625
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3Vj+YxpbCbTDVUWN5ruX7WGBKSEPc6TvicszoATGOhWR/C1EIJafXlUhhv+2ak1vJk1AnskLILrMo3mp0ExQ3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR02MB9212
X-Proofpoint-ORIG-GUID: depU6vlbniuiam8OYXPgcviZESWQY9WH
X-Proofpoint-GUID: depU6vlbniuiam8OYXPgcviZESWQY9WH
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-15_18,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0
 impostorscore=0 adultscore=0 mlxscore=0 mlxlogscore=595 malwarescore=0
 spamscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2401310000 definitions=main-2402150154


> -----Original Message-----
> From: Masahiro Yamada <masahiroy@kernel.org>
> Sent: Thursday, February 15, 2024 8:07 AM
> To: linux-kbuild@vger.kernel.org
> Cc: Masahiro Yamada <masahiroy@kernel.org>; Brian Cain
> <bcain@quicinc.com>; linux-hexagon@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
>=20
> WARNING: This email originated from outside of Qualcomm. Please be wary o=
f
> any links or attachments, and do not enable macros.
>=20
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>=20
> Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS
> must
> also be selected to avoid the unmet dependency warning.
>=20
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>=20
>  arch/hexagon/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index a880ee067d2e..e922026fef09 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -7,7 +7,9 @@ config HEXAGON
>         select ARCH_32BIT_OFF_T
>         select ARCH_HAS_SYNC_DMA_FOR_DEVICE
>         select ARCH_NO_PREEMPT
> +       select ARCH_WANT_FRAME_POINTERS
>         select DMA_GLOBAL_POOL
> +       select FRAME_POINTER
>         # Other pending projects/to-do items.
>         # select HAVE_REGS_AND_STACK_ACCESS_API
>         # select HAVE_HW_BREAKPOINT if PERF_EVENTS
> @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET
>         help
>           Platforms that don't load the kernel at zero set this.
>=20
> -config FRAME_POINTER
> -       def_bool y
> -
>  config LOCKDEP_SUPPORT
>         def_bool y
>=20
> --
> 2.40.1


Acked-by: Brian Cain <bcain@quicinc.com>