Received-SPF: pass (google.com: domain of linux-kernel+bounces-67565-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID:
 <SEZPR06MB6959B783D324C7EF79095FE2964D2@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Fri, 16 Feb 2024 03:20:29 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] mmc: dw_mmc: add support for hi3798mv200
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Ulf Hansson <ulf.hansson@linaro.org>, Jaehoon Chung
 <jh80.chung@samsung.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: Igor Opaniuk <igor.opaniuk@linaro.org>,
 tianshuliang <tianshuliang@hisilicon.com>, David Yang <mmyangfl@gmail.com>,
 linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
 devicetree@vger.kernel.org
References: <20240216-b4-mmc-hi3798mv200-v1-0-7d46db845ae6@outlook.com>
 <20240216-b4-mmc-hi3798mv200-v1-1-7d46db845ae6@outlook.com>
 <682f2d6e-31fb-418c-9622-d3e5ebd4ee7f@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <682f2d6e-31fb-418c-9622-d3e5ebd4ee7f@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|SEZPR06MB7389:EE_
X-MS-Office365-Filtering-Correlation-Id: 07095a4b-0505-4a0e-b3a2-08dc2e5b2da8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cclkLH31eV2g/MwjOIaGxjyNQzShVtGHCxNiSrmoEZRSVXQW6sYk1yZBbxVMYz2y7a6gVmBE7znWTkUR20TK+8cCMNSLquyUBsy6at0Stof1O20FQWTJYFQBPqhIM71gwB8fW+hS7/UVjkggGUII9CU+d2H7uQPsS4FLhs+IZ/ryzOIC6mR96TlrtuIIvmGcXjZYj9Haaam+pQVLBfPs4T3TeiAL1wiAP49bylxx1q8EKnEqTmbcwlVUBxaJAtwv1WX9tAdEmhCK2Z1NpgWNaJr32MGbcr13ddnIPDExnED4MeLKltDutjSy+vdpg5hWRSnvdkaLz2Jol9cOGvPK1zujVz6hEROmAUFycbROXjrn4Pnw6hwC6vk4kO/wz3rBLcqX3mKDyPbYbyVobMEBC/FMLrOPah2r4quwPsGo6aHWOw5BwnMtDBvCokaVovYmGgESRlLVMnk6/TVQ6+ArUBe1XnTXEIJPmhyF2v1tBUN7i1KMIEgACPUznDzHY55u7OoBiJv9y5/lZ5mi1cPPvSkRFvxl8P5F+7JHSBZHkuqczyrhfMoEG35cjrHYrpWy
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cTRiSEgvMmNldGhYcjRjVVRiNk1GaThxbHQ1RVYybUxQZVk3ck5hNDVWbzVv?=
 =?utf-8?B?MjBadXdFNmVxbjFod3drQTRGNEJDMk44VXo1MUo2dmxqNnFqbzl1YlhrekNU?=
 =?utf-8?B?ckZpdzMrZktNTzhLUjlCVUVWd0lieUFUOVpLMkZ1b0hXVWVzazJ5VkJhSDlI?=
 =?utf-8?B?RzZoWVJybnJsdGY2ZkZ2UnlGNmZUdjI4WS9GYXlQSTJEeS9JLzlQdW5RRXhx?=
 =?utf-8?B?MnZrU2xIN0laOTQ5UEhsWktnTjRNTTZKTEpJZTFGOEErci8zd3RvdCtCQUV2?=
 =?utf-8?B?OGVPdDF4cStTb2xieCs4MkhoMVI0c0grUlNoWityTnNhcVJOYnpFYnZMaGQz?=
 =?utf-8?B?L1NJU2pSb2R2TlhZaFRnWnVueTU1TCtuZ1VGZnJ2S0V3eHJsYWthMkRZUGtW?=
 =?utf-8?B?eUpneFZFeEo0SmZrMk5mbGZtUXNXNzV0Nko2dFlaK2pHMGdKdGxTVW1IcmRS?=
 =?utf-8?B?cUc4dXYyS2VWTlcyaHFYbDlLKy9maDFiTEI5T3Vyd2FybjkxejBMakorRk5v?=
 =?utf-8?B?T1JBR0lqeEcwZy9kRHpGdExmSTRtbnVmYVNlTHR3L0J3dWtqOUJLcU5Vano2?=
 =?utf-8?B?M1RKMkJ3RWlXa1JpTWFrU2lHbjI3K2ZUYXRXMGkyVmlSMUR1NXlKMktEc3d3?=
 =?utf-8?B?SmtPak5pQVFYUDdnSDlCY3c0SGRaaDQxT3RpTzhYby9PK1VhMmdYbWFPRzVt?=
 =?utf-8?B?cm4yeGh2MnhBVm54SHFuL2pPTitZVkV0OFZUOVdXRHVvRHZqTU8vWGxKZG9V?=
 =?utf-8?B?QlhlNVNiYW5OZzByZXNKZkpadDViSm5tZVZtZVplaHo0dkwrMWowQW5xaWFq?=
 =?utf-8?B?K1JTaFFyOG53dklMTWVzbzkyMGZvZFJWU0hVUXhXd3NTUVVZUHRNL0Y0dC9l?=
 =?utf-8?B?aEU0YnY2cnFhS1cxdWk1c0hscXQ0VGRSY1ZvZnNDeEhNNFB4WXVHeERmNlRF?=
 =?utf-8?B?bitaZXpkWUJwcS9YdEROVnhiYXlhSUw5QmU2NzMxVlkvbDE0RDZ2aE8ySUJj?=
 =?utf-8?B?bzFoZWE3WDhxMTRrbW1VMFdCaDh2eVU0eXg4V2c3QXhNNmw1QURNcjFWUDBB?=
 =?utf-8?B?YUFqUGZMSzMybFA4b0lMM2syN2VpRDA2SDk5dW1LWDJUMC9uV0djVlEwZHgw?=
 =?utf-8?B?VVplRHgydmhPVk5vVkhCQjJYTU1PYW1abTYvWElPOGRmVVV2VmZUTVRSNmFB?=
 =?utf-8?B?bEJiQWRXRVU4aFg2Snd5NEd2aStUejFhUEw2SnpUQks3cVVXVXFPcFdNM1pZ?=
 =?utf-8?B?U1dmKzhmOGhlRitIcTV6TmFNUW5CSXJnYXduVGJ5d0kwS0ZVUlRLc0hHemNk?=
 =?utf-8?B?YlpEL3lpZUg3VW5XNVQrT3hZNWxKdlNWSXljdGt4aTMwWUI0cThIYjU0NEM4?=
 =?utf-8?B?K3hZMmFnbzVNMzVDVGRvc3lTYmJBRGRyZTgyWmlCcmYyZEdWN1ZLdGYwUmk5?=
 =?utf-8?B?MUU3OGZjbi9qaVdKVVdXWWxpOXhRbS9OM0VpT2R1dDFXcGszSkc0cWQ1RXBw?=
 =?utf-8?B?U2tTTUdiL21VSDE1K1JCY3hDMUxVR3Zka3IzQzF3SDF2U0l0ZHE1d1RqZ1pB?=
 =?utf-8?B?UnEwd0pxL05FVVZKWjBQTC9HTVR1Y05GSHVIb2hQWmtLTmNMY256Sk5aYWly?=
 =?utf-8?B?NzM3UnU2OXNsNytaSGlmbGxsMjNOQ05RTHJCeTJZZU4yZnZJb3JpdVFaK2Ns?=
 =?utf-8?B?MVBWbHB5RlpUMEFWbC9oQzU4TkxuL3NHVmlJb2g2QWtMM3pkaDRSZkZIUlYz?=
 =?utf-8?Q?z8ljiAzfvR9BhX1r+8+y1pjAeU5MfB8007WK7s7?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07095a4b-0505-4a0e-b3a2-08dc2e5b2da8
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 19:20:32.4234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB7389

On 2/16/2024 3:15 AM, Krzysztof Kozlowski wrote:
> On 15/02/2024 18:46, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> Add support for Hi3798MV200 specific extension.
>>
>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>
>> +
>> +static int dw_mci_hi3798mv200_init(struct dw_mci *host)
>> +{
>> +	struct dw_mci_hi3798mv200_priv *priv;
>> +	struct device_node *np = host->dev->of_node;
>> +
>> +	priv = devm_kzalloc(host->dev, sizeof(*priv), GFP_KERNEL);
>> +	if (!priv)
>> +		return -ENOMEM;
>> +
>> +	mmc_of_parse_clk_phase(host->dev, &priv->phase_map);
>> +
>> +	priv->sample_clk = devm_clk_get_enabled(host->dev, "ciu-sample");
>> +	if (IS_ERR(priv->sample_clk)) {
>> +		dev_err(host->dev, "failed to get enabled ciu-sample clock\n");
> syntax is: return dev_err_probe()
Will fix in next version.
>
>> +		return PTR_ERR(priv->sample_clk);
>> +	}
>> +
>> +	priv->drive_clk = devm_clk_get_enabled(host->dev, "ciu-drive");
>> +	if (IS_ERR(priv->drive_clk)) {
>> +		dev_err(host->dev, "failed to get enabled ciu-drive clock\n");
> syntax is: return dev_err_probe()
Will fix in next version.
>
>> +		return PTR_ERR(priv->drive_clk);
>> +	}
>> +
>> +	priv->sap_dll_reg = syscon_regmap_lookup_by_phandle(np, "hisilicon,sap-dll-reg");
>> +	if (IS_ERR(priv->sap_dll_reg)) {
>> +		dev_err(host->dev, "failed to get sap-dll-reg\n");
> syntax is: return dev_err_probe()
Will fix in next version.
>
>> +		return PTR_ERR(priv->sap_dll_reg);
>> +	}
>> +
>> +	host->priv = priv;
>> +	return 0;
>> +}
>> +
> ....
>
>> +
>> +MODULE_DEVICE_TABLE(of, dw_mci_hi3798mv200_match);
>> +static struct platform_driver dw_mci_hi3798mv200_driver = {
>> +	.probe = dw_mci_hi3798mv200_probe,
>> +	.remove_new = dw_mci_hi3798mv200_remove,
>> +	.driver = {
>> +		.name = "dwmmc_hi3798mv200",
>> +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
>> +		.of_match_table = dw_mci_hi3798mv200_match,
>> +	},
>> +};
>> +module_platform_driver(dw_mci_hi3798mv200_driver);
>> +
>> +MODULE_DESCRIPTION("HiSilicon Hi3798MV200 Specific DW-MSHC Driver Extension");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:dwmmc_hi3798mv200");
> You should not need MODULE_ALIAS() in normal cases. If you need it,
> usually it means your device ID table is wrong (e.g. misses either
> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
> for incomplete ID table.
Will fix it in v2. I simply copied this from dw_mmc-hi3798cv200.c and 
s/cv200/mv200/. I'll remove it for dw_mmc-hi3798cv200.c in next version 
too because it seems not useful in that driver too.
> Best regards,
> Krzysztof
>

-- 
Regards,
Yang Xiwen