Received-SPF: pass (google.com: domain of linux-kernel+bounces-67578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 15 Feb 2024 19:27:52 +0000
From: Conor Dooley <conor@kernel.org>
To: Durai Manickam KR <durai.manickamkr@microchip.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: convert atmel-dma.txt to YAML
Message-ID: <20240215-broken-emu-64a6dabc43e2@spud>
References: <20240215-dmac-v1-1-8f1c6f031c98@microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="/iXZ72FAuAF0yk9f"
Content-Disposition: inline
In-Reply-To: <20240215-dmac-v1-1-8f1c6f031c98@microchip.com>


--/iXZ72FAuAF0yk9f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 15, 2024 at 04:15:44PM +0530, Durai Manickam KR wrote:
> Added a description, required properties and appropriate compatibles
> for all the SoCs that are supported by microchip.
>=20
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
> ---
>  .../devicetree/bindings/dma/atmel-dma.txt          | 42 -------------
>  .../bindings/dma/microchip,at91-dma.yaml           | 71 ++++++++++++++++=
++++++
>  2 files changed, 71 insertions(+), 42 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/dma/atmel-dma.txt b/Docume=
ntation/devicetree/bindings/dma/atmel-dma.txt
> deleted file mode 100644
> index f69bcf5a6343..000000000000
> --- a/Documentation/devicetree/bindings/dma/atmel-dma.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -* Atmel Direct Memory Access Controller (DMA)
> -
> -Required properties:
> -- compatible: Should be "atmel,<chip>-dma".
> -- reg: Should contain DMA registers location and length.
> -- interrupts: Should contain DMA interrupt.
> -- #dma-cells: Must be <2>, used to represent the number of integer cells=
 in
> -the dmas property of client devices.
> -
> -Example:
> -
> -dma0: dma@ffffec00 {
> -	compatible =3D "atmel,at91sam9g45-dma";
> -	reg =3D <0xffffec00 0x200>;
> -	interrupts =3D <21>;
> -	#dma-cells =3D <2>;
> -};
> -
> -DMA clients connected to the Atmel DMA controller must use the format
> -described in the dma.txt file, using a three-cell specifier for each cha=
nnel:
> -a phandle plus two integer cells.
> -The three cells in order are:
> -
> -1. A phandle pointing to the DMA controller.
> -2. The memory interface (16 most significant bits), the peripheral inter=
face
> -(16 less significant bits).
> -3. Parameters for the at91 DMA configuration register which are device
> -dependent:
> -  - bit 7-0: peripheral identifier for the hardware handshaking interfac=
e. The
> -  identifier can be different for tx and rx.
> -  - bit 11-8: FIFO configuration. 0 for half FIFO, 1 for ALAP, 2 for ASA=
P.
> -
> -Example:
> -
> -i2c0@i2c@f8010000 {
> -	compatible =3D "atmel,at91sam9x5-i2c";
> -	reg =3D <0xf8010000 0x100>;
> -	interrupts =3D <9 4 6>;
> -	dmas =3D <&dma0 1 7>,
> -	       <&dma0 1 8>;
> -	dma-names =3D "tx", "rx";
> -};
> diff --git a/Documentation/devicetree/bindings/dma/microchip,at91-dma.yam=
l b/Documentation/devicetree/bindings/dma/microchip,at91-dma.yaml
> new file mode 100644
> index 000000000000..a0a582902e4d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/microchip,at91-dma.yaml

Filename matching the compatible please.

> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/microchip,at91-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel Direct Memory Access Controller (DMA)
> +
> +maintainers:
> +  - Ludovic Desroches <ludovic.desroches@microchip.com>
> +  - Tudor Ambarus <tudor.ambarus@linaro.org>
> +
> +description: |

The | is not needed.

> +  The Atmel Direct Memory Access Controller (DMAC) transfers data from a=
 source
> +  peripheral to a destination peripheral over one or more AMBA buses. On=
e channel
> +  is required for each source/destination pair. In the most basic config=
uration,
> +  the DMAC has one master interface and one channel. The master interfac=
e reads
> +  the data from a source and writes it to a destination. Two AMBA transf=
ers are
> +  required for each DMAC data transfer. This is also known as a dual-acc=
ess transfer.
> +  The DMAC is programmed via the APB interface.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - atmel,at91sam9g45-dma
> +          - atmel,at91sam9rl-dma
> +  reg:
> +    description: Should contain DMA registers location and length.

Drop the description from these common properties.

> +    maxItems: 1
> +
> +  interrupts:
> +    description: Should contain the DMA interrupts associated to the DMA=
 channels.
> +    maxItems: 1
> +
> +  "#dma-cells":
> +    description:
> +      Must be <2>, used to represent the number of integer cells in the =
dmas
> +      property of client devices.

You've lost the description of how these cells work, which is somewhat
unique and needs to be preserved.
This is the only property that needs a description.

> +    const: 2
> +
> +  clocks:
> +    description: Should contain a clock specifier for each entry in cloc=
k-names.
> +    maxItems: 1
> +
> +  clock-names:
> +    description: Should contain the clock of the DMA controller.
> +    const: dma_clk

This is a new addition? You should call out in the commit message wat
you've added that was not in th text binding.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#dma-cells"
> +  - clocks
> +  - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dma0: dma-controller@ffffec00 {

Drop the label, its not used.

Thanks,
Conor.

> +            compatible =3D "atmel,at91sam9g45-dma";
> +            reg =3D <0xffffec00 0x200>;
> +            interrupts =3D <21>;
> +            #dma-cells =3D <2>;
> +            clocks =3D <&pmc 2 20>;
> +            clock-names =3D "dma_clk";
> +    };
> +
> +...
>=20
> ---
> base-commit: 7e90b5c295ec1e47c8ad865429f046970c549a66
> change-id: 20240214-dmac-5f48fd7f3b9d
>=20
> Best regards,
> --=20
> Durai Manickam KR <durai.manickamkr@microchip.com>
>=20

--/iXZ72FAuAF0yk9f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc5luAAKCRB4tDGHoIJi
0pZ7AP9n//Tc16Y7sathkrqYZctgnGZndX8EG6lO9YREEHFWSgEA9A8snBLnm4Gz
wPMTjmPK3L6Re/0FWReZcHxvibMJeAU=
=4pGP
-----END PGP SIGNATURE-----

--/iXZ72FAuAF0yk9f--