Received-SPF: pass (google.com: domain of linux-kernel+bounces-67594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240215145602.1371274-1-max.kellermann@ionos.com>
 <20240215145602.1371274-7-max.kellermann@ionos.com> <Zc5lUbCU6xNXv6jC@casper.infradead.org>
In-Reply-To: <Zc5lUbCU6xNXv6jC@casper.infradead.org>
From: Max Kellermann <max.kellermann@ionos.com>
Date: Thu, 15 Feb 2024 20:35:58 +0100
Message-ID: <CAKPOu+9z0T=dvXMA6YUkuaTnEHwz02jRWdCdAOJ+4spyknMJ0w@mail.gmail.com>
Subject: Re: [PATCH v1 06/14] linux/mm.h: move page_size() to mm/page_size.h
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 15, 2024 at 8:26=E2=80=AFPM Matthew Wilcox <willy@infradead.org=
> wrote:
> We're really close to eliminating page_size().  Just 23 callers left.
> As such, it would be a mistake to name the header after it.  I don't
> particularly like how you're splitting up mm.h; I think the real problem
> is all the code that says "Oh, I'm allocating memory, I should include
> mm.h" instead of including gfp.h or slab.h.

Yes, a lot of source files do that, but that mistake is not something
I'm addressing in this patch series; another patch series I posted two
weeks ago is about that.
This series is only about making sources lighter which currently
indeed need mm.h.

> But if you must split it like this, at least call it folio_size.h

Okay, I will rename it for v2.