Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp673292rdb; Thu, 15 Feb 2024 11:37:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUUVYgypcowHPF3yeqFX5xuVQp3QOa3ynK7VV3eXwa0nZxSBh51hdH8DR60AVNNZWACKmIbKLr/ItNYZHqnF/TA6bNps7ee0xdor7+VEQ== X-Google-Smtp-Source: AGHT+IHzSjLfajLKf7KfcgQi1e/ltWzSux0thacCmVqAUCfQxacwpZkxbfJQnQsohP5W+EEB2zz1 X-Received: by 2002:a05:6870:4152:b0:21d:fc77:fcc8 with SMTP id r18-20020a056870415200b0021dfc77fcc8mr2962768oad.34.1708025846152; Thu, 15 Feb 2024 11:37:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708025846; cv=pass; d=google.com; s=arc-20160816; b=tFw3lwZXXrSspnvgzV51b+Y2dY3HkrsIyBUpZI4vDkjhoDSFdAhhDldAGDrydrWuHe 5kqvtUHV2knxtcWA7UJCvPU9hJjepvTEtpG6SzYfWB8RPPy3h4kolUVKlSTlYKSWIURF 0duP7GMCXGdVxzJyhCPd5kbJyIThS1z2OQ7K3sfRGVjBwtNas0DU5DmUy6vEAUOjz55c jgjPpjNCeA5Kh+/R7GUYsW6z9Fu97thdSjEDs3glPRYX0asnd1tI7MDhnqA8kzaX6XG1 SDR+dQ2TQ+95/SFGGLP5QjTsWyLEG/mbkn4bh3mCef/0OSXdXdS0dQekp+X7AnZYXNSj R6Vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=qQdOnaUP5H9DK70UwFji6brSoUJN3Qo/OYN31JKGHwY=; fh=XxTlMDKMfoD683vE3Grcpct3v4uajPZbXOEr0GgX7Ug=; b=0f6spGPWvwFxluhiK/eA1DPzlxwA0WYBWHkNW6An9/20XZR9srivtutCwYqcHYzhsM 71mQ+w63C1TUuRJpTBG8CAC2SN7cVqW4CfpGgvXQVRdMWwAroeROBVB9/2etf3qala8o DbwEgcHyMSk6IZlJZQKB/wdaziP5i4coSjVKiC72ESh3pPPH2kEV9cB2Z8E/NWUN6Av4 dk+tDpjm9myxl6+Ug5fMfeYXVXY5Abnyi65WKyZ/DTlOu+/gpROqk/xepfwn+u6pXg4X b5PmT2r66MlhP0vf7dSF3a1sKiQ3CQDIe3lOLiHvk5MiJr4IaYuZQUA9bueH+3luWs4P 9lUQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Wl0Wu+6x; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-67557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67557-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s16-20020a656910000000b005dc88726780si1578085pgq.374.2024.02.15.11.37.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 11:37:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-67557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Wl0Wu+6x; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-67557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67557-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AD886B23AC4 for ; Thu, 15 Feb 2024 19:14:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3170713957E; Thu, 15 Feb 2024 19:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Wl0Wu+6x" Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE8F212BEAF; Thu, 15 Feb 2024 19:13:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708024436; cv=none; b=aHMWl+z0GyJ205WzfMtEtLkPNKyTFgmv5AiOtuHLtJyws2J7EZ5YmULxWut1Y4u4wH6hWPcekYmZ+xi8faqBC/nrhtGovl62wg4asrd3Tg2xwUnvPmhE4CBRzeFU4KS86UUPw32AJcbj81sMNtNanUjA2lumUNg5nMpgvAo7Znk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708024436; c=relaxed/simple; bh=44mczymDGvNgMv7iEhFmUone4ZYqu1Uqz3b+QJE5j80=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hfdX3zqXfiUEVlsoVpm2/4GluigNDVj85LAomqqODJfyzhp0p8bH2dgDw6DQ4yyV7IJ2ed9Qa5C1zAEAJl3kHfoJbGry5WBhsJBA0QgnU9KMaCH0vEk/uFfO2iE8xmTG8c5RUGajRZv2pY8SXGMjtBD7+zGxNc2hQ23+4X3JaLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Wl0Wu+6x; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FIU18f025950; Thu, 15 Feb 2024 19:13:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=qQdOnaUP5H9DK70UwFji6brSoUJN3Qo/OYN31JKGHwY=; b=Wl0Wu+6x35mDOkc83bi+Amtgh008rwnJJSnUYMUV5895f2ysPdv3KpIe07v158nlbV/g ghb5h3dypB+QxeTz6oQivPaKLPfltf/5Elok1D6zkA1Hfp4bFN96im0NTNvoz+b34xJP 4ir85AInn1pbwp9E37WyYiWAYNmuelPff/RUUn4IgkXEwLdeiuwiz6H6C3xanSei5Xk2 chkLhJaGn4ykO/KJpaUBQnK0GICdoN5rTGYE9VZvRHNuthH18wBOKQ6KkkcoFGIPXg1t I6aRy9YcJA4EK/Tiwpm5lL+Pw4AWa+Kr04SdOj+/3f/pJB0Atl/MjLKBcV7r9Brh7oHD hw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w9nj9n82v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 19:13:39 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41FIuIDO011290; Thu, 15 Feb 2024 19:13:38 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w9nj9n82d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 19:13:38 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41FIi5TU032600; Thu, 15 Feb 2024 19:13:37 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3w6kfty0ej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 19:13:37 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41FJDZxQ4850360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 19:13:37 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55E7558061; Thu, 15 Feb 2024 19:13:35 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F4E458058; Thu, 15 Feb 2024 19:13:35 +0000 (GMT) Received: from localhost (unknown [9.41.178.242]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 Feb 2024 19:13:35 +0000 (GMT) From: Nathan Lynch To: Michal Suchanek , linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Shuah Khan , Michal Suchanek , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests: powerpc: Add header symlinks for building papr character device tests In-Reply-To: <20240215165527.23684-1-msuchanek@suse.de> References: <20240215165527.23684-1-msuchanek@suse.de> Date: Thu, 15 Feb 2024 13:13:34 -0600 Message-ID: <87cysxilr5.fsf@li-e15d104c-2135-11b2-a85c-d7ef17e56be6.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: WNSDgHdCHwYeiyh7cahTZ6b9lx-jyrNw X-Proofpoint-GUID: aLWAHrReJkp_p3mBfLgYuXMvh5u07EJ1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_18,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=432 malwarescore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 clxscore=1011 impostorscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150154 Michal Suchanek writes: > > Without the headers the tests don't build. > > Fixes: 9118c5d32bdd ("powerpc/selftests: Add test for papr-vpd") > Fixes: 76b2ec3faeaa ("powerpc/selftests: Add test for papr-sysparm") > Signed-off-by: Michal Suchanek > --- > tools/testing/selftests/powerpc/include/asm/papr-miscdev.h | 1 + > tools/testing/selftests/powerpc/include/asm/papr-sysparm.h | 1 + > tools/testing/selftests/powerpc/include/asm/papr-vpd.h | 1 + > 3 files changed, 3 insertions(+) > create mode 120000 tools/testing/selftests/powerpc/include/asm/papr-miscdev.h > create mode 120000 tools/testing/selftests/powerpc/include/asm/papr-sysparm.h > create mode 120000 > tools/testing/selftests/powerpc/include/asm/papr-vpd.h I really hope making symlinks into the kernel source isn't necessary. I haven't experienced build failures with these tests. How are you building them? I usually do something like (on a x86 build host): $ make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- ppc64le_defconfig $ make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- headers $ make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- -C tools/testing/selftests/powerpc/ without issue.