Received-SPF: pass (google.com: domain of linux-kernel+bounces-67601-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240215145602.1371274-1-max.kellermann@ionos.com>
 <20240215145602.1371274-8-max.kellermann@ionos.com> <Zc5lnHpYWmuX38_o@casper.infradead.org>
In-Reply-To: <Zc5lnHpYWmuX38_o@casper.infradead.org>
From: Max Kellermann <max.kellermann@ionos.com>
Date: Thu, 15 Feb 2024 20:41:04 +0100
Message-ID: <CAKPOu+8-nbMpi0WKFUAp4eap1BNYnojcVcyNU1wug9ibxvOtqQ@mail.gmail.com>
Subject: Re: [PATCH v1 07/14] linux/mm.h: move folio_next() to mm/folio_next.h
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 15, 2024 at 8:27=E2=80=AFPM Matthew Wilcox <willy@infradead.org=
> wrote:
> I feel there's a lot more you could say here.  Like "There are N files
> which only include mm.h in order to use folio_next()".

You can see this detail in the last patch (14/14), but if you prefer
to have this spelled out here, I'll amend the patch description.

Though I only worked on the headers, not the thousands of sources
which might also be able to reduce their header dependencies. Getting
the exact number of those is a huge effort, and it's worth it, but not
today. Once this patch series is merged, we can incrementally start
this, but these patches are the precondition.

> Otherwise ...
> why is this more than churn?

This is about code correctness and faster compile times. You may or
may not value that, much of this is really just opinion. Similar
efforts have been merged recently, which is why I thought this goal
was consensus among kernel people.