Date: Wed, 26 Dec 2007 13:28:45 -0800 (PST)
From: Christoph Lameter <clameter@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
cc: Ingo Molnar <mingo@elte.hu>, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, andi@firstfloor.org,
       a.p.zijlstra@chello.nl
Subject: Re: [PATCH] slub: /proc/slabinfo ABI compatibility
In-Reply-To: <84144f020712241259o27f4015ai1128fbb675d079ef@mail.gmail.com>
Message-ID: <Pine.LNX.4.64.0712261323050.16904@schroedinger.engr.sgi.com>
References: <Pine.LNX.4.64.0712221446280.24655@sbz-30.cs.Helsinki.FI> 
 <20071222131601.GB32558@elte.hu> <20071222133727.GA12031@elte.hu> 
 <Pine.LNX.4.64.0712241110240.8802@schroedinger.engr.sgi.com>
 <84144f020712241259o27f4015ai1128fbb675d079ef@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1078
Lines: 27

On Mon, 24 Dec 2007, Pekka Enberg wrote:

> On Dec 24, 2007 9:12 PM, Christoph Lameter <clameter@sgi.com> wrote:
> > Hmmm... What is the combination of config variables that causes this? I
> > moved the count_partial function in mm in order to make the merge of slab
> > defrag easier.
> 
> I think it's CONFIG_PROC_FS without CONFIG_SYSFS.

The only user of count_partial is in slab_objects() which is in a 
section that is

#if defined(CONFIG_SYSFS) && defined(CONFIG_SLUB_DEBUG)

There should be no use if CONFIG_SYSFS is not set. I think we get a 
warning about a function that is never called when compiling the current 
mm code without SLUB_DEBUG or CONFIG_SYSFS (because the slab defrag use 
has not been merged yet).

In mm count_partial() is always defined. In Linus tree count_partial() 
comes just before slab_objects().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/