Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp691776rdb; Thu, 15 Feb 2024 12:15:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUtwyjZHUVsJSG9nfTl5me3swIKsUU9AdgmZA5jNlKxrZDRwaU1J8IPTReCLiFHmKS8aPyiQEOxjOD/9GCOazA7CozDJkPzlZCSp8lt2g== X-Google-Smtp-Source: AGHT+IG+c1jOB+173tZcES+5kFUk0EEJwvlDiqbnMffUHuJ5eunnf5uvq1cpPc5F/nkug/MJm7qO X-Received: by 2002:a17:90a:ac11:b0:298:bc68:a8c8 with SMTP id o17-20020a17090aac1100b00298bc68a8c8mr2829576pjq.6.1708028155563; Thu, 15 Feb 2024 12:15:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708028155; cv=pass; d=google.com; s=arc-20160816; b=n9yrbBaL+9YULmnxtyEr04efkd2HQdiIDhNdPCP4HG9v2EYpFFgpZBm+PAto8IViqD aURfPzngAIyYjblucNz0WNzlQSD0plqk06y/DiDPPfOdt8OUWlqk/13RZwASDxJ7I6u7 tsELP7HNhKRxDz2NdgenZpFS6oR0rI3DlBoQtmbagXrvOHtSKJO6poDRQS56xA+KTXfn AayFxqf1YeemKmNUfufMeDGpIqWIItUokvtC6xTD4Kd21iMWhtfJPM87RgQq8u5cs7ii NlPK9N0Hqpp4IZDG8+Nj2jHHCTgFhgAJocjgdAC1E//7WRgaHU5miDWFULOsgBQPJVFk Fk1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0hDV144BFjsd9eBmeIR68UbZ9/AgjyHKPCmhViDvmjs=; fh=tfmq7aHYPDM9cs7ujYphq8Eu/gd4EygwdcBz1e2DmeY=; b=q92ZqVnk0l6YZewA9elJnSfUl4UICWEgSnEXRvc/6o9UrxzM7yoeic2FULemtoFVFu klRsWxdZqSu3W6MEYjF2GPRmmwaWcPN2USqBIOMHSPlOc9oQ1E200E8xLx6HOtJ1oqAt JMt8VBQ0esEw/Jpv/AQNgKGZMhxOQI+OubihC0E3wDD0nM+j7VUnT50n0nCvKpLRQx0G qFx7bXy7wyUZyB0ZGwZxYvyxtEDkO7qSB0IVENZNOHyg0/zSMoa7WW/YPEGAFNeAJLRh P1i1O3tp2mj4lTWykSaorXHP2q1O0/b9sM1juL7+gffZsjD/Tl2lGeqoSMkbToSqwYNT 7RRg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="aGqecW/i"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-67606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67606-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id p15-20020a17090ad30f00b002961d85e39dsi3524102pju.81.2024.02.15.12.15.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 12:15:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-67606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="aGqecW/i"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-67606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67606-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B06F2B216D5 for ; Thu, 15 Feb 2024 19:45:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2D7513A87E; Thu, 15 Feb 2024 19:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aGqecW/i" Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F3461386A4 for ; Thu, 15 Feb 2024 19:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708026294; cv=none; b=DkGnUgWqsRqaQc00ToW3OdTk3rLG9C9sYBFXl4kuzkTzk+kufcEBmuJ0n2z2hRXP3t37O4bAkilV/muGYIfDT8EDzJIadMenv+uJMszJK0mSvfBKT0V7ZDm2LQI/3Bm+o/gXkQGPhi0cyFDhk/YD0YDr1PYRc34DXVb84i5GoU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708026294; c=relaxed/simple; bh=3cQ305fQjLggWM1EqW102dAerdwvIg6LDFX8WTSlQBs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BiwZ7rp4NiXehWKd5u6Jd4Z6yWnSZjXuFGetBkflEgJihOnpgpBc+fJo21PxOKst2iRYRLVNrf3Ngd8/cE1H1imheiFki1MHySqu4mqDTlp+sqrlTmiSHG61C97Q3y8T+OsODLKc7D904OIMWn/U8SS646SWwxZpSG17L07TYfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=aGqecW/i; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e104196e6eso1309065b3a.0 for ; Thu, 15 Feb 2024 11:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708026293; x=1708631093; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0hDV144BFjsd9eBmeIR68UbZ9/AgjyHKPCmhViDvmjs=; b=aGqecW/icQqZdRGfozZoLDspPO0Y73F3xwlKF4uDhicaMTJcxxPFpYr40aOeGrSXXO tUOmpvT/p+8bsQusDSQtnXOOp7nru25dFzYCmageEAW1RcrCftnpbEnqDCX3+00FYCG5 5diXyeXjU6yM9ayHnvJznkoM6rhSfix16/vvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708026293; x=1708631093; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0hDV144BFjsd9eBmeIR68UbZ9/AgjyHKPCmhViDvmjs=; b=adyes75HFk/iUjsgQ15fI5M3Gm39dRVUwxovWgWqBE+4SLSxfjX5b771RygL9s1iHB tsEnihdAMm+5Hp9HFInbJoMh+zi1UrMvovCZTTofxPjO8fgxMUUdw96hgATfh1jjbOKs yAmsfR0IiOb9jpXBMGhQSsl8/B64BSpzQJyMBuIYFxmfEPh70TWcuF2eO6qEAJki+km1 Qx97/iTRihiEdyYp53GRtvJFXetpenqNQ18ebVzzqqjlmki/S7L19Tw2x3Mrm4JtkneQ EwLEJ3INvnLhALzaCRJTCF7wjZW13s6hkKIqNeQvc2SqZgt650Tvd6vV3FvXG5tFN/dl B9kA== X-Forwarded-Encrypted: i=1; AJvYcCVvWSbIax9fcn1o5ZRbuwoe7bGJdJh9Mxsc8c8voVw+WXkoJeok7a3K05gT1S8mosFBcmASgQ3EuLAnVN0xZ7eDp3iUQdyFtVwu6D/N X-Gm-Message-State: AOJu0YwCzXblyFbbTa38jXJ374wiGhcjc9MyVfSw3vx0oHko+920M4m5 XrcaBaNX2NDMGkipS4HZvRWgclkan6UE4SJWdInIrq47dbEkpgtMgH7iA4rgTw== X-Received: by 2002:a62:f20c:0:b0:6e0:47b9:b727 with SMTP id m12-20020a62f20c000000b006e047b9b727mr2675158pfh.30.1708026293017; Thu, 15 Feb 2024 11:44:53 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id k19-20020aa788d3000000b006e07f1829b0sm1695902pff.219.2024.02.15.11.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 11:44:52 -0800 (PST) Date: Thu, 15 Feb 2024 11:44:52 -0800 From: Kees Cook To: Andy Shevchenko Cc: Michal Wajdeczko , Jani Nikula , Julia Lawall , Nicolas Palix , cocci@inria.fr, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] cocci: Add rules to find str_plural() replacements Message-ID: <202402151144.70E863483C@keescook> References: <20240215180156.work.548-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 15, 2024 at 09:34:01PM +0200, Andy Shevchenko wrote: > On Thu, Feb 15, 2024 at 09:33:31PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 15, 2024 at 10:02:00AM -0800, Kees Cook wrote: > > > Add rules for finding places where str_plural() can be used. This > > > currently finds: > > > 54 files changed, 62 insertions(+), 61 deletions(-) > > > > Can we extend this to cover string_choices and call the script probably > > str_choices.cocci ? > > (And add it to MAINTAINERS?) Sure! I'll send a v2. -- Kees Cook